Re: Application usage statistics and targeted user surveys

2017-06-12 Thread Albert Astals Cid
El dissabte, 10 de juny de 2017, a les 10:11:44 CEST, Volker Krause va escriure: > On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote: > > On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid wrote: > > > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va > >

D6202: Expand apidox of KJobWidget::setWindow()

2017-06-12 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Follow up of https://phabricator.kde.org/D6142 REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D6202 AFFECTED FILES src/kjobwidgets.h

D6142: Fix drop menu position on Wayland

2017-06-12 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1e251d2f6a42: Fix drop menu position on Wayland (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6142?vs=15263=15399 REVISION DETAIL

D6198: Add KAuth support to delete operation

2017-06-12 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6198 To: chinmoyr, elvisangelaccio, #frameworks

D6197: Add basic KAuth support to file ioslave

2017-06-12 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. It all makes sense, so good from my side. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6190 To: leinir, #knewstuff, apol Cc: apol, #frameworks, ZrenBot

D6199: Allow deleting from write-protected location in dolphin

2017-06-12 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a subscriber: Konqueror. REVISION SUMMARY This is a temporary patch which allows deleting items from write-protected location. This is only for testing the diff's https://phabricator.kde.org/D6197 and

D6197: Add basic KAuth support to file ioslave

2017-06-12 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6198: Add KAuth support to delete operation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks

D6198: Add KAuth support to delete operation

2017-06-12 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This patch makes it possible to delete root owned files and folders. To avoid any accidental deletion a warning is shown informing the user about the write-protection. The warnings can either

D6197: Add basic KAuth support to file ioslave

2017-06-12 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This patch adds the relevant KAuth code to file ioslave that can be used to perform various file management operations with escalated privilege. //execWithRoot()// : This method performs the

D5069: initial implementation of a platform plugin for OS X

2017-06-12 Thread René J . V . Bertin
rjvbb updated this revision to Diff 15380. rjvbb edited the summary of this revision. rjvbb added a comment. rebased on v4.100.0-rc1-220-g0196c66 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5069?vs=12521=15380 REVISION DETAIL https://phabricator.kde.org/D5069 AFFECTED FILES

D5069: KWindowSystem: initial implementation of a platform plugin for OS X

2017-06-12 Thread René J . V . Bertin
rjvbb retitled this revision from "initial implementation of a platform plugin for OS X" to "KWindowSystem: initial implementation of a platform plugin for OS X". rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to R278 KWindowSystem. REPOSITORY R278

D6192: Set Containments to have focus within the view

2017-06-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b0e8ea29fab4: Set Containments to have focus within the view (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6192: Set Containments to have focus within the view

2017-06-12 Thread Kai Uwe Broulik
broulik added a comment. BUG: 381124 REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6192 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6192: Set Containments to have focus within the view

2017-06-12 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6192 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15377. leinir added a comment. Don't const & an int, that's just silly. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6190?vs=15373=15377 REVISION DETAIL https://phabricator.kde.org/D6190 AFFECTED FILES

D6192: Set Containments to have focus within the view

2017-06-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Now that applets are their own focus scope (which makes sense) we've also made containments their own focus

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Dan Leinir Turthra Jensen
leinir added a comment. As far as i can gather, it was simply never added because, well, it was never used in a lot of places... This really is more a case of equalising some features between requestData and other parts of the engine (so they can all be paginated by the size they really

D6122: Add since tags.

2017-06-12 Thread Thomas Friedrichsmeier
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e48e34bd0288: Add since tags. (authored by tfry). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6122?vs=15226=15376 REVISION DETAIL

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Aleix Pol Gonzalez
apol added a comment. I have no idea about the patch itself, why it wasn't exposed so far that is. INLINE COMMENTS > engine.cpp:144 > + */ > +void setPageSize(const int& pageSize); > Q_SIGNALS: I wouldn't pass an int as `const&` REPOSITORY R304 KNewStuff REVISION DETAIL

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Engine has a pageSize variable which has been mostly unused, but which comes in very handy when getting

D6180: Makefile: Remove invalid keyword entries in makefile.xml

2017-06-12 Thread Alex Richardson
arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me! I forgot to remove these when I commited the bmake support. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6180 To:

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

2017-06-12 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to textChanged() for text property. (authored by arrowdodger). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 20 - Unstable!

2017-06-12 Thread no-reply
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/20/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 12 Jun 2017 09:09:11 + Build duration: 2 min 0 sec and counting

D6149: [KOpenWithDialog] HTML-escape file name

2017-06-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:90c1f7c8a9d6: [KOpenWithDialog] HTML-escape file name (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6149?vs=15275=15370 REVISION DETAIL

D5417: add an extractor using qtmultimedia

2017-06-12 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. If this extractor is worse than the taglib one, shouldn't the cmake run issue a warning about that? Or does it already do so because "taglib not found"? INLINE COMMENTS >

Re: Application usage statistics and targeted user surveys

2017-06-12 Thread David Faure
On samedi 10 juin 2017 10:11:44 CEST Volker Krause wrote: > On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote: > > On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid wrote: > > > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va > > > > > > escriure: > >

D6149: [KOpenWithDialog] HTML-escape file name

2017-06-12 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Man you have fun filenames :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6149 To: broulik, kde-frameworks-devel, dfaure Cc: dfaure, #frameworks

D6122: Add since tags.

2017-06-12 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent idea. I would say, we should have done the same in other new frameworks. If we treat KF5 as a whole, then these classes are simply "new since 5.28" in a bigger "package" that

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

2017-06-12 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6102 To: arrowdodger, #frameworks, dfaure Cc: apol, elvisangelaccio, kfunk