D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY QQuickWindow::sendEvent in Qt 5.7 and older had the following code to deliver QEvent::UngrabMouse by calling

Re: KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 23 - Failure!

On Sat, Jun 17, 2017 at 6:44 AM, Stephen Kelly wrote: > > Hi Ben, > Hi Stephen, > > Thanks for looking into this! > > From reading your email, it seems that the correct path is in > GPB_PYTHON3_INCLUDE_DIR, but that is not being added as an include > directory to compile

D6233: KKeyServer: fix handling of KeypadModifier.

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kkeyserver.cpp:160-180 > +{ Qt::Key_Space, XK_KP_Space }, > +{ Qt::Key_Tab,XK_KP_Tab }, > +{ Qt::Key_Enter, XK_KP_Enter },

Re: KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 23 - Failure!

Hi Ben, Thanks for looking into this! >From reading your email, it seems that the correct path is in GPB_PYTHON3_INCLUDE_DIR, but that is not being added as an include directory to compile the code. >From reading the ECM code (FindPythonModuleGeneration.cmake) I don't see how that could be.

D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys

graesslin added a comment. I need to point out that this creates a functional difference to Wayland and according to the latest rules of Plasma such changes are no longer allowed unless the implementation is done first for Wayland. Personally I am not really comfortable with such a

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 25 - Still unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/25/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Fri, 16 Jun 2017 18:24:38 + Build duration: 4 min 2 sec and counting

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#116837, @mart wrote: > with patch applied on plasma-framework and notifications applet from master all seems to still work ok. > > so, if i understand correctly, to try with notifiaction applet with your

D6215: Make sure size is final after showEvent

mart added a comment. with patch applied on plasma-framework and notifications applet from master all seems to still work ok. so, if i understand correctly, to try with notifiaction applet with your https://phabricator.kde.org/D6237 on top, and this patch that keeps updating the

D6215: Make sure size is final after showEvent

davidedmundson added a comment. Relavent follow up to the unanswer question from yesterday: why does the implicit height change when we show it It's from some code in NotificationItem.qml ColumnLayout { id: mainLayout anchors { left:

D6215: Make sure size is final after showEvent

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Ok so in summary there's two changes here: - updating our window geometry regardless of whether we're visible or not Makes total sense, there's no

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/24/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Fri, 16 Jun 2017 11:33:58 + Build duration: 3 min 38 sec and counting

D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys

dfaure created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This commit requires KF 5.36. BUG: 183458 TEST PLAN the following global shortcuts were successfully tested: Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift) REPOSITORY

D6226: KKeySequenceWidget: make it possible to record Ctrl+Num+1 as a shortcut.

dfaure closed this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D6226 To: dfaure, aacid Cc: apol, #frameworks

D6233: KKeyServer: fix handling of KeypadModifier.

dfaure created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This required adding a new method symXModXToKeyQt since symXToKeyQt (without modifier as input) has no way to find out whether to use

D6116: Add new stateChanged() signal to active connection

jgrulich added a comment. In https://phabricator.kde.org/D6116#116560, @davidedmundson wrote: > > can you find a new signal name and emit both for compatibility? What would you suggest? I can think of stateChangedWithReason() or stateChangedWithKnownReason() or