mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> broulik wrote in containmentinterface.cpp:1073
> Not sure if we should use `this` (and then check `if m_containment` as
> context or `m_containment`
should be the same
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When showing the time (1 hour 59.5 minutes) with seconds hidden we
want to show "2 hours 0 minutes" not "1 hour 60 minutes".
dfaure marked 4 inline comments as done.
dfaure added a comment.
What if you write me down as maintainer of this code, can this then go in?
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D6233
To: dfaure, graesslin
Cc: graesslin, #frameworks
dfaure added a comment.
In https://phabricator.kde.org/D6466#121152, @apol wrote:
> This will be problematic as soon as your application depends on any
libraries.
You mean, libraries which themselves have installed QML files, right?
Depending on e.g. ki18n is no problem.
kfunk edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6535
To: kfunk
Cc: kwrite-devel, #frameworks
kfunk updated this revision to Diff 16265.
kfunk added a comment.
Polish commit message
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6535?vs=16264=16265
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6535
AFFECTED FILES
kfunk created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Before:
Set Default Mark Type:
[ ] Bookmark
[X] Breakpoint
After:
Set Default Mark Type:
( )
graesslin added a comment.
Erm why was this pushed although it was in state changes requested?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot,
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
No need to signal separate times. This gives the client the possibility to
know
whether it should request for more entries or not. Otherwise it might request
them
when they will be fetched
mart abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
dbusrunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma, broulik
Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
davidedmundson updated this revision to Diff 16245.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
Kai's comments
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6390?vs=16231=16245
BRANCH
dbusrunner
REVISION DETAIL
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 06 Jul 2017 15:54:06 +
Build duration:
50 sec and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/7/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 06 Jul 2017 15:54:06 +
Build duration:
28 sec and counting
JUnit Tests
broulik added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:1073
> +
> +connect(desktopMenu, ::aboutToHide, m_containment, [this,
> oldStatus] {
> +m_containment->setStatus(oldStatus);
Not sure if we should use `this` (and then check `if m_containment` as context
or
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6523?vs=16229=16242
REVISION DETAIL
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
please add a test case for the problem.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/20/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Thu, 06 Jul 2017 14:30:32 +
Build duration:
10 min and counting
JUnit Tests
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This ensures the panel does not auto-hide then.
It also forces a re-evaluation of auto-hide status when the menu
davidedmundson marked 9 inline comments as done.
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in dbusrunnertest.cpp:88
> Why are you using `QString` and not `QStringLiteral` all over the place?
because it's in a test...
> broulik wrote in dbusrunner.cpp:109
> We cannot
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
mart added a comment.
In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote:
> Same question as before, what happens when we go from a theme with shadows
to a theme without?
I tried to switch back and forth several times between breeze and
keramiek(the theme linked
broulik added a comment.
Cool stuff!
A bunch of nitpicks but then it's good to go.
INLINE COMMENTS
> dbusrunnertest.cpp:45
> +void testMatch();
> +//
> +private:
Remove
> dbusrunnertest.cpp:52
> +{
> +m_process = new QProcess(this);
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit R311:f5ce89309e29: Use CMAKE_INSTALL_BINDIR for dbus service
generation (authored by bkchr, committed by apol).
REPOSITORY
R311 KWallet
CHANGES SINCE LAST UPDATE
bkchr added a comment.
Use g...@kchr.de
Thank you :)
REPOSITORY
R311 KWallet
REVISION DETAIL
https://phabricator.kde.org/D6519
To: bkchr, apol
Cc: #frameworks
apol added a comment.
In https://phabricator.kde.org/D6519#122060, @bkchr wrote:
> @apol do you will push this change for me? Or will this happen
automatically? ^^
I can do that, can you tell me what e-mail to use?
REPOSITORY
R311 KWallet
REVISION DETAIL
davidedmundson added a comment.
Same question as before, what happens when we go from a theme with shadows to
a theme without?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.
Closed by commit R249:77eab970fde3: Make sure that the tsfiles target is
generated (authored by apol).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
davidedmundson retitled this revision from "WIP: Add remote runners over DBus"
to "Add remote runners over DBus".
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
davidedmundson updated this revision to Diff 16231.
davidedmundson added a comment.
Added unit test, support actions
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6390?vs=15870=16231
BRANCH
dbusrunner
REVISION DETAIL
bkchr added a comment.
@apol do you will push this change for me? Or will this happen automatically?
^^
REPOSITORY
R311 KWallet
REVISION DETAIL
https://phabricator.kde.org/D6519
To: bkchr, apol
Cc: #frameworks
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R311 KWallet
REVISION DETAIL
https://phabricator.kde.org/D6519
To: bkchr, apol
Cc: #frameworks
mart added a comment.
replaced by https://phabricator.kde.org/D6523
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed,
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if a plasma theme doesn't provide shadow graphics,
the buffer will be a nullptr as would be created
from an
davidedmundson added a comment.
Buffer::Ptr ShmPool::createBuffer(const QImage& image)
{
if (image.isNull() || !d->valid) {
return QWeakPointer();
}
...
if our image is null (which it is), we get an an invalid Buffer::Ptr
Shadow::attach expects that to be
mart added a comment.
In https://phabricator.kde.org/D6518#121981, @davidedmundson wrote:
> What if a theme only has shadow-top, but not right etc.
> (or a more likely scenario, they exist, but the metadata has them be 0px
big)
>
> What would happen if you have a theme with shadow
36 matches
Mail list logo
