davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
You've not addressed my setVisible comment.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6608
To: broulik,
croick added a comment.
In https://phabricator.kde.org/D6541#123758, @dhaumann wrote:
> The patch looks good, but is there a concrete use-case?
I tried to implement a custom context menu for breakpoints and bookmarks in
https://phabricator.kde.org/tag/kdevelop/, mainly for
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c00069c43db4: Use new connect syntax in more places
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6614?vs=16471=16472
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6614
To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Especially in frequently created items. Shoves off a couple of milliseconds
of startup time.
TEST PLAN
- Changing
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/27/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Mon, 10 Jul 2017 20:11:07 +
Build duration:
3 min 39 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/27/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 10 Jul 2017 20:11:07 +
Build duration:
2 min 47 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/26/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 10 Jul 2017 20:03:01 +
Build duration:
3 min 9 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/26/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Mon, 10 Jul 2017 20:03:01 +
Build duration:
1 min 45 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/10/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 10 Jul 2017 18:46:08 +
Build duration:
32 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/11/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 10 Jul 2017 18:46:08 +
Build duration:
1 min 6 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:0b44a25b5df4: Give a parent to KMoreToolsMenuFactory
menus (authored by elvisangelaccio).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6008?vs=15197=16464#toc
REPOSITORY
R304 KNewStuff
dhaumann added a comment.
The patch looks good, but is there a concrete use-case?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6541
To: croick, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks
ochurlaud added a comment.
In https://phabricator.kde.org/D6604#123635, @sitter wrote:
> related to https://phabricator.kde.org/D6603
>
> @ochurlaud I hope this will not break api.kde, given ECM hasn't had a
metainfo.yaml previously it seems to have some sort of special arrangement?
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D6606
To: wbauer, dfaure
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/10/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 10 Jul 2017 13:48:30 +
Build duration:
58 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/9/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 10 Jul 2017 13:48:30 +
Build duration:
30 sec and counting
JUnit Tests
broulik updated this revision to Diff 16452.
broulik edited the summary of this revision.
broulik added a comment.
- For simplicitly just always delete the current action if it's ours before
proceeding. Then either use the one passed in or create a new one. As a (neat)
side-effect,
anthonyfieroni added inline comments.
INLINE COMMENTS
> qmenuitem.cpp:47
> +m_hasExplicitAction = true;
> +delete m_action;
> +m_action = nullptr;
Why delete it?
if (!a) {
setVisible(false);
return;
}
// m_action stays last one,
davidedmundson added inline comments.
INLINE COMMENTS
> qmenuitem.cpp:29
> setAction(new QAction(this));
> +m_hasExplicitAction = false;
> }
Another approach I've seen done before is:
if (action->parent() == this) we delete it, else it's the client's problem.
IMHO cleaner, but up to
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
You can assign a `QAction` as "action", this way you can just pass it e.g.
`plasmoid.action("configure")`.
However,
wbauer edited the summary of this revision.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D6606
To: wbauer, dfaure
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/8/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 10 Jul 2017 12:21:58 +
Build duration:
32 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 10 Jul 2017 12:21:58 +
Build duration:
1 min 10 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a19701c2529d: [Plasma Dialog] Fix flag conditions
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6554?vs=16444=16445
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6554
To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
broulik updated this revision to Diff 16444.
broulik added a comment.
- Fix all tooltip flag checks in dialog
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6554?vs=16309=16444
REVISION DETAIL
https://phabricator.kde.org/D6554
sitter added a comment.
related to https://phabricator.kde.org/D6603
@ochurlaud I hope this will not break api.kde, given ECM hasn't had a
metainfo.yaml previously it seems to have some sort of special arrangement?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
sitter created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6604
AFFECTED FILES
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/15/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Mon, 10 Jul 2017 09:34:35 +
Build duration:
2 min 59 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/19/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 10 Jul 2017 09:28:45 +
Build duration:
38 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:48f1ece4a4ce: do not stderr that NoDisplay is set
(authored by sitter).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6558?vs=16313=16439
REVISION DETAIL
32 matches
Mail list logo
