KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 37 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/37/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 23:17:33 + Build duration: 8 min 18 sec and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 36 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/36/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 22:54:44 + Build duration: 22 min and counting JUnit Tests

D6906: Create a "." entry even on empty dirs

2017-07-25 Thread Albert Vaca Cintora
albertvaka added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks, elvisangelaccio

D6906: Create a "." entry even on empty dirs

2017-07-25 Thread Albert Vaca Cintora
albertvaka edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 To: albertvaka, #frameworks

D6906: Create a "." entry even on empty dirs

2017-07-25 Thread Albert Vaca Cintora
albertvaka created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Fixes bug 382046 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6906 AFFECTED FILES src/core/slavebase.cpp To: albertvaka, #frameworks

D6803: Add template for a ktexteditor plugin

2017-07-25 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c3db3b8d4978: Add template for a ktexteditor plugin (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6803?vs=16949=17193#toc REPOSITORY R39 KTextEditor CHANGES SINCE

D6840: Add KF6 TODO for missing argument namespace in slot signature

2017-07-25 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R39:b319de339d81: Add KF6 TODO for missing argument namespace in slot signature (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 39 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 25 Jul 2017 22:50:09 + Build duration: 3 min 45 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 34 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/34/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 22:50:09 + Build duration: 1 min 43 sec and counting JUnit

D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

2017-07-25 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:a675fe908bed: Remove unused init() declaration from… (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6782?vs=16910=17190 REVISION

D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf added a comment. DefaultDeltasPerStep is always exactly 120 :D REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin
mart updated this revision to Diff 17176. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. readstringlist REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17175=17176 BRANCH

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin
mart added a comment. ah, yeah, that's a leftover, should go REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin
mart updated this revision to Diff 17177. mart added a comment. less blanks REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17176=17177 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin
mart marked 2 inline comments as done. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Kai Uwe Broulik
broulik added a comment. Also, your property is `X-KDE-PluginInfo-OnlySupportedPlatform` but you check for `X-KDE-OnlyShowOnQtPlatforms` REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kded.cpp:328 > +{ > +const QStringList supportedPlatforms = > module.rawData().value(QStringLiteral("X-KDE-OnlyShowOnQtPlatforms")).toVariant().toString().split(QStringLiteral(";"), > QString::SkipEmptyParts); > +

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin
mart added reviewers: Frameworks, Plasma. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin
mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY some kded modules can only run in one platform, especially only xcb or only wayland. this makes kded support the

D6679: Treat Button/ToolButton labels as plaintext

2017-07-25 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. fvogt marked an inline comment as done. Closed by commit R242:48a8245db4d8: Treat Button/ToolButton labels as plaintext (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6679: Treat Button/ToolButton labels as plaintext

2017-07-25 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6679 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot,

D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

2017-07-25 Thread Kevin Funk
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH removeUnusedFactoryInitDeclaration REVISION DETAIL https://phabricator.kde.org/D6782 To: kossebau, #frameworks, kfunk

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 35 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/35/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 12:59:14 + Build duration: 12 min and counting JUnit Tests

D6803: Add template for a ktexteditor plugin

2017-07-25 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Guess makes sense to have that bundled. Thanks for the work! REPOSITORY R39 KTextEditor BRANCH addplugintemplate REVISION DETAIL https://phabricator.kde.org/D6803 To:

D6800: Add template for a simple kpart-based application

2017-07-25 Thread Friedrich W . H . Kossebau
kossebau added a comment. So with the Messages.sh sorted out (thanks @aacid for raising and @lueck for pointing out where it is already handled), if there are no objections, would add on Tuesday, 27th. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6800 To:

D6803: Add template for a ktexteditor plugin

2017-07-25 Thread Friedrich W . H . Kossebau
kossebau added a comment. So if there are no objections, would add on Tuesday, 27th. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6803 To: kossebau, #frameworks, #ktexteditor Cc: kwrite-devel

D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable to me. I assume the DefaultDeltasPerStep is always > 0 ;=) REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks

D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf updated this revision to Diff 17169. carewolf added a comment. Fix smoothness of zooming down CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6895?vs=17167=17169 REVISION DETAIL https://phabricator.kde.org/D6895 AFFECTED FILES src/render/katerenderer.cpp

D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf added a reviewer: cullmann. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6895 To: carewolf, cullmann Cc: #frameworks

D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Avoid zooming in or out too fast when wheel events are finer grained. REPOSITORY R252 Framework Integration REVISION DETAIL

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread Kai Uwe Broulik
broulik added a comment. Yes REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6894 To: broulik, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread David Edmundson
davidedmundson added a comment. > Right clicked an applet so if (applet) would have been true? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6894 To: broulik, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The applet context menu contains containment actions which might be outdated if we don't call this. TEST PLAN Right

D5788: Add syntax highlighting for YANG data modeling language

2017-07-25 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fa65afb0f7c5: Add syntax highlighting for YANG data modeling language (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5788?vs=14342=17162#toc REPOSITORY R216 Syntax

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 25 Jul 2017 07:47:58 + Build duration: 4 min 29 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 33 - Still Unstable!

2017-07-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/33/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 25 Jul 2017 07:47:58 + Build duration: 2 min 55 sec and counting JUnit