mlaurent marked 3 inline comments as done.
mlaurent added inline comments.
INLINE COMMENTS
> cfeck wrote in knewpasswordwidget.cpp:118
> Can you double-check this change? To me, the echoMode() checks are now
> reversed compared to the original code.
>
> I have not tested the code yet :)
Nope
mlaurent updated this revision to Diff 17606.
mlaurent marked an inline comment as done.
mlaurent added a comment.
Fix include order, remove textChanged, add argument to signal etc.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17541=17606
REVISION DETAIL
aacid added a comment.
Did you actually try any suspendable job to make sure it still works in that
case? (i assume kdeconnect jobs are not suspendable?)
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D7058
To: apol, #frameworks
Cc: aacid
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/34/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Wed, 02 Aug 2017 18:43:28 +
Build duration:
6 min 7 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/43/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 02 Aug 2017 18:44:04 +
Build duration:
2 min 27 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/42/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 02 Aug 2017 18:41:19 +
Build duration:
2 min 42 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/33/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Wed, 02 Aug 2017 18:41:19 +
Build duration:
2 min 7 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:165465ee7116: Add --gradle to androiddeployqt (authored
by aacid).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6875?vs=17111=17598
REVISION DETAIL
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
BRANCH
sonnet-no-widget
REVISION DETAIL
https://phabricator.kde.org/D6990
To: vkrause, #frameworks, cordlandwehr, aacid
Cc: aacid
aacid accepted this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D6994
To: vkrause, #frameworks, apol, aacid
Cc: aacid
mlaurent marked an inline comment as done.
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, elvisangelaccio
Cc: cfeck, elvisangelaccio, #frameworks
mlaurent updated this revision to Diff 17592.
mlaurent added a comment.
Remove empty line
Move in good place.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7062?vs=17574=17592
REVISION DETAIL
https://phabricator.kde.org/D7062
AFFECTED FILES
src/kde.widgets
To: mlaurent,
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This crash got triggered in KWin when sending the selection to XWayland.
While the test handles condition of not yet
vkrause updated this revision to Diff 17588.
vkrause added a comment.
Add explicit build option to disable QtGui dependency.
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6994?vs=17392=17588
BRANCH
master
REVISION DETAIL
cfeck added a comment.
And that file looks at least a bit sorted by class name...
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, elvisangelaccio
Cc: cfeck, elvisangelaccio, #frameworks
cfeck added inline comments.
INLINE COMMENTS
> kde.widgets:327
> Group=Sonnet (KDE)
> +
> +
Remove duplicate empty line
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, elvisangelaccio
Cc: cfeck, elvisangelaccio, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/27/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Wed, 02 Aug 2017 15:56:03 +
Build duration:
4 min 40 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/25/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 02 Aug 2017 15:56:03 +
Build duration:
51 sec and counting
JUnit Tests
mlaurent marked 2 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D7062
To: mlaurent, dfaure, kossebau, elvisangelaccio
Cc: elvisangelaccio, #frameworks
mlaurent updated this revision to Diff 17574.
mlaurent added a comment.
Fix typo + Group as requested.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7062?vs=17542=17574
REVISION DETAIL
https://phabricator.kde.org/D7062
AFFECTED FILES
src/kde.widgets
To: mlaurent, dfaure,
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kde.widgets:332
> +ToolTip=A Password LineEdit (KDE)
> +WhatsThis=An Custom LineEdit which allows to show password
> +Group=Display (KDE)
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
INLINE COMMENTS
> kpackagetool.cpp:473
> +// Standard value is unprocessed string we'll need to deal
> with.
> +object.value("NoDisplay").toString() ==
>
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
This might well hide the issue, but it can't be "correct".
It's definitely calling updateTheme twice, which is very expensive.
and I'm pretty sure it's
broulik retitled this revision from "added back lines to void
Dialog::componentComplete() to fix an issue where the notifications will show
as 1 pixel line if the primary screen wasn't the most left one." to "Fix issue
where notifications will show as 1 pixel line if primary screen wasn't the
broulik edited the summary of this revision.
broulik added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7071
To: matank, #plasma
Cc: ltoscano, #frameworks
ltoscano added a comment.
I can't comment too much on the content, but please:
- shorten the title (it will be the first line of the git commit message)
- I'm not totally sure if BUG works without : (so BUG: xx)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
matank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
https://phabricator.kde.org/R242:eab4aa9909a62cce9b32555ed28d142569fb467f
introduces a bug where
notifications will show up as 1 pixel
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Previously kpackagetool used STDOUT as output for the appstream xml data
it generated. This has various problems:
- cannot print
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e0b719f1e71: [Containment Interface] always emit
contextualActionsAboutToShow for containment (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R306:1608c70efed4: Reset url in closeUrl() (authored by
elvisangelaccio).
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6856?vs=17278=17545
REVISION DETAIL
elvisangelaccio added a comment.
In https://phabricator.kde.org/D6774#131083, @cfeck wrote:
> Interesting. When I RMB-click on a folder in Dolphin, I indeed see "Delete
File" in the context menu, but I do not see "Rename File", but "Rename ..."
instead. Does Dolphin not use standard
mlaurent added a comment.
https://phabricator.kde.org/D7062 (designer plugin)
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We need a plugin for showing it in designer
TEST PLAN
launch designer with knewpasswordwidget from kwidgetaddons
REPOSITORY
R298
mlaurent updated this revision to Diff 17541.
mlaurent added a comment.
I created a designer plugin for it, I will put url here after create review
I add property for echo mode
Now we can see lineedit in designer (created from a plugin)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7e03e503b00c: Fix assert in UrlUtil::firstChildUrl()
(authored by dvratil).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7043?vs=17511=17540
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Patch looks good. The word "normalize" in the commit log is somewhat
confusing, this is only about stripping trailing slashes, not about
QUrl::NormalizePathSegments (which is another
dfaure added a comment.
But if you use QLineEdit as a base class, the developer can set properties
for a QLineEdit, which might not apply to KPasswordLineEdit.
Better add the widget to the kdesigner plugin framework, then you'll have
proper integration with Qt Designer.
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/16/
Project:
Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 02 Aug 2017 07:04:16 +
Build duration:
2 min 42 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/43/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 02 Aug 2017 06:23:15 +
Build duration:
28 min and counting
JUnit Tests
mlaurent updated this revision to Diff 17535.
mlaurent added a comment.
Use a correct license (I copied a header from david class so I think it's ok
now) as in kwidgetaddons there is lgpl2 lgpl2.1 lgpl3 lgpl...
I didn't change ui file a QWidget otherwise we can't see qlineedit in
40 matches
Mail list logo
