dfaure added a comment.
In https://phabricator.kde.org/D7270#136443, @chinmoyr wrote:
> > Is this subclass needed? You could just move the code of its constructor
to the UndoJob constructor, no? (using Q_D of course)
>
> I tried this before anything else and it didn't worked. Q_D requ
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> filehelper.cpp:34
> +FdSender fdSender;
> +fdSender.connectToPath("org_kde_kio_file_helper_socket");
> +if (fdSender.isConnected()) {
BTW what hap
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> slavebase.cpp:1461
> +
> +PrivilegeOperationStatus SlaveBase::privilegeOperationStatus()
> +{
Oh, indeed, can't be const, because it's not a getter, it's a me
chinmoyr added a comment.
> Is this subclass needed? You could just move the code of its constructor to
the UndoJob constructor, no? (using Q_D of course)
I tried this before anything else and it didn't worked. Q_D requires a
private class, right?
> It seems to me that we only want
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Nevertheless I still think we should also ship my review. Rather a null check
too many than too few.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator
chinmoyr updated this revision to Diff 18242.
chinmoyr added a comment.
- Added variable (mUserCanceled) to denote if user canceled operation
- Return PrivilegeOperationStatusin SlaveBase's method. Went with switch
instead static_cast. Cannot make it const.
- Cancelled -> Canceled
CHANGES
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/47/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Wed, 16 Aug 2017 14:14:11 +
Build duration:
5 min 7 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/42/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 16 Aug 2017 14:14:11 +
Build duration:
2 min 45 sec and counting
JUnit Tes
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:3dfa71021300: Add support for uninstalled plugins in
kcoreaddons_add_plugin (authored by elvisangelaccio).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7347?v
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Oh wow, even more magic, to make it even easier. Cool !
Please make sure to document the solution in the wiki - and feel free to port
KIO to it ;-)
REPOSITORY
R244 KCoreAddons
BRANC
elvisangelaccio retitled this revision from "Add support for uninstalled plugin
in kcoreaddons_add_plugin" to "Add support for uninstalled plugins in
kcoreaddons_add_plugin".
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7347
To: elvisangelaccio, #build_system, d
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
If find_package(ECM 5.38) or higher was called, output the plugin in a
INSTALL_NAMESPACE subfolder of the "bin" folder.
This w
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130228/
---
Review request for KDE Frameworks.
Repository: kdelibs4support
Descript
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in filehelper.cpp:46
> Well, this proves exactly my earlier point: we should only test errno *when*
> a libc function fails.
>
> If this code is still checking errno after success somewhere, then *that* it
> what should be fixed. A
chinmoyr updated this revision to Diff 18235.
chinmoyr added a comment.
- Remove errno assignment
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=18201&id=18235
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
src/ioslaves/file/CMakeLists
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/43/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 16 Aug 2017 11:32:31 +
Build duration:
58 min and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/20/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Wed, 16 Aug 2017 09:45:08 +
Build duration:
55 min and counting
JUnit Tests
Name: (root
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/46/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Wed, 16 Aug 2017 09:45:19 +
Build duration:
52 min and counting
JUnit Tests
cullmann added a comment.
Think that would be nice.
Then we always have only that tuple of functions, makes it less confusing
(and less to maintain).
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7337
To: dhaumann, carewolf, cullmann
Cc: kwrite-devel, #framew
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsQt5.7/19/
Project:
Frameworks kglobalaccel kf5-qt5 WindowsQt5.7
Date of build:
Wed, 16 Aug 2017 09:45:27 +
Build duration:
12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsQt5.7/47/
Project:
Frameworks kcoreaddons kf5-qt5 WindowsQt5.7
Date of build:
Wed, 16 Aug 2017 09:45:20 +
Build duration:
8 min 16 sec and counting
JUnit Tes
mart added a comment.
+1
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7316
To: davidedmundson, #plasma
Cc: mart, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
dhaumann added a comment.
Yes, Allen is correct: Essentially, we could remove all helper functions that
use KTE::Range/Cursor. Shall I update the patch?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7337
To: dhaumann, carewolf, cullmann
Cc: kwrite-devel, #frame
carewolf added a comment.
A few of the cursor/range functions are used, but not all of them. You could
probably rewrite the places using them to use line+col instead.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7337
To: dhaumann, carewolf, cullmann
Cc: kwrite
Hi,
As you know I've been building my own KF5 (and Qt5) packages for installation
into /opt/local on an up-to-date Ubuntu 14.04LTS system. I register the
required directories under /opt/local with DBus so (almost) everything works as
you'd expect.
On notable difference I just discovered: KF5So
cullmann added a comment.
Question: Do we need the overloads with the KTextEditor::Cursor at all or
should we limit that to line/column + QJSValue?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7337
To: dhaumann, carewolf, cullmann
Cc: kwrite-devel, #frameworks
26 matches
Mail list logo