dhaumann added inline comments.
INLINE COMMENTS
> vkrause wrote in qdocconf.xml:94
> Yes, due to the LineContinue rule. The test case fails in two places without
> that, line 47 and 57, the empty line preceding those doesn't pop due to the
> line continuation the line before.
Ah. Nice. So
vkrause added inline comments.
INLINE COMMENTS
> dhaumann wrote in qdocconf.xml:14
> Is the capital c intentional?
yep, both according to the qdoc docs and real files
> dhaumann wrote in qdocconf.xml:94
> Given lineEndContext is pop, do we need the lineEmptyContext?
Yes, due to the
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
INLINE COMMENTS
> qdocconf.xml:14
> +buildversion
> +Cpp
> +customFilters
Is the capital c intentional?
> qdocconf.xml:94
> +
>
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7645
AFFECTED FILES
valeriymalov added a comment.
In https://phabricator.kde.org/D7487#141996, @davidedmundson wrote:
> For some reason "kcmshell5 kscreen" looks awful. It comes up tiny.
This seems to be caused by the way KScreen's KCM is initialized, probably
because of QML? Window content seems to
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Tests still pass
Changed a file in /usr/share/applications, it would still notice that
REPOSITORY
R309 KService
REVISION DETAIL
On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote:
> any objection into pulling it into a framework? anything particular for the
> procedure?
as an update to that, i've update its cmake files and metadata files
to be coherent with other frameworks, at this point i'll wait a
sitter added a reviewer: dfaure.
sitter added a subscriber: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7430
To: chinmoyr, dfaure
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:555409eb206b: Save up a bunch of stat() calls on
application start (authored by apol).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7230?vs=17964=19046
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/22/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Fri, 01 Sep 2017 12:17:01 +
Build duration:
2 min 10 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:9597930a4596: refactor kpackagetool away from stringy
options (authored by sitter).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7216?vs=17926=19045
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/27/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 01 Sep 2017 12:17:00 +
Build duration:
54 sec and counting
JUnit Tests
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Won't hurt, benefits from some compiler checking so it's better.
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7216
To: sitter, sebas, apol
Cc:
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
For some reason "kcmshell5 kscreen" looks awful. It comes up tiny.
Most the rest seem OK (I checked ~15) . There must be something very specific
about that one. If you
14 matches
Mail list logo