BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/67/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Sep 2017 02:25:19 +
Build duration:
13 min and counting
JUnit Tests
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7491
To: xuetianweng, mart, #plasma, davidedmundson
Cc: #frameworks
xuetianweng added reviewers: Plasma, davidedmundson.
xuetianweng added a comment.
ping
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7491
To: xuetianweng, mart, #plasma, davidedmundson
Cc: #frameworks
ngraham edited the test plan for this revision.
ngraham added a reviewer: aacid.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7668
To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik,
elvisangelaccio, aacid
Cc: elvisangelaccio, cfeck,
chinmoyr updated this revision to Diff 19183.
chinmoyr added a comment.
I cannot think of any good reason as to why anyone would want to disable
undo. So, removing the checks.
As of now copying from a locked folder is not supported. So your example file
operation is not possible.
CHANGES
davidedmundson added a comment.
We have a slight problem (and I'm sorry as this is my fault)
Plasma 5.10 will depend on frameworks 5.38.
This was just tagged and doesn't include your krun change.
If this was a feature I would be really strict and make us wait till Plasma
5.11.
broulik added a comment.
Well it is now "openService" calling "runApplication", that's inconsistent
isn't it
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:a6d341f817c8: Added openService() method to KRunProxy
(authored by maxrd2, committed by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
chinmoyr updated this revision to Diff 19178.
chinmoyr added a comment.
- Made method const
- Removed unnecessary new line
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6833?vs=18019=19178
REVISION DETAIL
https://phabricator.kde.org/D6833
AFFECTED FILES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
runproxy_openservice
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/39/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Mon, 04 Sep 2017 16:21:38 +
Build duration:
10 min and counting
JUnit Tests
Name:
maxrd2 updated this revision to Diff 19173.
maxrd2 marked an inline comment as done.
maxrd2 added a comment.
Removed service->isApplication() check, improved method description.
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676?vs=19138=19173
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/38/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Mon, 04 Sep 2017 15:56:58 +
Build duration:
12 min and counting
JUnit Tests
chinmoyr updated this revision to Diff 19170.
chinmoyr added a comment.
- ret -> err
- used tryOpen
@dfaure shall i merge https://phabricator.kde.org/D6830 &
https://phabricator.kde.org/D6831 into a single commit?
CHANGES SINCE LAST UPDATE
chinmoyr updated this revision to Diff 19167.
chinmoyr added a comment.
removedextra semi-colon
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6830?vs=19166=19167
REVISION DETAIL
https://phabricator.kde.org/D6830
AFFECTED FILES
src/ioslaves/file/file.h
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/76/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 04 Sep 2017 11:26:05 +
Build duration:
1 min 22 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/72/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 04 Sep 2017 11:26:13 +
Build duration:
51 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R239:0f7d924b9979: doc: validation not available in
QInputDialog::getText (authored by ltoscano).
REPOSITORY
R239 KDELibs4Support
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:04cc49c71bdb: Detach before setting the d pointer
(authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7194?vs=17863=19155
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:c381ed0a1758: Don't complain the knsregistry file is not
present before it's useful (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xdgshell_interface.cpp:40
> the captured "attempt" variable is modified inside the lambda
needs to tack the state as needs to track that only a couple of attempts are
made
REPOSITORY
R127 KWayland
REVISION DETAIL
rjvbb added a comment.
Not by me in any case, but I didn't exactly "invent" the fix, it must have
been around for long enough to be upstreamed. Is cdparanoia even being
maintained?
REPOSITORY
R342 KIO AudioCD
REVISION DETAIL
https://phabricator.kde.org/D7448
To: rjvbb, #frameworks,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R239 KDELibs4Support
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7675
To: ltoscano, cfeck, dfaure
Cc: #frameworks
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Has this been reported upstream, so the cdda people can fix it properly?
REPOSITORY
R342 KIO AudioCD
REVISION DETAIL
https://phabricator.kde.org/D7448
To: rjvbb, #frameworks, dfaure
On dimanche 3 septembre 2017 14:28:44 CEST no-re...@kde.org wrote:
> BUILD UNSTABLE
> Build
> URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7
> /75/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7
XenialQt5.7/autotests/tst_keynavigation.qml:23:1: module
dfaure added a comment.
Oops, yes, you're completely right. I got distracted by the word close, but
it's a different meaning in closeStream and closeUrl. Apologies for the
confusion.
As to existing implementations of this stuff, it just happens that I wrote
one recently, see
26 matches
Mail list logo
