D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

2017-09-20 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I don't understand the original logic. s_allResources

D7879: [KConfigGroup] reserve() more and add some C++11

2017-09-20 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added inline comments. INLINE COMMENTS > mwolff wrote in kconfiggroup.cpp:187 > use `splitRef` instead, also below Was my first reflex do to so but `string` confusingly is a `QByteArray` REPOSITORY R237 KConfig REVISION DETAIL

D7891: expose the colorset for the stylesheet

2017-09-20 Thread Marco Martin
mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY this makes possible having icons loaded with different colors in different parts of the application, will be needed by kirigami (which will

D7891: expose the colorset for the stylesheet

2017-09-20 Thread Marco Martin
mart planned changes to this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart Cc: #frameworks

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 44 - Fixed!

2017-09-20 Thread no-reply
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/44/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Wed, 20 Sep 2017 16:18:19 + Build duration: 5 min 0 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 43 - Unstable!

2017-09-20 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/43/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Wed, 20 Sep 2017 15:37:11 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 44 - Still Unstable!

2017-09-20 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/44/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 20 Sep 2017 15:37:11 + Build duration: 9 min 21 sec and counting JUnit Tests

D7885: Don't crash if a client (legally) uses deleted global contrast manager

2017-09-20 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:403f60929f11: Dont crash if a client (legally) uses deleted global contrast manager (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7885: Don't crash if a client (legally) uses deleted global contrast manager

2017-09-20 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7885 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,

D7875: Remove the final endl at the end of qDebug

2017-09-20 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R313:dcc123af2496: Remove the final endl at the end of qDebug co (authored by ltoscano). REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7875?vs=19657=19694 REVISION

D7885: Don't crash if a client (legally) uses deleted global contrast manager

2017-09-20 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There is a race condition in the following situation: -

Re: Build failures in libraries on CI

2017-09-20 Thread Daniel Vrátil
On Wednesday, 20 September 2017 13:20:22 CEST Ben Cooksley wrote: > On Wed, Sep 20, 2017 at 11:15 PM, Daniel Vrátil wrote: > > On Wednesday, 20 September 2017 12:13:45 CEST Ben Cooksley wrote: > >> Hi all, > > > > > > > >> In the case of syndication, it is relying on Qt

Re: Build failures in libraries on CI

2017-09-20 Thread Ben Cooksley
On Wed, Sep 20, 2017 at 11:15 PM, Daniel Vrátil wrote: > On Wednesday, 20 September 2017 12:13:45 CEST Ben Cooksley wrote: >> Hi all, >> > >> >> In the case of syndication, it is relying on Qt features it is not >> supposed to use as they were introduced in a version later than

Re: Build failures in libraries on CI

2017-09-20 Thread Daniel Vrátil
On Wednesday, 20 September 2017 12:13:45 CEST Ben Cooksley wrote: > Hi all, > > > In the case of syndication, it is relying on Qt features it is not > supposed to use as they were introduced in a version later than it's > minimum requirements (and for which alternative API is available if > the

D7884: - Increase size of trailing mark

2017-09-20 Thread Kevin Funk
kfunk added a comment. In https://phabricator.kde.org/D7884#147087, @sars wrote: > I think "spaceWidth() / 2" goes a little bit too far. I agree. The 'before' screenshot looks better in my eyes. The trailing mark indicator is supposed to be a *subtle* hint, not something causing

D7884: - Increase size of trailing mark

2017-09-20 Thread Kåre Särs
sars added a comment. I think "spaceWidth() / 2" goes a little bit too far. Shouldn't spaceWidth() fix the HiDPI problem? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: sars, #frameworks, cullmann, dhaumann

Build failures in libraries on CI

2017-09-20 Thread Ben Cooksley
Hi all, For a period of time now, extra-cmake-modules and syndication have had failing builds on the CI on some platforms. To date, despite me bringing it to the relevant developers attention, no action has been taken to remedy the situation. In the case of extra-cmake-modules, it contains a

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio added a comment. Result of change using kdevelop F3918646: screenshot.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio updated this revision to Diff 19686. helio added a comment. - Using same code guideline as previous entry REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19685=19686 BRANCH big_trailing REVISION DETAIL

D7884: - Increase size of trailing mark

2017-09-20 Thread Kevin Funk
kfunk added a comment. Screenshots please, for changes like this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio added reviewers: mwolff, kfunk. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro
helio created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On HiDPI screens and/or usage of small fonts current size of marker is so small making it almost invisible, even with a saturated color