ngraham added a reviewer: aacid.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #frameworks, aacid
Cc: anthonyfieroni, spoorun, navarromorales, firef, ngraham, andrebarros,
emmanuelp
ngraham updated this revision to Diff 20768.
ngraham added a comment.
Update current version
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8303?vs=20767=20768
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8303
AFFECTED FILES
anthonyfieroni added a comment.
Baloo doesn't have active developers so you can add Aacid to accept it.
INLINE COMMENTS
> metadatafilter.cpp:44
> {
> const int currentVersion = 6; // increase version, if the blacklist of
> disabled
> // properties should be updated
Increase it
ngraham added a comment.
Any progress? This is too good a change to not merge. :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8056
To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: ngraham, alexeymin, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/120/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Sun, 15 Oct 2017 02:58:15 +
Build duration:
25 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/121/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 15 Oct 2017 02:58:15 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
ngraham edited the test plan for this revision.
ngraham added reviewers: Dolphin, KDE Applications, Frameworks.
ngraham added a project: Dolphin.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #frameworks
Cc:
ngraham added a comment.
Any remaining concerns?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik, #frameworks
ngraham edited the test plan for this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik, #frameworks
ngraham added a reviewer: Frameworks.
ngraham added a comment.
This seems okay to me, but I'm pretty new and I'd really like sign-off from
someone more experienced first.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/53/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Sat, 14 Oct 2017 16:07:37 +
Build duration:
12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/52/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 14 Oct 2017 16:07:37 +
Build duration:
6 min 27 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f48b796c74d5: Dont duplicate connect to
wl_display_flush (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8284?vs=20708=20744
ngraham added a comment.
Unless I'm holding it wrong, https://lxr.kde.org/ident?_i=Comma&_remember=1
doesn't appear show any other uses of Ctrl+, as a keyboard shortcut.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc:
graesslin added a comment.
In https://phabricator.kde.org/D8296#155363, @ngraham wrote:
> Sounds good. What's lxr?
lxr.kde.org
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik, #frameworks
ngraham added a comment.
Sounds good. What's lxr?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik, #frameworks
graesslin added a comment.
Agree with Kai - this needs good testing that it is not used anywhere. Best
by looking through lxr which apps use this framework.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: graesslin, broulik,
ngraham edited the test plan for this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: broulik, #frameworks
ngraham added a reviewer: VDG.
ngraham added a comment.
FWIW, I did some basic testing on that and couldn't find any conflicts among
Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent,
Skanlite.
REPOSITORY
R237 KConfig
REVISION DETAIL
broulik added a comment.
+1
However I fear this might cause "shortcut xyz is ambiguous" messages after
update for some users :/
Perhaps also consult VDG / usability
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks
Cc: broulik,
ngraham added a reviewer: Frameworks.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks
Cc: #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Use Ctrl+, as the standard keyboard shortcut to invoke KDE programs'
"Configure " menu items. Right now there is no shortcut defined for
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Ahhh. That's of course tricky to spot in this change ;-)
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson,
davidedmundson added a comment.
The other ctor has a connect in the body.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-mohamed,
graesslin added a comment.
I don't see in the change what you describe. This seems to be just a
refactoring.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8284
To: davidedmundson
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
On Thursday, 31 August 2017 17:06:46 CEST Marco Martin wrote:
> Hi all,
> we have a qtquickcontrols style that is right now in workspace (unrelased,
> to be released with Plasma 5.11)
> it makes controls paint with qstyle to give it a reasonable desktop
> appearance, plus some fixes/workarounds to
gregormi added a comment.
> @ltoscano, can we commit this?
Hi Nate, thanks for pushing this forward.
> I still disagree in the way this is done, as it means manually periodically
updating the information and it's definitely not the right thing to do.
Hi Luigi,
I agree with
On dimanche 8 octobre 2017 15:22:00 CEST Mark Gaiser wrote:
> But then i still miss one rather important detail that i can't really find
> anywhere..
> Lets say I have that module and call it "tags2" (as Baloo already has tags,
> therefore tags2 to prevent naming issues).
>
> So i make a dbus
28 matches
Mail list logo
