D8527: Display "Downloaded From" by default, if file supports it

vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. Looks good. Maybe we should wait and see if someone who works on Dolphin has an opinion. This widget is only used in Dolphin. REPOSITORY R824 Baloo Widgets BRANCH

D8528: Consider DjVu files to be documents

vhanda added a comment. Since I was added as a reviewer, I thought I'll comment. I am not currently maintaining Baloo or using it, so I don't want to really discuss the specifics. Though from a technical point of view this change will work. If nobody has any objections, I would say go

D8528: Consider DjVu files to be documents

ngraham added a reviewer: rkflx. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8528 To: ngraham, vhanda, #frameworks, rkflx Cc: rkflx, #frameworks

D8527: Display "Downloaded From" by default, if file supports it

ngraham edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8527 To: ngraham, #dolphin, #frameworks, broulik, dfaure, markg Cc: spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp

D8527: Display "Downloaded From" by default, if file supports it

ngraham added reviewers: broulik, dfaure, markg. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8527 To: ngraham, #dolphin, #frameworks, broulik, dfaure, markg Cc: spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

ngraham updated this revision to Diff 21507. ngraham added a comment. Changed to Ctrl+Alt+, because Alt-only shortcuts are weird REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=21142=21507 BRANCH master REVISION DETAIL

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

ngraham retitled this revision from "Use Alt+, as the standard shortcut for "Configure "" to "Use Ctrl+Alt+, as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/88/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 29 Oct 2017 02:35:48 + Build duration: 19 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/126/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Sun, 29 Oct 2017 02:34:49 + Build duration: 16 min and counting JUnit Tests Name: (root)

D8296: Use Alt+, as the standard shortcut for "Configure "

ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/134/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 29 Oct 2017 02:36:09 + Build duration: 13 min and counting

D8296: Use Alt+, as the standard shortcut for "Configure "

ngraham added a comment. Just checked: It's already there in Standard Shortcuts, where it can be changed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten,

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/130/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Sun, 29 Oct 2017 02:36:09 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/127/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 29 Oct 2017 02:34:49 + Build duration: 9 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/136/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 29 Oct 2017 02:35:04 + Build duration: 3 min 0 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/130/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 29 Oct 2017 02:35:04 + Build duration: 59 sec and counting JUnit Tests

D8351: API dox: add note about calling setApplicationDomain after QApp creation

kossebau added a comment. @ilic ping? Can you confirm this is correct and by design? Motivation is: `KLocalizedString::setApplicationDomain()` triggers the creation of the `KLocalizedStringPrivateStatics` instance,

D7828: createKMessageBox tries to focus a default button when available

rkflx accepted this revision. rkflx added a comment. In https://phabricator.kde.org/D7828#160998, @emateli wrote: > If this turns out to be okay, I'll edit the summary and title later Playing around with Dolphin's usage of `createKMessageBox`, I made the following observations:

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. I will also need help figuring out what config to use for storing the users last used hash algorithm from the combobox (if we go that route). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc:

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. A possible combobox layout F5454950: Screenshot_20171028_225633.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: bcooksley, alexeymin, ngraham,

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added a comment. In https://phabricator.kde.org/D8536#161276, @ngraham wrote: > My vote is for a single combobox with a reasonably common default choice like sha256, but that that remember the last-used choice if you change it. My sense is that most people who actually

D8536: Add more hashing algorithms to KPropertiesDialog

bcooksley added a comment. When uploading diffs, and creating the review for the first time one of the fields Phabricator will ask you about is the repository. I've now set this for the review. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak,

D8536: Add more hashing algorithms to KPropertiesDialog

bcooksley set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: alexeymin, ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. KIO repository REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: alexeymin, ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

alexeymin added a comment. Which repository it is...? For me it looks fine on the latest screenshots, combobox is less convenient. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: alexeymin, ngraham, elvisangelaccio, #frameworks

Re: Buddies/Tabstops in designer for aggregated KDE widgets?

On dimanche 24 septembre 2017 23:16:27 CEST Albert Astals Cid wrote: > El diumenge, 24 de setembre de 2017, a les 14:55:37 CEST, Milian Wolff va > > escriure: > > Hey all, > > > > I'm trying to get set a sane tabstop order for the record page of hotspot. > > BTW I could not fint any "hotspot"

D8536: Add more hashing algorithms to KPropertiesDialog

ngraham added a comment. My vote is for a single combobox with a reasonably common default choice like sha256, but that that remember the last-used choice if you change it. My sense is that most people who actually use this feature (= very very small group of people) already have a favorite

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. It is kinda questionable as far as what are the most common hash algorithms. I most often use SHA512 for example. I think having only the combobox would be ok for me, but I'm not a UX person. So just let me know if you figure out anything else. REVISION

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added a comment. In https://phabricator.kde.org/D8536#161255, @ngraham wrote: > The concept of an "advanced" hashing algorithm doesn't really make sense IMHO. This whole thing is an "advanced" feature. > > How about a combobox containing a list of all available

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. I'm going to give that a try. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

ngraham added a comment. The concept of an "advanced" hashing algorithm doesn't really make sense IMHO. This whole thing is an "advanced" feature. How about a combobox containing a list of all available hashing algorithms, with a single Calculate button? REVISION DETAIL

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak updated this revision to Diff 21495. petermajchrak added a comment. Place advanced algorithms into KCollapsibleGroupBox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8536?vs=21480=21495 REVISION DETAIL https://phabricator.kde.org/D8536 AFFECTED FILES

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. I am new to KDE development and I want to use the KCollapsibleGroupBox but I don't know how. Are there any plugins for Qt Designer for KWidgetsAddons? REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: ngraham,

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

ngraham added a comment. Please add the following on its own line in the Summary section: "BUG: 377430" That way it will automatically close the bug once this is in. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: ngraham, elvisangelaccio,

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. I agree that the layout is not optimal. I'm going to try to optimize it now. REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Thanks, now I can build it. Please add screenshots so that the https://phabricator.kde.org/tag/vdg/ team can have a look. I don't think we can show so much

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak updated this revision to Diff 21480. petermajchrak added a comment. Remove C++17 features CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8536?vs=21478=21480 REVISION DETAIL https://phabricator.kde.org/D8536 AFFECTED FILES src/widgets/checksumswidget.ui

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added inline comments. INLINE COMMENTS > elvisangelaccio wrote in CMakeLists.txt:6 > We can't use this in frameworks (and the patch doesn't build for me), see > https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 Ok. I was kinda hoping

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak Cc: elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

elvisangelaccio added inline comments. INLINE COMMENTS > CMakeLists.txt:6 > > +set(CMAKE_CXX_STANDARD 17) > + We can't use this in frameworks (and the patch doesn't build for me), see https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 REPOSITORY

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak Cc: #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I added most of the hashing algorithms to the dialog. I still need to figure out a better way to lay out the GUI but the code should

D7828: createKMessageBox tries to focus a default button when available

elvisangelaccio added a comment. Does this mean that apps should always pass a parent? (if that's the case, we should mention it in the KMessageBox documentation) REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: elvisangelaccio, rkflx,

D8532: [WIP] Restrict file extractor with Seccomp

davidk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use Seccomp for implementing a sandbox for baloo_file_extractor This change introduces a new optional dependency on libseccomp.