ngraham closed this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: cfeck, rdieter, graesslin, z3ntu
ngraham added a comment.
Makes sense!
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik,
#frameworks
ngraham added a comment.
OK, great! Glad you're thinking about it and I'm happy we came to the same
conclusion. :) Later is fine.
This is awesome work, BTW.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent,
renatoo added a comment.
In https://phabricator.kde.org/D8367#162465, @ngraham wrote:
> Nice! If possible, I'd like a more user-friendly way of hiding and showing
categories, though. The context menu is not very discoverable, and if a
category is hidden, there's no indication that
hgoebel added a comment.
Please note that I do not have commit rights, so please somebody else commit.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8577
To: hgoebel, #ktexteditor
Cc: #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann
hgoebel added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8577
To: hgoebel, #ktexteditor
Cc: #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann
hgoebel updated this revision to Diff 21656.
hgoebel changed the visibility from "No One" to "Public (No Login Required)".
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8577?vs=21652=21656
REVISION DETAIL
https://phabricator.kde.org/D8577
AFFECTED
ngraham added a comment.
Nice! If possible, I'd like a more user-friendly way of hiding and showing
categories, though. The context menu is not very discoverable, and if a
category is hidden, there's no indication that there's even anything to show.
Here's how macOS finder handles this, for
renatoo marked 4 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
renatoo updated this revision to Diff 21649.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21623=21649
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
renatoo updated this revision to Diff 21648.
renatoo added a comment.
Update parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21622=21648
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 21647.
renatoo marked 2 inline comments as done.
renatoo added a comment.
Created unittest for PlacesView::convertUrl
Refactory some small part of the code
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
mlaurent updated this revision to Diff 21646.
mlaurent added a comment.
Fix typo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21289=21646
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
To: mlaurent, renatoo,
davidedmundson accepted this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: cfeck, rdieter, graesslin, z3ntu
ngraham added a comment.
My inclination is to land this. Does anyone object?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: cfeck, rdieter, graesslin, z3ntu
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.
mlaurent added a comment.
impossible to rebase this one...
I will need to rewrite all this patch
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent,
mlaurent updated this revision to Diff 21645.
mlaurent added a comment.
Fixing create static variable
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21643=21645
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
mlaurent marked an inline comment as done.
mlaurent added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesmodel.h:55
> You missed a bit, it looks like it wasn't applied on top of the latest
> iteration from the other patches the GroupType enum gained some values for
> its entries.
mlaurent updated this revision to Diff 21644.
mlaurent added a comment.
Autotest GroupIndexes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21612=21644
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> corona.h:223
> + * @returns the id of the screen for a specified name
> + * -1 is returned there is no such screen.
> + * @since 5.40
"if there is
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mlaurent wrote in kfileplacesitem.cpp:202
> This one is for avoiding duplicate code as we create in this patch isHidden
> method.
That was kind of my point,
mlaurent updated this revision to Diff 21643.
mlaurent added a comment.
updated according to comments
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21605=21643
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
mlaurent marked 6 inline comments as done.
mlaurent added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesitem.cpp:202
> Very welcome refactoring... in a separate commit
This one is for avoiding duplicate code as we create in this patch isHidden
method.
REVISION DETAIL
renatoo added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesmodel.cpp:68
> Do we really want to keep that state? It's never reevaluated so could be a
> const if we keep it.
>
> Asks the question of what happens if the setting changes at runtime though.
This code came from
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/129/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 13:05:55 +
Build duration:
24 min and counting
JUnit Tests
Name:
rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.
As mentioned in the bug, we should wait until after digiKam has had a release
containing the change, i.e. 5.8.0. Provoking the dreaded shortcut warning
dialog would be a bad way to say
ngraham added a comment.
The DigiKam folks changed the shortcut, so we can use Ctrl+Shift+, now! Any
remaining objections?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: ilic, abetts, elvisangelaccio, aacid,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/128/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 13:05:55 +
Build duration:
5 min 15 sec and counting
JUnit Tests
Name:
cullmann added a comment.
In Qt 5.6.0 it was already:
static const bool forceMoth =
!qEnvironmentVariableIsEmpty("QV4_FORCE_INTERPRETER");
in Qt 5.7.0 it is:
static const bool forceMoth =
!qEnvironmentVariableIsEmpty("QV4_FORCE_INTERPRETER") ||
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7a6eff3fce41: Implement support for categories on
KfilesPlacesView (authored by Renato Araujo Oliveira Filho
renato.ara...@kdab.com, committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST
rjvbb added a comment.
> Before we got to excessive solutions, I assume you have a build were you
can reproduce the crashs.
Evidently...
I'll check your proposal later today, but a priori I'd say that we should be
fine with setting QV4_FORCE_INTERPRETER from any location that has
ngraham accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg, ngraham
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/136/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 12:46:04 +
Build duration:
9 min 45 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/132/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 12:46:04 +
Build duration:
7 min 22 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R824:16e77619ee73: Display Downloaded From by
default, if file supports it (authored by ngraham).
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/90/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 12:31:39 +
Build duration:
13 min and counting
JUnit Tests
cullmann added a comment.
Before we got to excessive solutions, I assume you have a build were you can
reproduce the crashs.
If you add to your version the line:
qputenv("QV4_FORCE_INTERPRETER", QByteArrayLiteral("1"));
into KTextEditor::EditorPrivate::EditorPrivate constructor
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:5885409fb152: Reduce QString creation in Udev checking
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8494?vs=21367=21633#toc
REPOSITORY
R245 Solid
CHANGES
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
At least the unit test would be welcome, I let you decide on the other
comment.
INLINE COMMENTS
> kfileplacesmodel.cpp:329
>
> +QModelIndexList
rjvbb added a comment.
> static const bool forceMoth =
!qEnvironmentVariableIsEmpty("QV4_FORCE_INTERPRETER") ||
>
!OSAllocator::canAllocateExecutableMemory();
>
> That means on the first invocation that is cached for ever.
Damn, I must
cullmann added a comment.
Hi, first: thanks for working on getting the crashs for older versions away.
To the changes:
1. if the small change to cstyle.js helps to workaround bugs, feel free to
commit that part.
2. for the disabler: I think that is not usable in the way it is
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo updated this revision to Diff 21622.
renatoo added a comment.
Use plural form for RemovableDevicesType enum
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21584=21622
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:504
> QList args;
> -QSignalSpy spy_inserted(m_places,
> SIGNAL(rowsInserted(QModelIndex,int,int)));
> -QSignalSpy
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
renatoo updated this revision to Diff 21623.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21585=21623
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:177
>
> +static const QStringList initalListOfPlaces()
> +{
Typo: initial
> kfileplacesmodeltest.cpp:182
> +
> +static const
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Found a small one after all.
INLINE COMMENTS
> kfileplacesitem_p.h:51
> +DevicesType = 3,
> +RemovableDeviceType = 4
> };
RemovableDevicesType (since you used
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/89/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:08:08 +
Build duration:
1 hr 4 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/135/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:11:28 +
Build duration:
59 min and counting
amantia edited the summary of this revision.
amantia added reviewers: Plasma, ervin, dvratil, mlaurent, hein.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: apol, #frameworks
amantia added a comment.
I will add, please be patient as there are 3 related commits :)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia
Cc: apol, #frameworks
apol added a comment.
Needs context?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia
Cc: apol, #frameworks
amantia created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8566
AFFECTED FILES
src/plasma/corona.cpp
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/131/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:11:28 +
Build duration:
47 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/54/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:09:13 +
Build duration:
49 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/37/
Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:09:43 +
Build duration:
46 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/55/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:09:13 +
Build duration:
41 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/32/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:07:33 +
Build duration:
41 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/27/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:07:00 +
Build duration:
38 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/127/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:02:56 +
Build duration:
42 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/36/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:05:53 +
Build duration:
37 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/30/
Project:
Frameworks kservice kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:07:48 +
Build duration:
34 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20XenialQt5.7/30/
Project:
Frameworks krunner kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:07:33 +
Build duration:
33 min and counting
JUnit Tests
Name:
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
All the fiddling with URLs makes me wonder if that wouldn't be better done on
the KIO implementations side... but that's out of scope for that patch I think.
INLINE COMMENTS
>
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/128/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:02:56 +
Build duration:
33 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/30/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:05:53 +
Build duration:
30 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/131/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 10:03:18 +
Build duration:
31 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/137/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:03:18 +
Build duration:
24 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/53/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 09:58:51 +
Build duration:
24 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/25/
Project:
Frameworks kemoticons kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 10:00:22 +
Build duration:
21 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.9/9/
Project:
Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 31 Oct 2017 09:56:06 +
Build duration:
23 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.7/31/
Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 09:58:22 +
Build duration:
15 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/55/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 09:57:37 +
Build duration:
14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 09:57:51 +
Build duration:
13 min and counting
JUnit Tests
Name:
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.9/2/
Project:
Frameworks kjobwidgets kf5-qt5 AndroidQt5.9
Date of build:
Tue, 31 Oct 2017 10:04:02 +
Build duration:
3 min 58 sec and counting
CONSOLE
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.9/2/
Project:
Frameworks kpackage kf5-qt5 AndroidQt5.9
Date of build:
Tue, 31 Oct 2017 10:05:53 +
Build duration:
36 sec and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/37/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Tue, 31 Oct 2017 09:53:36 +
Build duration:
10 min and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20WindowsMSVCQt5.9/5/
Project:
Frameworks extra-cmake-modules kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 31 Oct 2017 09:54:21 +
Build duration:
8 min 49 sec and
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/55/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 31 Oct 2017 09:54:21 +
Build duration:
4 min 50 sec and counting
graesslin added a comment.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8383
To: graesslin, #frameworks, #kwin, #plasma_on_wayland
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,
mlaurent added a reviewer: ervin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
graesslin added a comment.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8396
To: graesslin, #frameworks, #kwin, #plasma_on_wayland
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,
mlaurent updated this revision to Diff 21612.
mlaurent added a comment.
Minor optimization.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21291=21612
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
src/filewidgets/kfileplacesmodel.cpp
mlaurent edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot
Cc: #frameworks
mlaurent added a reviewer: ervin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot, ervin
Cc: #frameworks
mlaurent edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot
Cc: #frameworks
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot
Cc: #frameworks
ervin added a comment.
Great work BTW, this looks really nice now.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
ervin accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
mlaurent edited the test plan for this revision.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
mlaurent edited the test plan for this revision.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
markg accepted this revision.
markg added a comment.
Lovely! Less code, more features, those are the cool changes :)
I think it's safe to push.
REPOSITORY
R824 Baloo Widgets
BRANCH
origin_url_386261
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin,
mlaurent updated this revision to Diff 21605.
mlaurent added a comment.
Remove duplicate code
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21604=21605
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
mlaurent edited the summary of this revision.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot
Cc: ngraham, mlaurent, #frameworks
mlaurent added a reviewer: ervin.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
mlaurent updated this revision to Diff 21604.
mlaurent added a comment.
Modernize code.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21572=21604
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
99 matches
Mail list logo
