This revision was automatically updated to reflect the committed changes.
Closed by commit R236:525cf0666bc1: KPageListView: Update width on font change
(authored by volkov).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8590?vs=21690=22016
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/137/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 07 Nov 2017 03:41:16 +
Build duration:
1 min 41 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:35656828f12c: Support downloading the 2nd or 3rd download
link from a KNS product (authored by Zren).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8636?vs=21841=22014#toc
REPOSITORY
R252
apol added a comment.
https://phabricator.kde.org/D8173
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8058
To: mart, apol, dfaure, #frameworks
Cc: #frameworks, #build_system
svuorela added a comment.
Thanks for this contribution. I think it is good and needed.
INLINE COMMENTS
> CMakeLists.txt:1
> +set(aztecbarcodetest_srcs
> +aztecbarcodetest.cpp
I'd like an extra level of directories given the large amount of test files, so
we have e.g. autotests/aztec/
simgunz marked an inline comment as done.
simgunz added a comment.
@rkflx I agree on all your points.
In general I also prefer to have the categories. Implementing what you
propose will require a bit of time. Basically if we want any behavior different
from the current one, we need to
simgunz updated this revision to Diff 21990.
simgunz marked an inline comment as done.
simgunz added a comment.
- Use fixed string case insensitive filter
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8056?vs=21925=21990
BRANCH
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
inhibit-idle
REVISION DETAIL
https://phabricator.kde.org/D8383
To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, leezu, ZrenBot,
rkflx added a comment.
@abetts @simgunz If you agree with my ideas in general and also with doing
those in followup patches, please add a short comment. I'll then open a task on
some of Phab's workboards which is better suited for tracking the discussion
than some random comment ;)
ngraham added a comment.
In https://phabricator.kde.org/D8056#165014, @rkflx wrote:
> That said, I would suggest to just commit this patch as is and work on any
further improvements in a followup patch
+1, no need to get bogged down making it perfect in the first patch.
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:20
> +target_link_libraries(prison-reedsolomontest Qt5::Test KF5::Prison)
> +add_test(NAME prison-reedsolomontest COMMAND
rkflx added a comment.
Gave this a spin, it's a really nice improvement. As for the categories, I do
not feel they "get in the way", because:
- In most cases, even after only typing three letters there is only one
result left, which is already preselected so [Enter] will accept
apol created this revision.
apol added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8683
AFFECTED FILES
src/core/kfileitem.cpp
To: apol, #frameworks, dfaure
apol added inline comments.
INLINE COMMENTS
> apol wrote in kfileitem.cpp:559
> My thinking was that if the display name was set through the UDSEntry, one
> would want it to continue coming from a UDSEntry. e.g. if
> `file:///boring.txt` display name is `Magnificient Text File` and we change
rkflx accepted this revision.
rkflx added a comment.
Since I was added as a reviewer:
- Tested with `KWordQuiz`: No app restart necessary anymore to adapt width to
changed font.
- Code looks simple enough and even passes the event to the base class.
Perfect patch, thanks :)
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:8bff75d10fa3: Update default colors to match new colors
in D7424 (authored by ngraham).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8592?vs=21698=21978
jensreuterberg added a comment.
+1 but as with the original proposal - remember that we may need to revert
this if the change balloons out of control
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D8592
To: ngraham, #frameworks, broulik, #vdg
Cc:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/134/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Mon, 06 Nov 2017 14:18:34 +
Build duration:
11 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/138/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 06 Nov 2017 14:18:35 +
Build duration:
3 min 26 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d51456bdfcbd: Remove DataModel::roleNameToId (authored by
broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8638?vs=21831=21965
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3ebdd64e6bbd: Optimize SortFilterModel role names
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8639?vs=21832=21966
cgiboudeaux added a comment.
In https://phabricator.kde.org/D7823#164880, @marten wrote:
> In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
>
> > Are the copies in the attic directory still needed for compatibility
reasons, or can they get removed?
>
>
> No needed by
marten added a comment.
In https://phabricator.kde.org/D7823#164879, @cfeck wrote:
> Are the copies in the attic directory still needed for compatibility
reasons, or can they get removed?
No needed by anything within Frameworks, Plasma or Applications as far as I'm
aware. Shall
cfeck added a comment.
Are the copies in the attic directory still needed for compatibility reasons,
or can they get removed?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux,
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ee5b036c1df4: Add FindGLIB2.cmake and
FindPulseAudio.cmake (authored by marten).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7823?vs=19611=21961#toc
REPOSITORY
R240 Extra CMake Modules
apol added inline comments.
INLINE COMMENTS
> dfaure wrote in kfileitem.cpp:559
> Wouldn't it be safer to say if (!name.isEmpty()), for the actual bug you were
> experiencing?
>
> Otherwise I'm afraid that this commit breaks a number of things, like after
> renaming a file, the new name
broulik updated this revision to Diff 21954.
broulik added a comment.
- `constBegin()` on `m_allCurrentDestUrls`
- Use `indexForNode`
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8640?vs=21835=21954
REVISION DETAIL
https://phabricator.kde.org/D8640
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/95/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 06 Nov 2017 11:01:19 +
Build duration:
13 min and counting
JUnit Tests
kfunk added a comment.
In https://phabricator.kde.org/D8577#164815, @cullmann wrote:
> Could you just remove the problematic includes and try to compile without
the dependency, IMHO I see no use of QtScript stuff.
Done with:
hgoebel added a comment.
My aim is to bring Plasma into GuixSD, not to develop ktexteditor. So please
understand that I'm not going to work on ktexteditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8577
To: hgoebel, #ktexteditor, dfaure
Cc: cullmann,
cullmann added a comment.
Could you just remove the problematic includes and try to compile without the
dependency, IMHO I see no use of QtScript stuff.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8577
To: hgoebel, #ktexteditor, dfaure
Cc: cullmann,
hgoebel added a comment.
Well, the currently the dependency is still needed, see
https://cgit.kde.org/ktexteditor.git/tree/autotests/src/scripting_test.cpp#n51:
#include
If the code is not compiled in an isolated and controlled environment, and
QtScript is installed on the
32 matches
Mail list logo
