anthonyfieroni added a comment.
In https://phabricator.kde.org/D9128#176957, @mpyne wrote:
> Though maybe weak pointers were just there to avoid circular references?
Yes, it's look like.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D9128
To:
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
I think the change looks good. But if the cache here is holding a *weak*
pointer to a `Cache` then every user of this s_cache should be checking for
null pointers each time, right? We can
dhaumann added a comment.
I was just testing this. With this patch, a non-existing ~/test:
1. Dolphin goes to /home/dh/test, and a red box tells the folder does not
exist. This is better than the protocol-error message, so
https://bugs.kde.org/show_bug.cgi?id=372813 should be fixed.
dhaumann added a reviewer: gregormi.
REVISION DETAIL
https://phabricator.kde.org/D9217
To: dfaure, emateli, elvisangelaccio, gregormi
Cc: broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:d2d0ae83d2ca: Fix build against TagLib 1.11
(authored by dvratil).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9233?vs=23583=23588
REVISION DETAIL
mgallien accepted this revision.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D9233
To: dvratil, mgallien, aacid
Cc: #frameworks
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D9233
To: dvratil, mgallien, aacid
Cc: #frameworks
dvratil created this revision.
dvratil added a reviewer: mgallien.
dvratil added a project: Frameworks.
REVISION SUMMARY
Fix build of KFileMetadata against TagLib older than 1.11.
Fixes build on Windows where Craft only has Taglib 1.9.2 by default.
REPOSITORY
R286 KFileMetaData
ngraham added a comment.
@simgunz, how are we doing on addressing the latest review comments? I just
love this new UI; it's a huge improvement over the status quo IMHO, and it
would be nice to get it in sometime soon.
REPOSITORY
R241 KIO
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/21/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Wed, 06 Dec 2017 19:33:36 +
Build duration:
12 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Wed, 06 Dec 2017 19:33:36 +
Build duration:
11 min and counting
JUnit Tests
Name: (root)
anthonyfieroni added a comment.
Any opinion?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D9128
To: anthonyfieroni, leinir, dfaure
Cc: #frameworks
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/2/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 06 Dec 2017 19:33:36 +
Build duration:
3 min 12 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9f722407d902: [KOpenWithDialog] Remove redundant creation
of KLineEdit (authored by anthonyfieroni).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9220?vs=23545=23582
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f78b2e533fc1: Remove unused keyword lists and contexts
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9214?vs=23530=23579
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f930d6dbc399: Pony: Remove unused keyword lists (authored
by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9212?vs=23527=23578
REVISION
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
PonyCleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9212
To: dhaumann, jpoelen, jpoelen2, vkrause
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
RemoveUnusedKeywordLists (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9214
To: dhaumann, vkrause
Cc: #frameworks
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/1/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 06 Dec 2017 18:07:56 +
Build duration:
1 min 54 sec and counting
CONSOLE OUTPUT
emateli added a comment.
I can't seem to be able to properly run this(whatever changes I make to the
kshorturifilter.cpp seem to be ignored?!) but on paper looks good to me. Do we
mark https://phabricator.kde.org/D8920 as abandoned, or wait for this to commit
then the new `dir` property of
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
In https://phabricator.kde.org/D8652#176706, @davidedmundson wrote:
> The comment about being static needs to be in the protocol xml too. Then
this is good to go.
>
> ( though
davidedmundson accepted this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
The comment about being static needs to be in the protocol xml too. Then this
is good to go.
( though what's your reasoning for not just
renatoo accepted this revision.
renatoo added a comment.
Looks good and work as expected
INLINE COMMENTS
> kfileplacesview.cpp:766
> +}
> if (!clickOverHeader && index.isValid()) {
> if (!placesModel->isDevice(index)) {
I think that you can replace
if (!clickOverHeader &&
renatoo accepted this revision.
renatoo added a comment.
Looks good and works as expected
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
one minor nit, otherwise lgtm
INLINE COMMENTS
> kfileplacesmodel.cpp:431
> +QModelIndexList indexes;
> +for (int row = 0; row < rowCount(); ++row) {
> +const QModelIndex
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
lgtm
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
Date of build:
Wed, 06 Dec 2017 10:55:04 +
Build duration:
2 min 0 sec and counting
JUnit Tests
Name:
volkov updated this revision to Diff 23553.
volkov added a comment.
add 'since 5.42'
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9224?vs=23552=23553
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9224
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a69d8e562b6e: Deprecate KDesktopFile::sortOrder()
(authored by volkov).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9224?vs=23553=23554
REVISION DETAIL
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kdesktopfile.h:221
> * @return the value of the "SortOrder=" entry.
> + * @deprecated
> + * SortOrder was used to specify the order of menu items, but
volkov updated this revision to Diff 23552.
volkov added a comment.
make the test buildable with KDE_NO_DEPRECATED
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9224?vs=23551=23552
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9224
volkov added reviewers: dfaure, Frameworks.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9224
To: volkov, dfaure, #frameworks
Cc: #frameworks
volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The SortOrder key is deprecated by the Desktop Entry Specification:
https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It spends 160ms in total on plasmashell startup for me here.
TEST PLAN
My
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
Date of build:
Wed, 06 Dec 2017 10:13:12 +
Build duration:
4 min 36 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:fa2c4484d8db: Do not crash when setting new line edit on
an editable combo box (authored by mwolff).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9189?vs=23508=23549#toc
REPOSITORY
R284
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
Date of build:
Wed, 06 Dec 2017 10:00:49 +
Build duration:
11 min and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d328dd6ac725: Fix the result of KDesktopFile::sortOrder()
(authored by volkov).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8689?vs=22018=23548
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9220
To: anthonyfieroni, dfaure, mwolff
Cc: #frameworks
broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
TODO
- Figure out how to get the clear button used size (though from what I can
tell it's only used by kcombobox and khtml
REPOSITORY
R284
anthonyfieroni added a comment.
It should
https://api.kde.org/frameworks/kcompletion/html/kcombobox_8cpp_source.html#l00090
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9220
To: anthonyfieroni, dfaure, mwolff
Cc: #frameworks
dfaure added a comment.
Is the clear button still shown?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9220
To: anthonyfieroni, dfaure, mwolff
Cc: #frameworks
anthonyfieroni created this revision.
anthonyfieroni added reviewers: dfaure, mwolff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
KHistoryComboBox creates editable KLineEdit
REPOSITORY
R241 KIO
REVISION DETAIL
mlaurent accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
mlaurent accepted this revision.
mlaurent added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:863-866
> This duplicates code from the next if branch below... I wonder if before or
> after that commit we shouldn't try to refactor that and remove some of the
> code
On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote:
> If someone has a list of common font packages for SUSE then I can add
> those to the image relatively easy, which will probably fix those
> tests.
dejavu-fonts might be enough.
But otherwise here's a more complete list, from my Leap
dhaumann created this revision.
dhaumann added reviewers: cullmann, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the KTextEditor scripting API by:
- String editor.clipboardText()
47 matches
Mail list logo
