Re: KHTML Commit 77c21d19c314d79da1b60e319aa40eff57fef375

Le vendredi 15 décembre 2017, 03:38:32 CET Ben Cooksley a écrit : > Hi Laurent, all, Hi, Indeed fixed now. Sorry for the problem. Regards > > Recently a series of Dependency Build jobs on the CI system have begun > failing with errors pointing to missing headers inside KHTML. In > particular

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Dec 2017 05:43:01 + Build duration: 8 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 15 Dec 2017 05:43:01 + Build duration: 5 min 44 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/19/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Fri, 15 Dec 2017 05:43:01 + Build duration: 3 min 7 sec and counting JUnit Tests

D9330: Fix cmake warning (with cmake >= 3.9.0)

mlaurent abandoned this revision. mlaurent added a comment. commited in kcoreaddons REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: kossebau, flherne, #frameworks

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R244:fbc5881b916c: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and… (authored by mlaurent). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KHTML Commit 77c21d19c314d79da1b60e319aa40eff57fef375

Hi Laurent, all, Recently a series of Dependency Build jobs on the CI system have begun failing with errors pointing to missing headers inside KHTML. In particular it seems a header called "khtml_debug.h" can no longer be found. Looking more closely into the issue it seems that this header, and

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

nicolasfella added a comment. In https://phabricator.kde.org/D9190#179713, @aacid wrote: > Sorry guys i unsubscribed you by mistake when updating the summary. > > Nicolas can you check if this fixes it for you? It does for me. Will do on Monday REPOSITORY R241 KIO REVISION

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

aacid added subscribers: anthonyfieroni, nicolasfella. aacid added a comment. Sorry guys i unsubscribed you by mistake when updating the summary. Nicolas can you check if this fixes it for you? It does for me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

aacid updated this revision to Diff 23941. aacid retitled this revision from "TransferJob: workaround for when the readChannelFinished has already been emitted" to "TransferJob: fix for when the readChannelFinished has already been emitted before start is called()". aacid removed subscribers:

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I currently can't do a testbuild, but the code looks good now. If we want to iterate on the concept further I think we should do it separately, no sense holding up this diff from

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: #frameworks

D9324: [Air theme] Add task bar progress graphic

abetts added a comment. What should be the move here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8332: Added baloo urls into places model

ngraham added a comment. I'm not at a Linux machine right now. @renatoo, would you mind investigating that in a few non-Dolphin apps' file pickers and open and save dialogs? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin,

D9318: [knewstuff] Limit request cache size

anthonyfieroni added a comment. In https://phabricator.kde.org/D9318#179477, @dfaure wrote: > Technically no, since it doesn't change the size of the class itself (and requestCache is private and isn't used in any inline method). You are right, size will not change. In

D8332: Added baloo urls into places model

rkflx added a comment. Before the ball gets rolling, it would be nice if someone familiar with that part of the code could comment on what's going on with what I mentioned or can reproduce at least (it sounds like a generic problem to me): > Also some entries show an error message or

D8332: Added baloo urls into places model

ngraham added a comment. Thanks for that investigation, @rkflx. I aspire to your level of thoroughness. macOS file pickers have a vertical scrollbar by default to show nearly equivalent content, so I don't think that's a huge deal. We could perhaps hide some sections by default (as long

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 18:21:19 + Build duration: 19 min and counting JUnit Tests Name: (root)

D8332: Added baloo urls into places model

renatoo added a comment. In https://phabricator.kde.org/D8332#179633, @rkflx wrote: > This change caused a little bit of fallout for #Gwenview. Apparently the review focussed more on the code, but less so on the behaviour in users of the class. I'm not complaining, but given one of our

D9290: [kio] Fix create path

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c72f8e4b0ca0: Fix creation of paths (authored by anthonyfieroni). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9290?vs=23845=23933 REVISION DETAIL

D8332: Added baloo urls into places model

rkflx added a comment. This change caused a little bit of fallout for #Gwenview. Apparently the review focussed more on the code, but less so on the behaviour in users of the class. I'm not complaining, but given one of our focus goals is on usability and quality of the basic apps, it would

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.7 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 17:34:46 + Build duration: 1 min 36 sec and counting JUnit Tests Name:

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. external bug report: https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot,

D9332: Allow filter places based on alternative application name

renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent, aacid, ngraham, #frameworks

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 23930. renatoo added a comment. Added kf6 comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9332?vs=23926=23930 REVISION DETAIL https://phabricator.kde.org/D9332 AFFECTED FILES

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 17:26:59 + Build duration: 4 min 59 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/14/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 17:26:59 + Build duration: 1 min 39 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 17:26:59 + Build duration: 1 min 11 sec and counting JUnit Tests

D9335: invalidate the runtime cache on install

This revision was automatically updated to reflect the committed changes. Closed by commit R290:a33d3f0f1e73: invalidate the runtime cache on install (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9335?vs=23927=23929 REVISION DETAIL

D9275: fix RTL appearance for ComboBox

mvourlakos added a subscriber: mart. mvourlakos added a comment. @mart what about this? are you able to reproduce it in your system? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: mart, plasma-devel, #frameworks,

D9332: Allow filter places based on alternative application name

mlaurent added inline comments. INLINE COMMENTS > kfileplacesmodel.h:72 > +* @param parent Parent object > +* @since 5.41 > +*/ 5.42 and missing //kf6 comment REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent,

D9335: invalidate the runtime cache on install

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH packagefix REVISION DETAIL https://phabricator.kde.org/D9335 To: mart, #plasma, sebas Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

mlaurent retitled this revision from "Remove cmake warning" to "Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: #frameworks

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos abandoned this revision. mvourlakos added a comment. this is Adapta theme issue... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9334: Remove cmake warning

mlaurent updated this revision to Diff 23928. mlaurent added a comment. - Remove line which made no sense in this module REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9334?vs=23923=23928 BRANCH remove_cmake_warning REVISION DETAIL

D9335: invalidate the runtime cache on install

mart created this revision. mart added reviewers: Plasma, sebas. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY at the first time something gets installed, immediately drop runtime cache this

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. In https://phabricator.kde.org/D9276#179574, @mart wrote: > here on master the item under mouse does get highlighted you are totally right!! so sorry... this is Adapta theme issue, changing to Breeze themes solves this... REPOSITORY R242 Plasma

D9334: Remove cmake warning

dfaure added a comment. Please expand the commit log. Like "Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON" INLINE COMMENTS > KF5CoreAddonsConfig.cmake.in:10 > + # 3.10+ lets us provide more macro names that require automoc. > + # Remove this when

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 23926. renatoo marked 3 inline comments as done. renatoo edited the summary of this revision. renatoo added a comment. Added documention for the new constructor REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9332: Allow filter places based on alternative application name

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodeltest.cpp:1276 > +// create a new entry with alternative application name > +KBookmark bookmark =

D9334: Remove cmake warning

mlaurent added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: #frameworks

D9334: Remove cmake warning

mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compile kio without warning REPOSITORY R244 KCoreAddons BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9334

D9330: Fix cmake warning (with cmake >= 3.9.0)

mlaurent added a comment. ok see https://phabricator.kde.org/D9334 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: kossebau, flherne, #frameworks

D9276: highlight PlasmaComponents3.ComboBox list items

mart added a comment. here on master the item under mouse does get highlighted F5548404: Spectacle.Z15071.png INLINE COMMENTS > mvourlakos wrote in ComboBox.qml:49 > yes... it didnt highlight at all, neither the selected item nor the hovered > one...

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: aacid, ngraham, #frameworks

D9332: Allow filter places based on alternative application name

renatoo marked an inline comment as done. renatoo added inline comments. INLINE COMMENTS > aacid wrote in kfileplacesmodel.h:67 > This breaks ABI so it's not acceptable. > > Also how does this fix anything if the new alternativeApplicationName > parameter is never passed in any of the existing

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 23922. renatoo added a comment. Avoid ABI break REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9332?vs=23920=23922 REVISION DETAIL https://phabricator.kde.org/D9332 AFFECTED FILES autotests/kfileplacesmodeltest.cpp

D9332: Allow filter places based on alternative application name

aacid added inline comments. INLINE COMMENTS > kfileplacesmodel.h:67 > > -KFilePlacesModel(QObject *parent = nullptr); > +KFilePlacesModel(QObject *parent = nullptr, const QString > = {}); > ~KFilePlacesModel(); This breaks ABI so it's not acceptable. Also how does this fix

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: ngraham, #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo added a reviewer: mwolff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo added a dependent revision: D9333: Make sure that old ulrs does not appear duplicated in places model. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo Cc: #frameworks

D9330: Fix cmake warning (with cmake >= 3.9.0)

dfaure added a comment. You're right, this belongs to KF5CoreAddonsConfig.cmake REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: kossebau, flherne, #frameworks

D9332: Allow filter places based on alternative application name

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY You can use a alternative application name to filter items on places model. This new parameter will will be use to match the

D9330: Fix cmake warning (with cmake >= 3.9.0)

kossebau added a comment. In https://phabricator.kde.org/D9330#179506, @dfaure wrote: > Why not do this in ECM? Doing this in ECM would mean maintaining a list of macros in a repo/product separate from the repo/products where the respective macros are defined. More, what

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/35/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 14:58:47 + Build duration: 16 min and counting JUnit Tests Name: (root)

D9330: Fix cmake warning (with cmake >= 3.9.0)

kossebau added subscribers: flherne, kossebau. kossebau added a comment. @flherne has been working on a patch to add list(APPEND CMAKE_AUTOMOC_MACRO_NAMES "K_PLUGIN_FACTORY_WITH_JSON") to `KF5CoreAddonsConfig.cmake` and similar for other modules., so the needed settings are

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 34 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/34/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 14:47:58 + Build duration: 10 min and counting JUnit Tests Name: (root)

D9327: Remove duplicate lines.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5a6ce6d48c29: Remove duplicate lines. (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9327?vs=23909=23918 REVISION DETAIL

D9206: Implement a kfile dialog where we can add custom widget

This revision was automatically updated to reflect the committed changes. Closed by commit R241:41fbb247d97c: Implement a kfile dialog where we can add custom widget (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9206?vs=23916=23917

D9206: Implement a kfile dialog where we can add custom widget

mlaurent updated this revision to Diff 23916. mlaurent added a comment. - Remove indirection methods as requested by David. Fix doc too REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9206?vs=23908=23916 BRANCH add_kfile_dialog REVISION DETAIL

D9206: Implement a kfile dialog where we can add custom widget

mlaurent marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH add_kfile_dialog REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 13 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/13/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 14:34:33 + Build duration: 4 min 50 sec and counting JUnit Tests

D9330: Fix cmake warning (with cmake >= 3.9.0)

mlaurent added a comment. Ok I can move it to ecm (mais in which file ?) "kde-modules/KDECMakeSettings.cmake" ? and it depends if apps have some specific macro for example in kmail we have "EXPORT_KONTACT_PLUGIN" too REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 14:34:33 + Build duration: 3 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/13/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 14:34:33 + Build duration: 1 min 45 sec and counting JUnit Tests

D9329: Verify that qWaitForWindowActive doesn't fail

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c0e239446b64: Verify that qWaitForWindowActive doesnt fail (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9329?vs=23911=23915 REVISION DETAIL

D9329: Verify that qWaitForWindowActive doesn't fail

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH verify_return_value_qWaitForWindowActive REVISION DETAIL https://phabricator.kde.org/D9329 To: mlaurent, dfaure Cc: #frameworks

D9330: Fix cmake warning (with cmake >= 3.9.0)

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Why not do this in ECM? This comment seems to come from KDE apps or something, which depend on old ECM. But KF5.42 depends on ECM5.42, so I don't see the usefulness.

D9330: Fix cmake warning (with cmake >= 3.9.0)

mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN build REPOSITORY R241 KIO BRANCH fix_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9330 AFFECTED FILES CMakeLists.txt

D9330: Fix cmake warning (with cmake >= 3.9.0)

mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: #frameworks

D9329: Verify that qWaitForWindowActive doesn't fail

mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9329 To: mlaurent, dfaure Cc: #frameworks

D9329: Verify that qWaitForWindowActive doesn't fail

mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compile REPOSITORY R241 KIO BRANCH verify_return_value_qWaitForWindowActive REVISION DETAIL https://phabricator.kde.org/D9329 AFFECTED

D9318: [knewstuff] Limit request cache size

dfaure added a comment. Technically no, since it doesn't change the size of the class itself (and requestCache is private and isn't used in any inline method). The benefit of QSet over a linear search only starts after a large enough amount of elements in the set though. I have no idea

D9324: [Air theme] Add task bar progress graphic

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9327: Remove duplicate lines.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH remove_duplicate_tab_order REVISION DETAIL https://phabricator.kde.org/D9327 To: mlaurent, dfaure Cc: #frameworks

D9206: Implement a kfile dialog where we can add custom widget

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:41 > > + > ) nothing to see here > kfilecustomdialog.cpp:65 > + > +void KFileCustomDialogPrivate::setUrl(const QUrl ) > +{ I wonder about the

D9327: Remove duplicate lines.

mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9327 To: mlaurent, dfaure Cc: #frameworks

D9327: Remove duplicate lines.

mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN build/execute test apps REPOSITORY R241 KIO BRANCH remove_duplicate_tab_order REVISION DETAIL https://phabricator.kde.org/D9327 AFFECTED

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/12/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 13:54:33 + Build duration: 4 min 41 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/12/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 13:54:33 + Build duration: 4 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 13:54:33 + Build duration: 3 min 46 sec and counting JUnit Tests

D9206: Implement a kfile dialog where we can add custom widget

mlaurent updated this revision to Diff 23908. mlaurent added a comment. - Fix doc, remove unused code, etc. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9206?vs=23514=23908 BRANCH add_kfile_dialog REVISION DETAIL https://phabricator.kde.org/D9206

D9206: Implement a kfile dialog where we can add custom widget

mlaurent marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23906. mart added a comment. - extra warning REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23905=23906 BRANCH arcpatch-D9124 REVISION DETAIL https://phabricator.kde.org/D9124 AFFECTED

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23905. mart added a comment. - make rewriting of both files and qrc work REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23899=23905 BRANCH arcpatch-D9124 REVISION DETAIL

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 11:55:52 + Build duration: 6 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 11:55:52 + Build duration: 2 min 45 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 11:55:52 + Build duration: 1 min 8 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/11/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 11:47:22 + Build duration: 6 min 30 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Dec 2017 11:36:12 + Build duration: 15 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 11:36:12 + Build duration: 15 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.9 - Build # 24 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20WindowsMSVCQt5.9/24/ Project: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 14 Dec 2017 11:47:22 + Build duration: 2 min 8 sec and counting JUnit

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/11/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Thu, 14 Dec 2017 11:47:22 + Build duration: 1 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 11:47:22 + Build duration: 1 min 7 sec and counting JUnit Tests

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23899. mart added a comment. - manage all cases for packages and check for file existence beforehand REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23490=23899 BRANCH arcpatch-D9124 REVISION

  1   2   >