D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2017-12-21 Thread Laurent Montel
mlaurent added a comment. You still missing all patch... Please use arc diff so we are sure that all patch is updated. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks

KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 - Build # 20 - Still unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.9/20/ Project: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 22 Dec 2017 04:56:30 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 46 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/46/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 22 Dec 2017 04:08:12 + Build duration: 23 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Dec 2017 04:08:12 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 04:08:12 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 23:17:51 + Build duration: 16 min and counting JUnit

D9211: Iterate over initializer_lists to avoid mem allocs

2017-12-21 Thread Milian Wolff
mwolff added a comment. much better, but can be somewhat better still. if people don't know the STL, they should learn it. INLINE COMMENTS > katedocument.cpp:109 > +auto it = std::find(list.begin(), list.end(), entry); > +return it == list.end() ? -1 : std::distance(it,

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/15/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 23:17:51 + Build duration: 5 min 10 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 16 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 23:17:51 + Build duration: 4 min 56 sec and counting JUnit

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R285:02d555f9db3e: Fix build on Linux without X11 (authored by vkrause). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24251=24270 REVISION DETAIL

D6992: Fix build on Linux without X11

2017-12-21 Thread David Faure
dfaure accepted this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin, dfaure Cc: dfaure, graesslin, bshah

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

2017-12-21 Thread David Faure
dfaure added a comment. Makes sense, I guess. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks

D9394: Show "Search wrapped" message in center of view for better visibility

2017-12-21 Thread Dominik Haumann
dhaumann added a comment. @neundorf Did you try the patch? Or anyone else? I would like to get this right instead of having yet another solution that is not good enough. REPOSITORY R39 KTextEditor BRANCH SearchMessages (branched from master) REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 45 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/45/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 18:38:11 + Build duration: 26 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 18:38:11 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 18:38:11 + Build duration: 13 min and counting JUnit Tests Name: (root)

D9318: [knewstuff] Limit request cache size

2017-12-21 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R304:6de0754aa925: Limit request cache size (authored by anthonyfieroni). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9318?vs=24144=24267 REVISION DETAIL

D9442: [kcoredirlister] FIx sub path creation

2017-12-21 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1b90a8c10547: [kcoredirlister] Fix sub path creation (authored by anthonyfieroni). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9442?vs=24183=24266 REVISION DETAIL

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

2017-12-21 Thread Ralf Habacker
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Access to the internal global static is provided by the already available method

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
vkrause updated this revision to Diff 24251. vkrause added a comment. follow kinit changes REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24227=24251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES

D9454: Remove impossible to reach code

2017-12-21 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R303:f68d54697318: Remove impossible to reach code (authored by vkrause). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9454?vs=24249=24250 REVISION DETAIL

D9454: Remove impossible to reach code

2017-12-21 Thread David Faure
dfaure accepted this revision. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 To: vkrause, dfaure Cc: #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

2017-12-21 Thread Peter Majchrak
petermajchrak added a comment. Ou, ok. Sorry, I didn't know that. Perfect, so combobox it is then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham,

D8536: Add more hashing algorithms to KPropertiesDialog

2017-12-21 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D8536#181775, @petermajchrak wrote: > I can revert it back to the combobox based layout. Don't we have some UX people that could take a look at this? Yes, me :) Which is what I did, and commented with my recommendation.

D9454: Remove impossible to reach code

2017-12-21 Thread Volker Krause
vkrause updated this revision to Diff 24249. vkrause added a comment. address review comment REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9454?vs=24226=24249 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9454 AFFECTED FILES

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 44 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/44/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 14:59:00 + Build duration: 19 min and counting JUnit Tests Name: (root)

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

2017-12-21 Thread Veluri Mithun
velurimithun updated this revision to Diff 24238. velurimithun marked 2 inline comments as done. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9420?vs=24199=24238 REVISION DETAIL https://phabricator.kde.org/D9420 AFFECTED FILES

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 14:59:00 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 14:59:00 + Build duration: 14 min and counting JUnit Tests Name: (root)

D9456: Remove blip.tv web shortcuts

2017-12-21 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0e26720cdb76: Remove blip.tv web shortcuts (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9456?vs=24230=24236 REVISION DETAIL

D9456: Remove blip.tv web shortcuts

2017-12-21 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D9456#182021, @broulik wrote: > One could potentially write an autotest that fires a search to every site and checks for whether it responds and doesn't throw a 404. However, I fear that test would be quite flaky. And not

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 43 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/43/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 14:23:10 + Build duration: 17 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 14:23:10 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 14:23:10 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/14/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 14:16:00 + Build duration: 17 min and counting JUnit

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

2017-12-21 Thread Ralf Habacker
habacker added a comment. In https://phabricator.kde.org/D9423#181793, @dfaure wrote: > A single .in file sounds good indeed. Sorry for approving the first one too fast. That means the solution needs to be applied to more then one git repo - kio - kwallet - just

D9456: Remove blip.tv web shortcuts

2017-12-21 Thread Kai Uwe Broulik
broulik added a comment. One could potentially write an autotest that fires a search to every site and checks for whether it responds and doesn't throw a 404. However, I fear that test would be quite flaky. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To:

D9456: Remove blip.tv web shortcuts

2017-12-21 Thread Aleix Pol Gonzalez
apol added a comment. Would it be possible to add some kind of test maybe? to make sure that they do something at least. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To: broulik, #frameworks, apol

D9456: Remove blip.tv web shortcuts

2017-12-21 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 To: broulik, #frameworks, apol

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 15 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 14:16:00 + Build duration: 7 min 31 sec and counting JUnit

D9455: Fix Qt documentation web shortcut

2017-12-21 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5e984824d4c3: Fix Qt documentation web shortcut (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9455?vs=24228=24231 REVISION DETAIL

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 14:16:00 + Build duration: 6 min 33 sec and counting

D9454: Remove impossible to reach code

2017-12-21 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > wrapper.cpp:49 > { > // Can't use QGuiApplication::platformName() here, there is no app > instance. > return "DISPLAY"; Move this comment above the #if (of

D9456: Remove blip.tv web shortcuts

2017-12-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY The website was shut down in August 2015 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9456 AFFECTED FILES

D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

2017-12-21 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R239:829c992b9997: Inform the user if the module can not be registered with org.kde.kded5 and exit… (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D9455: Fix Qt documentation web shortcut

2017-12-21 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9455 To: broulik, #frameworks, vkrause

D9455: Fix Qt documentation web shortcut

2017-12-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY The URL changed after their website relaunch TEST PLAN Typed `qt test` into KRunner, got Qt 5 doc search for "test" Typed `qt4 test` into KRunner, got

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
vkrause updated this revision to Diff 24227. vkrause added a comment. Remove dead code. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24225=24227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp

D9454: Remove impossible to reach code

2017-12-21 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This also brings this back in sync with src/kdeinit/kinit.cpp. REPOSITORY R303 KInit BRANCH master

D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

2017-12-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9453 To: habacker, dfaure Cc: #frameworks

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > dfaure wrote in kcrash.cpp:271 > I wonder why this isn't removed then, it can't happen ;-) Indeed, I'll clean it up here and in kinit. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks,

D6992: Fix build on Linux without X11

2017-12-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Looks much better indeed, thanks. INLINE COMMENTS > kcrash.cpp:271 > return "MAC_DISPLAY"; > #elif defined(Q_OS_WIN) > return "WIN_DISPLAY"; I wonder why this isn't removed then, it can't happen ;-) REPOSITORY R285 KCrash

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
vkrause updated this revision to Diff 24225. vkrause added a comment. Re-sync with KInit, and thus solve the non-X11 compile issue in the same way as it's handled there already. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=24216=24225 BRANCH

D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

2017-12-21 Thread Ralf Habacker
habacker updated this revision to Diff 24224. habacker added a comment. - follow code style - do not call quit() REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9453?vs=24223=24224 BRANCH master REVISION DETAIL

D6992: Fix build on Linux without X11

2017-12-21 Thread David Faure
dfaure added a comment. Hmm, OK. Sounds like the whole thing could easily be refactored to not call qgetenv at all on non-X11... (i.e. including on OSX/Windows). That would be much less confusing. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause,

D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

2017-12-21 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. kded5 is supposed to be autostarted on demand by the DBus activation mechanism, but OK, if the setup is broken, I guess that might fail. INLINE COMMENTS >

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
vkrause added a comment. It's going to call getenv("") and then continue with the empty display variable case for non-X11 below. At least that's the assumption, an entirely X11-free setup is still somewhat theoretical at this point :) My goal for now is to make the KF5 Yocto recipes useful

D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

2017-12-21 Thread Ralf Habacker
habacker updated this revision to Diff 24223. habacker added a comment. - really shut down app in case of errors REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9453?vs=24220=24223 BRANCH master REVISION DETAIL

D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

2017-12-21 Thread Ralf Habacker
habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It makes no sense to run this test app without registering with kded5 as this is a required

D6992: Fix build on Linux without X11

2017-12-21 Thread David Faure
dfaure added a comment. so this is going to call getenv("") ? Or is this code path never called? REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin Cc: dfaure, graesslin, bshah

D6992: Fix build on Linux without X11

2017-12-21 Thread Volker Krause
vkrause updated this revision to Diff 24216. vkrause added a comment. Reduced to a minimal compile fix for now. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=17388=24216 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 42 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/42/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 11:45:59 + Build duration: 40 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 11:45:59 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 11:45:59 + Build duration: 7 min 38 sec and counting JUnit Tests Name:

D5199: Reflect trash state in iconNameForUrl

2017-12-21 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ca6e6c0469a5: Reflect trash state in iconNameForUrl (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5199?vs=12872=24212 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Dec 2017 10:24:19 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 41 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/41/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 21 Dec 2017 10:24:19 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

2017-12-21 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 21 Dec 2017 10:24:19 + Build duration: 8 min 54 sec and counting JUnit Tests Name:

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-21 Thread Milian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a43aea3e: Forward QComboBox signals instead of QComboBox lineedit signals (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7968?vs=24188=24203#toc REPOSITORY R241

D9446: WIP: Allow to autogenerate and install categories file

2017-12-21 Thread Fabian Vogt
fvogt added a comment. `${KDE_INSTALL_CONFDIR}` should be changed to somewhere else (but maybe in a different patch) IMO `file(APPEND ...)` is the wrong approach, it should collect all categories in a variable and only write it out once at the end (with configure_file). I'm not fluent

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 - Build # 25 - Fixed!

2017-12-21 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/25/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 21 Dec 2017 09:09:30 + Build duration: 3 min 17 sec and counting

D9318: [knewstuff] Limit request cache size

2017-12-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9318 To: anthonyfieroni, leinir, #frameworks, dfaure Cc: dfaure, broulik

D9386: Mingw32 compile fix

2017-12-21 Thread David Faure
dfaure added a comment. Put it in the common file, and add an accessor for the other files, for instance a static method in Solid::NetworkingPrivate. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc:

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-21 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kurlrequestertest.cpp:186 > +QTest::keyEvent(QTest::Click, req.comboBox(), Qt::Key_Down); > +qDebug() << textSpy << editSpy << returnSpy << returnWithTextSpy; > +QCOMPARE(textSpy.size(), 2); Please remove this line though.

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

2017-12-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks

D9442: [kcoredirlister] FIx sub path creation

2017-12-21 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9442 To: anthonyfieroni, dfaure Cc: #frameworks

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

2017-12-21 Thread David Faure
dfaure added a comment. A single .in file sounds good indeed. Sorry for approving the first one too fast. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

2017-12-21 Thread Ben Cooksley
bcooksley added a comment. In regards to needing to inspect the build directory (which is something we rarely get asked for) the system automatically tarballs a copy of the entire workspace (which includes the source code and build directory) whenever a build fails or has failing tests.

D9446: WIP: Allow to autogenerate and install categories file

2017-12-21 Thread Luca Beltrame
lbeltrame added a comment. For those who wonder why this would be necessary, see https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame,

D9446: WIP: Allow to autogenerate and install categories file

2017-12-21 Thread Luca Beltrame
lbeltrame added a reviewer: fvogt. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system

D9446: WIP: Allow to autogenerate and install categories file

2017-12-21 Thread Laurent Montel
mlaurent added reviewers: kfunk, lbeltrame, cgiboudeaux, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure Cc: #frameworks, #build_system