chinmoyr added a comment.
@dhaumann The helper is called only when the error is EACCES or EPERM. So, if
you are already root then this won't be the case and file ioslave will work as
usual.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6831
To:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/26/
Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 03 Jan 2018 06:23:36 +
Build duration:
52 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/17/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Wed, 03 Jan 2018 05:48:41 +
Build duration:
23 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/16/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Wed, 03 Jan 2018 05:48:41 +
Build duration:
22 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/11/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 03 Jan 2018 05:48:41 +
Build duration:
18 min and counting
JUnit
dhaumann added a comment.
Without looking too much into details of the patch: what happens, if you are
already root? Does that work as expected?
I am asking, since we introduced regressions into Kate since using kauth to
save data with elevated privileges: Kate disallows running as
renatoo updated this revision to Diff 24605.
renatoo marked 3 inline comments as done.
renatoo added a comment.
Fixed typo
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9332?vs=23930=24605
REVISION DETAIL
https://phabricator.kde.org/D9332
AFFECTED FILES
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9599
To: davidedmundson, #plasma,
chinmoyr updated this revision to Diff 24603.
chinmoyr retitled this revision from "Add unit test" to "Add unit tests for
privilege excution in KIO".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.
Restricted Application added a project: Frameworks.
1.Removed all
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
Seems this needed changes, was pushed by mistake, then reverted and thus it
stayed in the "albert needs to review" state instead of the "david needs to do
changes" state.
chinmoyr updated this revision to Diff 24601.
chinmoyr added a comment.
Restricted Application added a project: Frameworks.
1.Replaced PrivilegeExecution flag
2.Made variable m_flags const again
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
chinmoyr updated this revision to Diff 24600.
chinmoyr added a comment.
Restricted Application added a project: Frameworks.
1.Removed PrivilegeExecution flag
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7270?vs=19183=24600
BRANCH
master
REVISION DETAIL
chinmoyr updated this revision to Diff 24599.
chinmoyr added a comment.
1.Made privilege execution default in BatchRenameJob.
2.Removed all occurences of PrivilegeExecution as job argument.
With these changes and the latest changes in
https://phabricator.kde.org/D6831 all the existing
chinmoyr updated this revision to Diff 24598.
chinmoyr added a comment.
1.Reassigned flag values for NoPrivilegeExecution and PrivilegeExecution. I
strongly feel that the latter won't be needed anymore.
2.Setting meta-data for unit test in the job itself (in
tryAskPrivilegeOpConfirmation).
chinmoyr updated this revision to Diff 24597.
chinmoyr added a comment.
1.Reassigned flag values for NoPrivilegeExecution and PrivilegeExecution. I
strongly feel that the latter won't be needed anymore.
2.Setting meta-data for unit test in the job itself (in
tryAskPrivilegeOpConfirmation).
habacker added a comment.
https://phabricator.kde.org/D9480 is for kdbusaddons repo, but we need at
least one review for kio using the new function in all related places. If
https://phabricator.kde.org/D9480 is submitted, I can discard all "... service
file must not have any path prefix on
chinmoyr updated this revision to Diff 24585.
chinmoyr added a comment.
1.Added check for unit test mode at beginning of put.
2.put was setting the wrong permissions because I initialized 'filemode' to 0
and did't update it. Now it is fixed.
3.Replaced file.setPermissions with
chinmoyr updated this revision to Diff 24583.
chinmoyr added a comment.
Changes:
1. Added method tryChangeAttr. This will call chown/chmod/utime in copy with
elevated privileges only during the brief period authorization is kept.
2.Added check for unit test mode at beginning of
chinmoyr updated this revision to Diff 24578.
chinmoyr added a comment.
1.Added method privilegeOperationUnitTestMode. This replaces the previous
block of code which
tested the validity of the KAuth action by looking up the action in *.policy
file. I think instead of looking
for some
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/16/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 02 Jan 2018 10:48:41 +
Build duration:
1 hr 0 min and counting
JUnit Tests
chinmoyr updated this revision to Diff 24577.
chinmoyr retitled this revision from "[RFC] Add support for sharing file
descriptor between KIO slave and KAuth helper" to "Add support for sharing file
descriptor between KIO slave and KAuth helper".
chinmoyr added a comment.
Fixed compilation
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/14/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 02 Jan 2018 10:19:01 +
Build duration:
54 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/24/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Tue, 02 Jan 2018 10:48:41 +
Build duration:
6 min 22 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/25/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
Date of build:
Tue, 02 Jan 2018 10:48:41 +
Build duration:
4 min 33 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/16/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
Date of build:
Tue, 02 Jan 2018 10:19:01 +
Build duration:
9 min 19 sec and counting
JUnit Tests
davidedmundson updated this revision to Diff 24569.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
replace tiny typo
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9599?vs=24565=24569
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
habacker marked 2 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D9482
To: habacker, dfaure, kfunk
Cc: #frameworks
habacker marked 6 inline comments as done.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D9480
To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks
habacker updated this revision to Diff 24564.
habacker added a comment.
- fixed doc
- check if absolute path on unix
- use cmake variable KDE_INSTALL_FULL_BINDIR
- renamed service file template
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
habacker updated this revision to Diff 24563.
habacker added a comment.
- remove trailing/bin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9482?vs=24345=24563
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9482
AFFECTED FILES
src/CMakeLists.txt
To: habacker,
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dfaure wrote in CMakeLists.txt:34
> Shouldn't that be ${KDE_INSTALL_FULL_BINDIR} instead?
Remove the /bin, it's part of KDE_INSTALL_FULL_BINDIR...
dfaure added a comment.
Let's discard this one and proceed with https://phabricator.kde.org/D9480
instead.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9423
To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:63
> + "KF5DBusAddonsMacros.cmake"
> + "dbus.service.in"
> DESTINATION "${CMAKECONFIG_INSTALL_DIR}"
This
34 matches
Mail list logo
