D8998: Add FindSeccomp to find-modules

davidk marked 2 inline comments as not done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8998 To: davidk, graesslin Cc: cgiboudeaux, #frameworks, #build_system

D8998: Add FindSeccomp to find-modules

davidk marked 8 inline comments as not done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8998 To: davidk, graesslin Cc: cgiboudeaux, #frameworks, #build_system

D8998: Add FindSeccomp to find-modules

davidk updated this revision to Diff 24751. davidk marked an inline comment as done. davidk added a comment. Fix remaining problems REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8998?vs=22958=24751 BRANCH master REVISION DETAIL

D9425: Fix 'Exec line in kioexecd service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9425 To: habacker, dfaure, bcooksley Cc: #frameworks

D9426: Fix 'Exec line in kssld service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9426 To: habacker, dfaure, bcooksley Cc: #frameworks

D9427: Fix 'Exec line in kpasswdserver service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9427 To: habacker, dfaure, bcooksley Cc: #frameworks

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks

D9428: Fix 'Exec line in kcookiejar service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9428 To: habacker, dfaure, bcooksley Cc: #frameworks

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker updated this revision to Diff 24739. habacker added a comment. - removed obsolate service template file REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9482?vs=24563=24739 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9482 AFFECTED

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. Rechecked after applying https://phabricator.kde.org/D9480 (with a minor cmake 3.5 fix, see https://phabricator.kde.org/R271:f316004e8a17360f667442abd6743644d9418216) without any issue, please accept. REVISION DETAIL https://phabricator.kde.org/D9482 To:

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

This revision was automatically updated to reflect the committed changes. Closed by commit R271:76aba6882ae3: Add cmake function kdbusaddons_generate_dbus_service_file (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9480?vs=24564=24738#toc REPOSITORY R271

Stepping down as KGlobalAccel and KWindowSystem maintainer after 5.42

Hi all, I had sent a mail some time ago asking for someone to step up as KGlobalAccel maintainer. I kept maintaining it as I didn't want to leave it in empty hands. But I feel the time is come for me that I am no longer able to maintain KGlobalAccel and as well KWindowSystem. Both are too

D7008: Don't export internal helper executables

This revision was automatically updated to reflect the committed changes. Closed by commit R246:2141e4215747: Dont export internal helper executables (authored by vkrause). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7008?vs=17409=24726 REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Jan 2018 16:54:39 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 04 Jan 2018 16:42:45 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/20/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Thu, 04 Jan 2018 16:42:45 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Jan 2018 16:42:45 + Build duration: 10 min and counting JUnit Tests Name:

D9656: Fix naming inconsistency

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8826e890dd44: Fix naming inconsistency (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland CHANGES SINCE LAST

D9656: Fix naming inconsistency

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9656 To: davidedmundson, #plasma,

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Thu, 04 Jan 2018 15:35:25 + Build duration: 6 min 59 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/16/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Jan 2018 15:35:25 + Build duration: 7 min 3 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 04 Jan 2018 15:35:25 + Build duration: 50 sec and counting JUnit Tests

D9286: don't multiply svg sizes by devicepixelratio

broulik added a comment. This fixes the gigantig scroll bars I had in plasmashell on X with 2x scaling. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9286 To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9656: Fix naming inconsistency

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#185897, @apol wrote: > Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether? The helpers are used by sonnet at build time, so to cross compile sonnet you need the helpers

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH arcpatch-D9480 REVISION DETAIL https://phabricator.kde.org/D9480 To: habacker, dfaure, kfunk Cc: cgiboudeaux, #frameworks

D7008: Don't export internal helper executables

vkrause added a comment. In https://phabricator.kde.org/D7008#185897, @apol wrote: > Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether? That works for me on Yocto, but in general this seems wrong, as target-sonnet will need to use

D7008: Don't export internal helper executables

apol added a comment. Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether? REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7008 To: vkrause, #frameworks, cordlandwehr, apol Cc: apol, sitter, sandsmark,

D7008: Don't export internal helper executables

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. This patch is correct, EXPORT is only useful if the target is used within cmake, AFAIU. Furthermore, we should modify sonnet to install these applications into LIBEXEC rather than bin,

D9593: Fix crash in setMainWindow on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9a46dd5199ee: Fix crash in setMainWindow on wayland (authored by fvogt). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9593?vs=24554=24706 REVISION DETAIL

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Jan 2018 11:51:34 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.9 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.9/23/ Project: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 04 Jan 2018 11:51:34 + Build duration: 1 min 52 sec and counting JUnit

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.7 Date of build: Thu, 04 Jan 2018 11:51:34 + Build duration: 1 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kdoctools kf5-qt5 FreeBSDQt5.9 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks kdoctools kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 04 Jan 2018 11:51:34 + Build duration: 51 sec and counting JUnit Tests

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.7 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.7 Date of build: Thu, 04 Jan 2018 11:38:09 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Jan 2018 11:38:09 + Build duration: 1 min 36 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.9 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.9/22/ Project: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 04 Jan 2018 11:38:09 + Build duration: 49 sec and counting CONSOLE

KDE CI: Frameworks kdoctools kf5-qt5 FreeBSDQt5.9 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.9/4/ Project: Frameworks kdoctools kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 04 Jan 2018 11:38:14 + Build duration: 42 sec and counting CONSOLE OUTPUT

D7430: Add unit tests for privilege excution in KIO

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Just missing a 'e' in "execution" in the commit log ;) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure Cc: ngraham,

D6831: Make use of kauth helper in methods of file ioslave

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > file.cpp:304 > +bool dirCreated; > +if (!(dirCreated = QDir().mkdir(path))) { > +if (auto err = execWithElevatedPrivilege(MKDIR, path)) { moving this to the line above would be simpler /

D9593: Fix crash in setMainWindow on wayland

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D9593 To: fvogt, graesslin, dfaure Cc: #frameworks