dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks for the fix. Looking at the reasoning in
https://phabricator.kde.org/R284:737a983febf4b44b5447c26d86eaedc624a8c35f the
added emit is definitely wrong, as the unittest proves. Please
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/68/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Fri, 12 Jan 2018 08:55:16 +
Build duration:
14 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/70/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Fri, 12 Jan 2018 08:55:16 +
Build duration:
12 min and counting
JUnit Tests
Name: (root)
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:205b69533bb5: Use cmake function
kdbusaddons_generate_dbus_service_file from kdbusaddons to…
(authored by habacker).
andreask added a comment.
add an real emblem-shared icon cause the existing one was a symbolic one for
gnome. should work now so +1
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9815
To: broulik, #frameworks, dfaure, andreask
Cc: apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:248941a0f4b4: Fix KFilePreviewGenerator::LayoutBlocker
(authored by fvogt).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9830?vs=25186=25201
REVISION DETAIL
fvogt added a comment.
In https://phabricator.kde.org/D9830#189776, @dfaure wrote:
> I certainly hope QListView doesn't trigger a nested event loop, that would
be horribly nasty and the cause for a million more problems (up to and
including crashes when closing the view/window while
dfaure added a comment.
I certainly hope QListView doesn't trigger a nested event loop, that would be
horribly nasty and the cause for a million more problems (up to and
including crashes when closing the view/window while this is happening). But
I'm assuming this is just a supposition,
dfaure added inline comments.
INLINE COMMENTS
> kdirwatch.cpp:721
> QFile::encodeName(e->path).data(), mask))
> >= 0) {
> +m_inotify_wd_to_entry[e->wd] = e;
> if (s_verboseDebug) {
.insert(e->wd, e) is a hair faster, says Effective STL Item
fvogt added a comment.
In https://phabricator.kde.org/D9830#189769, @dfaure wrote:
> Nice investigation and fix! Do you happen to know the actual change in Qt
which broke this? Wondering if it should 1) be mentioned in the commit log, 2)
lead to an #if QT_VERSION.
> But if it's just
dfaure accepted this revision.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9424
To: habacker, dfaure, bcooksley, apol
Cc: kfunk, vonreth, #windows, apol, #frameworks
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Nice investigation and fix! Do you happen to know the actual change in Qt
which broke this? Wondering if it should 1) be mentioned in the commit log, 2)
lead to an #if QT_VERSION.
But if
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/16/
Project:
Frameworks kdeclarative kf5-qt5 SUSEQt5.7
Date of build:
Fri, 12 Jan 2018 08:04:20 +
Build duration:
7 min 16 sec and counting
JUnit Tests
101 - 113 of 113 matches
Mail list logo
