KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 04:33:02 + Build duration: 42 min and counting JUnit

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Apr 2018 04:33:02 + Build duration: 9 min 45 sec and counting JUnit

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Apr 2018 04:33:02 + Build duration: 8 min 45 sec and counting JUnit

D11924: Add "SkipSwitcher" to API

This revision was automatically updated to reflect the committed changes. Closed by commit R278:6178ab9b4006: Add SkipSwitcher to API (authored by sharvey, committed by ngraham). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31330=31459

D11924: Add "SkipSwitcher" to API

ngraham added a comment. Ok, doing it now. REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

graesslin added a comment. In D11924#240631 , @ngraham wrote: > Martin, @sharvey does not yet have commit access. Would you like to land this patch for him, or should I? Please push, I probably won't get to it the next two weeks.

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/96/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 03:25:06 + Build duration: 44 min and counting

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 03:24:15 + Build duration: 35 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/121/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Apr 2018 03:25:06 + Build duration: 13 min and counting JUnit

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Apr 2018 03:24:15 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Apr 2018 03:24:15 + Build duration: 5 min 27 sec and counting JUnit Tests

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:251 > You can check if your output goes to a tty or is redirected: > https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlogging.cpp#n263 Hey, that's an IIFE! Never seen it in C++ before.

D11907: advancedqueryparsertest: Add more tests

michaelh retitled this revision from "advancedqueryparsertest: Add more test" to "advancedqueryparsertest: Add more tests". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 31438. michaelh added a comment. - Apply some sugested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=30714=31438 BRANCH sanitize-devices (branched from master) REVISION DETAIL

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:251 > You can check if your output goes to a tty or is redirected: > https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlogging.cpp#n263 That's great, thank you. I'll add some color to stdout in

D11452: sanitizer: Improve device listing

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:251 > +// TODO coloring would be nice, but "...|grep '^!'" does not work > with it. > +// out << QStringLiteral("%1").arg(dev.mounted ? "+" : "\033[1;31m!") > +out <<

D11826: Simplify Term operator&& and ||

michaelh added a comment. Oops, accepted it too quickly, forgot about the `failmessage`s. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun,

D11826: Simplify Term operator&& and ||

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham,

D11907: advancedqueryparsertest: Add more test

michaelh marked 5 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31428. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31390=31428 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL

D11826: Simplify Term operator&& and ||

bruns added a dependency: D11907: advancedqueryparsertest: Add more test. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

bruns added a dependent revision: D11826: Simplify Term operator&& and ||. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

bruns added inline comments. INLINE COMMENTS > michaelh wrote in databasesanitizer.cpp:333 > 8 meanings of MOOD acronym or abbreviation. > MOOD stands for > > Magic of Ordinary Days > Meet only Original Designs > Michigan Out of Doors > Movie Organizer Online Database > Miata Owners

D11907: advancedqueryparsertest: Add more test

bruns added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:235 > +<< Term{Term::And, QList{ > +Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}, > +Term{QStringLiteral(""), QStringLiteral("b"), Term::Contains}, `Term{QString(),

D11907: advancedqueryparsertest: Add more test

bruns added inline comments. INLINE COMMENTS > michaelh wrote in advancedqueryparsertest.cpp:255 > What about this one? Drop it? I think it should stay as it exercises the stack in the query parser Pseudocode: s[0] = a, AND s[1] = b, AND t = construct (c AND d) t = Term( s[1].term, t,

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

Zren added a reviewer: Breeze. Zren added a comment. Forgot to add reviewers. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5971 To: Zren, #breeze Cc: #frameworks, michaelh, ngraham

D11948: [KFileWidget] Hardcode example user name

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11948 To: broulik, #frameworks Cc: elvisangelaccio, michaelh, ngraham

D11924: Add "SkipSwitcher" to API

ngraham added a comment. Martin, @sharvey does not yet have commit access. Would you like to land this patch for him, or should I? REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein,

D11960: Support nvidia reset notifications in QtQuickViews

davidedmundson updated this revision to Diff 31400. davidedmundson added a comment. Shorter version REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11960?vs=31399=31400 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11960 AFFECTED

D11960: Support nvidia reset notifications in QtQuickViews

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D11960 To: davidedmundson, #plasma, hein Cc: #frameworks, michaelh, ngraham

D11960: Support nvidia reset notifications in QtQuickViews

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY In line with changes in Qt, we support

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:333 > Fair reason, the comment below is also mood then ... 8 meanings of MOOD acronym or abbreviation. MOOD stands for Magic of Ordinary Days Meet only Original Designs Michigan Out of Doors Movie

D11907: advancedqueryparsertest: Add more test

michaelh added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:255 > +; > +searchInput = QStringLiteral("(a AND (b AND (c AND d)))"); > +QTest::newRow(qPrintable(searchInput)) What about this one? Drop it? REPOSITORY R293 Baloo REVISION DETAIL

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31390. michaelh added a comment. - Remove duplicated data again REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31381=31390 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL

D11907: advancedqueryparsertest: Add more test

michaelh added a comment. With this D11826 makes a difference. In terms of comprehension I'm also almost there. `testNestedParentheses` still has some value as it tests nested parentheses more extensively than the one already there. Unless you have

D11826: Simplify Term operator&& and ||

michaelh added a comment. Regard this as accepted, but please see D11907 for landing sequence. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun,

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31381. michaelh added a comment. - Add (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D) REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31375=31381 BRANCH advancedqueryparsertest (branched from

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan updated this revision to Diff 31376. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10937?vs=28315=31376 REVISION DETAIL https://phabricator.kde.org/D10937 AFFECTED FILES icons-dark/applets/128/osd-duplicate.svg

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31375. michaelh added a comment. - Remove duplicated data REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31373=31375 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL

D11907: advancedqueryparsertest: Add more test

michaelh retitled this revision from "advancedqueryparsertest: Add optimization test" to "advancedqueryparsertest: Add more test". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich,

D11907: advancedqueryparsertest: Add optimization test

michaelh updated this revision to Diff 31373. michaelh added a comment. - Rename testOptimizedLogic - Add a different testOptimizedLogic REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31230=31373 BRANCH advancedqueryparsertest (branched from

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 47 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/47/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 05 Apr 2018 10:26:45 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 185 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/185/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 05 Apr 2018 10:29:47 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.9 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kinit kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Apr 2018 10:30:01 + Build duration: 2 min 34 sec and counting JUnit Tests Name:

D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d1660b637918: Make it possible for KTextEditor to build on Android NDKs gcc 4.9 (authored by apol). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D11888: Handle adjacent special characters correctly

michaelh added a comment. Apart from `QLatin1Char` and `token.isEmpty()` we're done, I think. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 31365. michaelh added a comment. - Correct typo(?) REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=30716=31365 BRANCH sanitize-enums (branched from master) REVISION DETAIL

D11948: [KFileWidget] Hardcode example user name

broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Don't create `KUser()` instance just for an example text in "What's This" mode. When logged in via LDAP this

D11945: Optimize AppArmor & SELinux highlighting and improve regex

nibags added a reviewer: dhaumann. nibags added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann Cc: #frameworks, michaelh, genethomas, ngraham, cullmann, vkrause, dhaumann

D11745: databasesanitizer: Use flags for filtering

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.h:41 > Is this correct? IgnoreMounted = (1 << 1) = 2 == IgnoreUnavailable? That's a sneaky question! :-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo,

D11945: Optimize AppArmor & SELinux highlighting and improve regex

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Some optimizations are made (some suggested from D10621 ) and