KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/94/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 03 May 2018 03:39:46 + Build duration: 33 min and counting JUnit Tests Name: (root)

D12648: Update mount point after mount operations

davidedmundson added a comment. > There is still no guarantee the method return is equivalent/isochronous with the property change. Sure there is. We know udisks has completely finished mounting a filesystem, therefore we know udisks property about whether the file system is mounted

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. tundracomp requested review of this revision. REVISION SUMMARY Usage of Phonon is already optional in the source code; this commit updates the CMake file

D12648: Update mount point after mount operations

bruns added a comment. In D12648#257365 , @davidedmundson wrote: > Let me clarify > > At the time of the return from udisks the property on udisks is updated but the signal saying the property is updated is not yet sent, as solid caches

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added a comment. I see your point @rkflx, but I think it's a mistake to use an icon whose appearance suggests that it represents state when in fact it doesn't--that's the kind of thing that causes the misconception. Since ascending alphabetical order is one of the available states,

D12659: two new UDS structures

bruns added inline comments. INLINE COMMENTS > udsentry_benchmark.cpp:483 > +inline Field(const uint index, long long value = 0) : m_long(value), > m_index(index) {} > +// This operator is essential to gain some speed, because the > default == is slow > +inline bool

D12320: {RFC] add ability to read embedded cover files

mgallien added a comment. Thanks for your work. Please find a few remarks inline. INLINE COMMENTS > embeddedimagedata.h:25 > +#include "kfilemetadata_export.h" > +#include > + You can do a forward declaration of QMimeDatabase because it is only referred through a reference. >

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, LGTM now. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:1888 > The problem conceptually is that `view-sort-ascending` is semantically > inaccurate for anything but ascending

D12662: Add InlineNoteInterface

michalsrb added a comment. In D12662#257342 , @brauch wrote: > Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there? No

D12648: Update mount point after mount operations

davidedmundson added a comment. Let me clarify At the time of the return from udisks the property on udisks is updated but the signal saying the property is updated is not yet sent, as solid caches properties we have a wrong value locally but udisks has the correct value remotely

D12392: Fix the "Default" color scheme to match Breeze again

ngraham added a comment. The user already has to create a named color scheme if he wants to actually //save and use// his modifications. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: cfeck, abetts, #frameworks,

D12662: Add InlineNoteInterface

brauch added a comment. Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there? Some things which come to my mind for testing would be: - is selection rendered correctly

D12392: Fix the "Default" color scheme to match Breeze again

cfeck added a comment. "Current" could be named "Unnamed" or "Unsaved". It cannot be removed, unless you want to force the user to always create a named color scheme when he does modifications. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To:

D12662: Add InlineNoteInterface

michalsrb added a comment. Here are screenshots from the sample plugin: F5831086: txt.png F5831085: cpp.png F5831084: qml.png The plugin provides notes that are just

D12392: Fix the "Default" color scheme to match Breeze again

ngraham added a comment. "Current" is whatever the current theme is and can be ignored (and hopefully gotten rid of in the future). The issue here is that "Default" is //supposed to// be identical to "Breeze", but it's currently not. This patch fixes that. REPOSITORY R265 KConfigWidgets

D12659: two new UDS structures

jtamate updated this revision to Diff 33507. jtamate added a comment. Another way to improve insertion speed in release could be: Transform "insert" to really insert only, with ASSERTS if it used as "replaceOrInsert" and add new methods "replaceOrInsert". The measurements in the first

D12392: Fix the "Default" color scheme to match Breeze again

abetts added a comment. Just trying to understand. What is happening here is that we have 3 color schemes that are all theoretically the same as Breeze. However, the "default" and "Breeze" scheme are currently not the same. Therefore, we have to make sure that they are. If that's the case

D12392: Fix the "Default" color scheme to match Breeze again

ngraham added a comment. Friendly ping! REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns

D12016: [ktexteditor] much faster positionFromCursor

anthonyfieroni added a comment. In D12016#257325 , @jtamate wrote: > Do you mean to extend KateViewInternal in such a way that positionFromCursor in KateViewAccessible becomes unnecessary? Yes, mainly it should be a tiny helper.

D12016: [ktexteditor] much faster positionFromCursor

jtamate added a comment. In D12016#257324 , @anthonyfieroni wrote: > Maybe i miss something, but i think if something should be extended it's view not accessible. Do you mean to extend KateViewInternal in such a way that

D12016: [ktexteditor] much faster positionFromCursor

anthonyfieroni added a comment. Maybe i miss something, but i think if something should be extended it's view not accessible. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #frameworks Cc: anthonyfieroni, mwolff, brauch,

D12388: Output device color curves correction

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please increase the versions. INLINE COMMENTS > output-management.xml:82 > > > please increment version > output-management.xml:142 > > + > +

D12659: two new UDS structures

jtamate updated this revision to Diff 33505. jtamate marked 3 inline comments as done. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Fixed the ordered insertion. Using std::vector and std::find_if. Initialize

D12648: Update mount point after mount operations

bruns added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:170 > +m_device->invalidateCache(); > m_device->broadcastActionDone("setup"); > This replaces one race condition with another (less likely) one. There is no guarantee the property is already

D12659: two new UDS structures

bruns added inline comments. INLINE COMMENTS > udsentry_benchmark.cpp:467 > +inline Field(const uint index, long long value = 0) : m_long(value), > m_index(index) { } > +// This operator is essential to gain some speed, because the > default == is slow > +inline bool

D12659: two new UDS structures

bruns added a comment. In D12659#257294 , @dfaure wrote: > In D12659#257292 , @bruns wrote: > > > In D12659#257098 , @dfaure wrote: > > > > > Thanks

D12659: two new UDS structures

jtamate marked 9 inline comments as done. jtamate added a comment. > If anyone attempts this, please name the struct and its members, don't use QPair ;-) > But no, that cannot possibly be faster. QVariant has lots of overhead itself. I've tried, just before reading your comment :-)

D12662: Add InlineNoteInterface

brauch added a comment. Awesome idea! Do you have a screenshot of how it looks? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: michalsrb, #ktexteditor Cc: brauch, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12659: two new UDS structures

dfaure added a comment. In D12659#257292 , @bruns wrote: > In D12659#257098 , @dfaure wrote: > > > Thanks for that investigation. Interesting that linear search is faster than binary search in the

D12659: two new UDS structures

bruns added a comment. In D12659#257098 , @dfaure wrote: > Thanks for that investigation. Interesting that linear search is faster than binary search in the same data structure... maybe the compiler optimizes it better? Did you profile V2 to

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/150/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 02 May 2018 15:34:29 + Build duration: 14 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 02 May 2018 15:34:29 + Build duration: 4 min 9 sec and counting

D12438: Fix PlasmaCalendar widget to not mark days with minor events

This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R242:67f5ad29e8e6: Fix PlasmaCalendar widget to not mark days with minor events (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES

D12438: Fix PlasmaCalendar widget to not mark days with minor events

kossebau marked an inline comment as done. kossebau added inline comments. INLINE COMMENTS > broulik wrote in daysmodel.cpp:223 > `std::find_if` Tried, but seems there is no simple way to use std::find_if or std::any_of algorithms here for the usecase of checking all values for a given key in

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added inline comments. INLINE COMMENTS > kdiroperator.cpp:1887 > KActionMenu *sortMenu = new KActionMenu(i18n("Sorting"), this); > +sortMenu->setIcon(QIcon::fromTheme(QStringLiteral("itemize"))); > +sortMenu->setDelayed(false); Before the patch lands, this icon will be

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham marked 8 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham marked 6 inline comments as done. ngraham added inline comments. INLINE COMMENTS > rkflx wrote in kdiroperator.cpp:1888 > While we agreed upon wanting a better icon, until that's done I'd prefer > `view-sort-ascending` instead. For me, `itemize` has no connection to sorting > at all,

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham updated this revision to Diff 33498. ngraham added a comment. Revert accidental merge, and simplify the single-click menu activation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=33464=33498 BRANCH arcpatch-D12337 REVISION DETAIL

D12662: Add InlineNoteInterface

michalsrb added a comment. This is my first attempt to propose such API, it may not be ideal. If the inline note is placed into text, the space for it is created using QTextCharFormat's absolute spacing between the two letters. I admit it is quite a misuse, but it was the least

D12662: Add InlineNoteInterface

michalsrb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: michalsrb, #ktexteditor Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12662: Add InlineNoteInterface

michalsrb created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. michalsrb requested review of this revision. REVISION SUMMARY The inline note interface provides a way to render arbitrary things in the text. The

D12648: Update mount point after mount operations

This revision was automatically updated to reflect the committed changes. Closed by commit R245:d735708ff11c: Update mount point after mount operations (authored by davidedmundson). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12648?vs=33460=33488 REVISION

D12648: Update mount point after mount operations

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D12648 To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh, bruns

D12648: Update mount point after mount operations

mart accepted this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D12648 To: davidedmundson, #plasma, broulik, mart Cc: #frameworks, michaelh, bruns

D12439: Add EventDataDecorator::hasEndDateTime()

kossebau abandoned this revision. kossebau added a comment. Seems code out there is already relying on `!isNaN(datetime)` so let's do the same for now. Besides, there can be events with also only end-date, so the same check would be needed for the start date, thus this API would be

D12439: Add EventDataDecorator::hasEndDateTime()

broulik added a comment. `!isNaN(endDateTime.getTime())`? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12439 To: kossebau, #plasma Cc: broulik, #frameworks, michaelh, bruns

D12438: Fix PlasmaCalendar widget to not mark days with minor events

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > DayDelegate.qml:105 > Loader { > -active: model.containsEventItems !== undefined && > model.containsEventItems > +active: model.containsMajorEventItems !== undefined && >

D12438: Fix PlasmaCalendar widget to not mark days with minor events

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. address comment then ship it INLINE COMMENTS > daysmodel.cpp:223 > +auto it = m_eventsData.find(date); > +while (it != m_eventsData.end() && it.key() == date) { > +if

D12659: two new UDS structures

dfaure added a comment. Thanks for that investigation. Interesting that linear search is faster than binary search in the same data structure... maybe the compiler optimizes it better? Did you profile V2 to find out where the time is spent, or do you have a better explanation? But even if

k18n 5.45 update

Could we get a .1 update to k18n to include this fix? https://cgit.kde.org/ki18n.git/commit/?id=9c32bdab29b345976eee3b9c1c4bebd76cdcdde2 https://phabricator.kde.org/D12216 It is causing issue with some packager of plasma-workspace 5.12.5 Jonathan

D12659: two new UDS structures

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The two new UDS structures are similar to Frank's, but instead of using two vectors, use only one, with

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

rkflx added inline comments. INLINE COMMENTS > kdiroperator.cpp:1888 > d->actionCollection->addAction(QStringLiteral("sorting menu"), > sortMenu); > +sortMenu->setIcon(QIcon::fromTheme(QStringLiteral("itemize"))); > While we agreed upon wanting a better icon, until that's done I'd

D12647: Move the inline preview button into the menu

rkflx added a comment. In T8552#140332 , @rkflx wrote: > > moving the Show Preview button to the menu > > Makes sense to me, but might be controversial with others. FWIW, if people do not like this (e.g. because they often toggle

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Wed, 02 May 2018 07:30:37 + Build duration: 9 min 10 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 02 May 2018 07:30:37 + Build duration: 3 min 57 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 02 May 2018 07:30:37 + Build duration: 2 min 0 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 81 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/81/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 02 May 2018 07:30:37 + Build duration: 1 min 45 sec and counting JUnit