D12388: Output device color curves correction

zzag added inline comments. INLINE COMMENTS > zzag wrote in outputconfiguration_interface.cpp:221 > constify wl_array? > constify pos, e.g. `uint16_t const *pos`? You can resize v and call memcpy (or use std::copy?) REPOSITORY R127 KWayland REVISION DETAIL

D12689: Lua: updated for Lua5.3

jpoelen created this revision. jpoelen added reviewers: dhaumann, Framework: Syntax Highlighting. jpoelen added projects: Framework: Syntax Highlighting, Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Add of: -

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f57c4bc27b81: Avoid infinite loops when fetching the URL from DocumentUrlDB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12335?vs=32528=33589

D12662: Add InlineNoteInterface

brauch added a comment. Oh, heh, yes it does. It's just your docstring which says otherwise ("is an interface for the View"), and that's what I looked at at that time. That should be changed. ;) I think the question is less what you need and more what it is supposed to do semantically.

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 153 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/153/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 03 May 2018 22:16:28 + Build duration: 3 min 37 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 03 May 2018 22:16:28 + Build duration: 2 min 41 sec and counting

D12388: Output device color curves correction

zzag added a comment. const uint16_t *pos = (uint16_t*)array->data; Well, now you throw away const qualifiers. I think it should be something like this const uint16_t *pos = reinterpret_cast(array->data); I suggest to get rid of C style casts because they aren't checked by

D12077: Show view mode buttons in the open/save dialog's toolbar

abetts added a comment. It would be cool if we could introduce it in this release and polish a lot for the next release. I give it a +1. @ngraham ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: elvisangelaccio,

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: elvisangelaccio, cfeck, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: elvisangelaccio, cfeck, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 33582. ngraham added a comment. Wrap filenames in tags REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=33580=33582 BRANCH prettier-trach-and-delete-dialogs-for-single-items (branched from master) REVISION

D12077: Show view mode buttons in the open/save dialog's toolbar

elvisangelaccio added a comment. So, are we going to revert this? Tagging is in two days... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: elvisangelaccio, sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

elvisangelaccio added inline comments. INLINE COMMENTS > jobuidelegate.cpp:230 > +widget, > +xi18nc("@info", "Do you really want to > permanently delete this item?%1This > action cannot be undone.", prettyList.first()), > +

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 33580. ngraham added a comment. Fix the prior change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=33576=33580 BRANCH prettier-trach-and-delete-dialogs-for-single-items (branched from master) REVISION DETAIL

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham added a comment. Urg, I need to turn my brain on... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: cfeck, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

cfeck added a comment. Sorry, no. I really meant %1? -> %1. The other question mark was okey. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: cfeck, michaelh, bruns

Re: QStandardPaths::GenericDataLocation on MacOS

On Thursday May 03 2018 21:57:03 Thomas Friedrichsmeier wrote: > _If_ applications were to actually install to the current paths defined > for that on Mac "Library/Application Support", and "~Library/Application > Support", on more, no less, _then_ clashes would start to happen. As A priori no,

D12156: implement reading of rating tag

bruns added a comment. In D12156#254055 , @astippich wrote: > In D12156#252575 , @mgallien wrote: > > > If I have correctly understood the ideas behind the conception of Baloo, we should probably

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: cfeck, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 33576. ngraham added a comment. ? -> : REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=33571=33576 BRANCH prettier-trach-and-delete-dialogs-for-single-items (branched from master) REVISION DETAIL

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added a comment. I used the web interface and I wasn't able to find the „Update Diff“ button (why not update patch or update commit?) in the right box until now. It should be fixed now. REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: ltoscano,

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp updated this revision to Diff 33575. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12674?vs=33526=33575 REVISION DETAIL https://phabricator.kde.org/D12674 AFFECTED FILES CMakeLists.txt To: tundracomp Cc: ltoscano, cgiboudeaux, #frameworks, michaelh, bruns

D12511: optimization of KTextEditor::DocumentPrivate::views()

jtamate updated this revision to Diff 33574. jtamate added a comment. You are right, there is no change to m_views there. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12511?vs=33047=33574 REVISION DETAIL https://phabricator.kde.org/D12511 AFFECTED

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ltoscano added a comment. If you want to update the patch on phabricator, just apply it locally with `arc patch Dxyzt`, amend the git commit as usual (maybe also rebase on master if needed), and use `arc diff` again. REPOSITORY R289 KNotifications REVISION DETAIL

Re: QStandardPaths::GenericDataLocation on MacOS

Hi, > On Fri, May 4, 2018 at 2:38 AM, Thomas Friedrichsmeier > wrote: >> Hi, >> >> On Thu, 03 May 2018 16:01:46 +0200 >> René J.V. Bertin wrote: >>> On Thursday May 03 2018 15:19:33 Thomas Friedrichsmeier wrote: >>> >plan is

D12016: [ktexteditor] much faster positionFromCursor

cullmann added a comment. Actually, given the functionality is only used there, if that code is in the view or in that helper class makes no real difference, or? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #frameworks Cc:

D12511: optimization of KTextEditor::DocumentPrivate::views()

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12511 To: jtamate, #kate, cullmann Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D12511: optimization of KTextEditor::DocumentPrivate::views()

cullmann added a comment. If you have benchmark results for that, I have no issues with the idea. Thought I think you only need to update the cache in add/removeView, not in KTextEditor::DocumentPrivate::createView REPOSITORY R39 KTextEditor REVISION DETAIL

D12662: Add InlineNoteInterface

cullmann added a comment. > Oh, good point by the way: Are you sure this should be an interface to a *view*? Maybe it should instead be attached to the document? I'm not sure, I just want to bring the discussion up. Actually, I think view might make sense, as you only mess with the

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

cfeck added inline comments. INLINE COMMENTS > jobuidelegate.cpp:230 > +widget, > +xi18nc("@info", "Do you really want to > permanently delete this item?%1?This > action cannot be undone.", prettyList.first()), > +

Re: QStandardPaths::GenericDataLocation on MacOS

>On Fri, May 4, 2018 at 2:38 AM, Thomas Friedrichsmeier >> homebrew, craft). It is also about the fact that this installation >> option causes problems, e.g. if users are to mix MacPorts and a >> single-app-bundled KF5 app No, that shouldn't happen, and it doesn't with the official Kate bundle.

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: cfeck, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 33571. ngraham added a comment. Put filename on a new line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=33552=33571 BRANCH prettier-trach-and-delete-dialogs-for-single-items (branched from master) REVISION

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:68 > there are no component, why do you use this keyword ? removing 'REQUIRED' was > enough I added this keyword because Qt5TTS has it too. Anyways, how do I *update* a patch on this thing? Do I just use

D12156: implement reading of rating tag

astippich added a comment. ping @mgallien REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12578: fix some issues reported by clazy

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo, #frameworks, bruns Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

Re: QStandardPaths::GenericDataLocation on MacOS

On Fri, May 4, 2018 at 2:38 AM, Thomas Friedrichsmeier wrote: > Hi, > > On Thu, 03 May 2018 16:01:46 +0200 > René J.V. Bertin wrote: >> On Thursday May 03 2018 15:19:33 Thomas Friedrichsmeier wrote: >> >plan is actually to get David

D12662: Add InlineNoteInterface

brauch added a comment. I think fixing the selection rendering issue would be nice. Regarding blockmode behaviour, I think it will be a bit strange either way. One thing to compare is the behaviour with non-fixed width fonts: there block mode also selects constant columns (i.e. it will

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham planned changes to this revision. ngraham added a comment. That makes a lot of sense, Christoph. I'll do that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: cfeck, michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

cfeck added a comment. Maybe even mimic the old list but not using a separate widget: Do you really want to move this item to the trash? /my/path/file.txt Warning blabla Move to Trash | Cancel REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12422 To:

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

cfeck added a comment. I agree it looks nicer, but the actual file that is being deleted now is somewhat hidden in a text. I think it's the most important information the user wants to read (did I select the right file for deletion?). Could the file be made more prominent, e.g. starting at

D12388: Output device color curves correction

romangg updated this revision to Diff 33564. romangg added a comment. Increase org_kde_kwin_outputmanagement version as well (needed to create config objects of version 2) REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33563=33564 BRANCH

Re: QStandardPaths::GenericDataLocation on MacOS

Hi, I'll just answer a few select points, because, yes I am aware this has a tiny bit of a history, and I don't want to see a repeat. The master plan is actually to get David Faure to champion a solution (whichever one) into Qt. So before getting lost in the detail of the various approaches, I'd

Re: QStandardPaths::GenericDataLocation on MacOS

Hi, On Thu, 03 May 2018 16:01:46 +0200 René J.V. Bertin wrote: > On Thursday May 03 2018 15:19:33 Thomas Friedrichsmeier wrote: > >plan is actually to get David Faure to champion a solution (whichever > >one) into Qt. > > I can be wrong, but I don't see that happening

D12388: Output device color curves correction

romangg marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks, davidedmundson, graesslin Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns

D12388: Output device color curves correction

romangg updated this revision to Diff 33563. romangg added a comment. - Use const size_t instead of int - Remove struct keyword on function calls - More const keyword - memcpy in sendColorCurves REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D12388: Output device color curves correction

zzag added inline comments. INLINE COMMENTS > outputdevice.cpp:321 > + > +auto setCurve = [](struct wl_array *curve, QVector > *destination) { > +destination->resize(curve->size / sizeof(uint16_t)); That's not C so you can get rid of `struct` keyword. ;-) Also, you could constify

D12388: Output device color curves correction

romangg updated this revision to Diff 33554. romangg added a comment. Rebase on current master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33551=33554 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL

D12388: Output device color curves correction

zzag added inline comments. INLINE COMMENTS > outputconfiguration.cpp:180 > +wl_array_init(dest); > +int memLength = sizeof(uint16_t) * origin.size(); > +void *s = wl_array_add(dest, memLength); You forgot `const`. :-D Also, I would use `size_t` instead of `int`.

D12388: Output device color curves correction

romangg marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks, davidedmundson, graesslin Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/152/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 03 May 2018 14:25:27 + Build duration: 10 min and counting JUnit

D12388: Output device color curves correction

romangg updated this revision to Diff 33551. romangg added a comment. - Fix protocol versions, events/requests order REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33453=33551 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 33552. ngraham added a comment. Use two line break REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=33075=33552 BRANCH prettier-trach-and-delete-dialogs-for-single-items (branched from master) REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/4/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 03 May 2018 14:25:27 + Build duration: 2 min 15 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 151 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/151/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 03 May 2018 14:11:57 + Build duration: 12 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 03 May 2018 14:11:57 + Build duration: 4 min 36 sec and counting

D12680: Fix not shown event marker in calendar with air & oxygen themes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f36905878b08: Fix not shown event marker in calendar with air oxygen themes (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: QStandardPaths::GenericDataLocation on MacOS

On Thursday May 03 2018 15:19:33 Thomas Friedrichsmeier wrote: Hi, >plan is actually to get David Faure to champion a solution (whichever >one) into Qt. I can be wrong, but I don't see that happening beyond his general support. Also, what are the chances that this will be overhauled anyway for

D12680: Fix not shown event marker in calendar with air & oxygen themes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH removeoutdatedcalendarsvgz REVISION DETAIL https://phabricator.kde.org/D12680 To: kossebau, #plasma, mart, broulik Cc: #frameworks, michaelh, bruns

D12680: Fix not shown event marker in calendar with air & oxygen themes

kossebau retitled this revision from "Remove outdated calendar.svgz from air & oxygen themes" to "Fix not shown event marker in calendar with air & oxygen themes". kossebau edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D12680: Remove outdated calendar.svgz from air & oxygen themes

kossebau added a comment. Compare commit 1eff0dea which updated only the default Breeze theme. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12680 To: kossebau,

D12680: Remove outdated calendar.svgz from air & oxygen themes

kossebau created this revision. kossebau added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Still contained only the Plasma4 area calendar

Re: QStandardPaths::GenericDataLocation on MacOS

On Thursday May 03 2018 22:22:30 Ben Cooksley wrote: Hi, > Last time around the Qt Core maintainer vetoed our attempts to get > this changed, and forced us to liase with a Qt Company employee whose > responsiveness was lacking (to say the least). Suffice to say, that > effectively killed the

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/95/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 03 May 2018 10:09:41 + Build duration: 15 min and counting JUnit Tests Name: (root)

Re: QStandardPaths::GenericDataLocation on MacOS

On Thu, May 3, 2018 at 8:02 PM, Thomas Friedrichsmeier wrote: > Hi! Hi all, > > Quick summary, first: > KF5 relies on storing data in QStandardPaths::GenericDataLocation, but > that location is problematic on Mac because it refers to absolute, >

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 247 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/247/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 03 May 2018 10:09:42 + Build duration: 6 min 24 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/4/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 03 May 2018 10:09:42 + Build duration: 4 min 56 sec and counting JUnit Tests Name:

D12385: Thumbnail smooth scaling in filepicker

anemeth closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

QStandardPaths::GenericDataLocation on MacOS

Hi! Quick summary, first: KF5 relies on storing data in QStandardPaths::GenericDataLocation, but that location is problematic on Mac because it refers to absolute, non-customizable system paths, only. We'd like to avoid patching Qt, so we are looking to come up with a solution that has a chance

Re: QStandardPaths::GenericDataLocation on MacOS

On Thursday May 03 2018 10:02:35 Thomas Friedrichsmeier wrote: Hi, I have mostly skimmed over your long email but allow me to warn you firsthand that I've tried to get feedback and constructive collaboration like this before and never got very far because the prevailing attitude is 1) don't

D12513: CVE-2018-10361: privilege escalation

mgerstner added a comment. In D12513#256845 , @aacid wrote: > @mgerstner I don't really understand why we need the chdir, renameat, etc. > > Dropping privileges to the minimum needed should be enough, shouldn't it? > > I mean at that

D12659: two new UDS structures

jtamate updated this revision to Diff 33543. jtamate marked 13 inline comments as done. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. I've included some methods that will be needed if AnotherUDSEntry replaces the current

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:68 > > -find_package(Phonon4Qt5 4.6.60 REQUIRED NO_MODULE) > +find_package(Phonon4Qt5 4.6.60 OPTIONAL_COMPONENTS NO_MODULE) > set_package_properties(Phonon4Qt5 PROPERTIES there are no component, why do you use this keyword ?

D12659: two new UDS structures

dfaure added a comment. I like the replaceOrInsert idea, and the assert in insert... we might have to fix some kioslaves, but in general they have no good reason to insert twice for the same key. In general I like the std::vector + find_if + emplace_back solution. Fast and readable.