D12696: Use the new uds implementation

dfaure added a comment. First line of commit log should have changelog in mind, so more context needed. Maybe rather something like "KIO::UDSEntry: switch to a single std::vector for more performance". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate,

D12696: Use the new uds implementation

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good. INLINE COMMENTS > udsentry.cpp:45 > +inline Field(const uint index, long long value = 0) : m_long(value), > m_index(index) {} > +// This operator

D7415: kconfig: kcfg.xsd do not require a kcfgfile

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. It helps if you actually add reviewers... REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz, dfaure Cc: dfaure, #frameworks, michaelh, ngraham,

D12728: KFileItemActions: fallback to default mimetype when selecting only files

dfaure added a comment. Makes sense, but why not do this in KFileItemListProperties::mimeType()? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12728 To: elvisangelaccio, #frameworks, dfaure Cc: michaelh, ngraham, bruns

D12727: Introduce KFileItemListProperties::isFile()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kfileitemprops-isfile (branched from master) REVISION DETAIL https://phabricator.kde.org/D12727 To: elvisangelaccio, #frameworks, dfaure Cc: michaelh, ngraham, bruns

D12569: Pony: fix identifier and keyword

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ec6486460a6a: Pony: fix identifier and keyword (authored by jpoelen2, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D12569: Pony: fix identifier and keyword

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good, will integrate. REPOSITORY R216 Syntax Highlighting BRANCH fix_pony REVISION DETAIL https://phabricator.kde.org/D12569 To: jpoelen, dhaumann Cc: #frameworks,

D12689: Lua: updated for Lua5.3

dhaumann closed this revision. dhaumann added a comment. Committed, see https://commits.kde.org/syntax-highlighting/9f11b4fa2604c02e9a15f1949a8455283e9c0d62 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12689 To: jpoelen, dhaumann,

D12662: Add InlineNoteInterface

dhaumann added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.cpp:5316-5320 > This look like premature optimization. I would prefer to delete this "common > cases first" block. Except if this turned out to be a bottleneck already? Btw, may I am wrong here, since this is

D12662: Add InlineNoteInterface

dhaumann added a comment. This is already an excellent patch. The API documentation is already really nice. I have some minor suggestions (see inline comments in patch). Besides that, I wonder whether this should really be a View extension interaface. Currently, this interface is

D12727: Introduce KFileItemListProperties::isFile()

elvisangelaccio added a dependent revision: D12728: KFileItemActions: fallback to default mimetype when selecting only files. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12727 To: elvisangelaccio, #frameworks, dfaure Cc: michaelh, ngraham, bruns

D12728: KFileItemActions: fallback to default mimetype when selecting only files

elvisangelaccio added a dependency: D12727: Introduce KFileItemListProperties::isFile(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12728 To: elvisangelaccio, #frameworks, dfaure Cc: michaelh, ngraham, bruns

D12728: KFileItemActions: fallback to default mimetype when selecting only files

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. elvisangelaccio requested review of this revision. REVISION SUMMARY KFileItemListProperties::mimeType() returns an empty string if the selected files

D12727: Introduce KFileItemListProperties::isFile()

elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. elvisangelaccio requested review of this revision. REVISION SUMMARY This method can be used to check whether a list of selected URLs contains only

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/105/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 May 2018 18:23:15 + Build duration: 6 min 6 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 256 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/256/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 06 May 2018 18:23:15 + Build duration: 5 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 06 May 2018 18:23:15 + Build duration: 4 min 49 sec and counting JUnit Tests

D12328: Enable preview by default in the filepicker dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bec7f9d6a1ef: Enable preview by default in the filepicker dialog (authored by anemeth). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=33167=33717 REVISION

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 255 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/255/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 06 May 2018 16:11:34 + Build duration: 58 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 06 May 2018 16:11:34 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/104/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 May 2018 16:11:34 + Build duration: 4 min 45 sec and counting JUnit Tests Name:

D12321: Hide file preview when icon is too small

anemeth closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 06 May 2018 10:42:50 + Build duration: 2 min 33 sec and counting JUnit

KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks kdeclarative kf5-qt5 SUSEQt5.10 Date of build: Sun, 06 May 2018 10:42:51 + Build duration: 1 min 48 sec and counting JUnit Tests

D12077: Show view mode buttons in the open/save dialog's toolbar

elvisangelaccio added a comment. In D12077#258637 , @rkflx wrote: > One more idea: Would it make sense to land each part of the rework on a dedicated rework branch first, and only once everything fits together (both in design and

D12291: Accept file descriptor only from root owned process

ossi added a comment. as i certainly mentioned somewhere else already, this is redundant with putting the socket in a safe place. but fair enough ... INLINE COMMENTS > fdreceiver.cpp:67 > if (client > 0) { > -FDMessageHeader msg; > -if (::recvmsg(client, msg.message(),

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 06 May 2018 09:27:27 + Build duration: 7 min 22 sec and counting JUnit Tests Name:

D10273: Create proper SocketAddress

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. note that there are also unaddressed comments from previous rounds. INLINE COMMENTS > sharefd_p.h:50 > { > -return reinterpret_cast(); > +return

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 05 May 2018 14:55:58 + Build duration: 18 hr and counting JUnit Tests Name: (root)

D10409: In linux don't use abstract socket to share file descriptor

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. still needs update REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. One more idea: Would it make sense to land each part of the rework on a dedicated rework branch first, and only once everything fits together (both in design and implementation) merge that branch to master? This would avoid huge dependency stacks as well as the