D12756: [KDateTable] Use a more visible red color

ngraham added a comment. In D12756#259691 , @mwolff wrote: > Let's try to fix the bug for real, instead of implementing half-baked workarounds that only work for the default configurations. > > Alternative ideas: add setters for the two

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Wed, 09 May 2018 01:29:56 + Build duration: 3 min 32 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/82/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 09 May 2018 01:29:56 + Build duration: 3 min 33 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 09 May 2018 01:29:55 + Build duration: 3 min 25 sec and counting JUnit

D12768: Allow wrapping selection off top/bottom of autocomplete results

sraizada added a project: KTextEditor. sraizada added a subscriber: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: sraizada, #ktexteditor Cc: #ktexteditor, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk,

D12768: Allow wrapping selection off top/bottom of autocomplete results

sraizada created this revision. sraizada added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. sraizada requested review of this revision. REVISION SUMMARY When at the first autocomplete result, pressing up

D12765: Use a more intuitive, user-friendly name for Samba share access

elvisangelaccio added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham updated this revision to Diff 33844. ngraham added a comment. Add the protocol acronym to help tech-savvy users know what they're looking at REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12765?vs=33840=33844 BRANCH

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham added a comment. Sounds good to me! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

ltoscano added a comment. or "Shared folders (SMB)", as the protocol is probably more relevant. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg Cc: ltoscano, elvisangelaccio

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham added a comment. "Shared folders (Samba)"? Then again, I doubt that people who know what Samba is will have difficulty figuring out that "Shared folders" under the "Network" Place is where Samba shares live. REPOSITORY R320 KIO Extras REVISION DETAIL

D12765: Use a more intuitive, user-friendly name for Samba share access

elvisangelaccio added a comment. If we remove Samba, how do people who know Samba find where Samba is? Maybe we can use "Samba Shared Folders" ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg Cc:

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12765 To: ngraham, #frameworks, #dolphin, #vdg

D12765: Use a more intuitive, user-friendly name for Samba share access

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, VDG. ngraham requested review of this revision. REVISION SUMMARY "Samba shares" is a jargonistic term that won't mean much to most people. This patch replaces it with a more intuitive and user-friendly term. BUG:

D12756: [KDateTable] Use a more visible red color

mwolff added a comment. Let's try to fix the bug for real, instead of implementing half-baked workarounds that only work for the default configurations. Alternative ideas: add setters for the two possible cell text colors, then somehow set the KColorScheme color from the outside.

D12756: [KDateTable] Use a more visible red color

ngraham added a comment. That would change the color to something different (e.g. with the Breeze themes, it's blue). If we're okay with that I can do it, but I was trying to produce as minimal a patch as possible. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D12756: [KDateTable] Use a more visible red color

mwolff added a comment. Maybe instead use the HighlightText QPalette color? Hardcoding red may work for the two styles you present, but I could just set the view background to red and the text becomes unusable. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 33831. chinmoyr added a comment. Used qPrintable() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33820=33831 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 AFFECTED FILES

D12756: [KDateTable] Use a more visible red color

ngraham added a comment. We can't because `KWidgetsAddons` is a tier 1 framework and can't rely on any other frameworks, and the positive/negative colors come from `KColorScheme` rather than anywhere in Qt. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D12756: [KDateTable] Use a more visible red color

apol added a comment. Shouldn't we be using a color from the palette/color scheme? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, cfeck Cc: apol, michaelh, ngraham, bruns

D9794: Provide access to data returned by helper even on error replies

volkov added a comment. ping REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D9794 To: volkov, #frameworks Cc: #frameworks, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, cfeck Cc: michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

ngraham created this revision. ngraham added reviewers: Frameworks, cfeck. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY When I started work on this, I first wrote a conditional lightness check that switched between `Qt::red`

D12696: Use the new uds implementation

jtamate added inline comments. INLINE COMMENTS > dfaure wrote in udsentry.cpp:454 > Hmm why can't this be the friend function directly? > > I don't like the added global functions in the public header... > Hmm why can't this be the friend function directly? Because the compiler (clang++ in

D12744: Add null pointer check when creating SocketAddress

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in fdreceiver.cpp:36 > print out `m_path.toLocal8Bit()` here? Possibly nitpicking, but toStdString converts to utf8 while toLocal8Bit() is what's used for SocketAddress and what's recommended for terminal output as well. If

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt updated this revision to Diff 33822. muhlenpfordt added a comment. Rebase to `Applications/18.04` REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12734?vs=33749=33822 BRANCH scale-up-folder-icon (branched from Applications/18.04)

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 33821. chinmoyr added a comment. Rebased on updated D12744 . REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33819=33821 BRANCH master REVISION DETAIL

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 33820. chinmoyr added a comment. Print the invalid socket path in case of an error. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33769=33820 BRANCH master REVISION DETAIL

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 33819. chinmoyr added a comment. Print the invalid socket path in case of error. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33775=33819 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745

D12744: Add null pointer check when creating SocketAddress

dfaure added inline comments. INLINE COMMENTS > fdreceiver.cpp:36 > +if (!addr.address()) { > +std::cerr << "Invalid socket address" << std::endl; > +return; print out `m_path.toLocal8Bit()` here? > fdsender.cpp:31 > +if (!addr.address()) { > +std::cerr <<

D12696: Use the new uds implementation

dfaure added inline comments. INLINE COMMENTS > udsentry.cpp:454 > > -KIOCORE_EXPORT QDebug operator<<(QDebug stream, const KIO::UDSEntry ) > +KIOCORE_EXPORT QDataStream <<(QDataStream , const UDSEntry ) > { Hmm why can't this be the friend function directly? I don't like the added global

D12696: Use the new uds implementation

jtamate updated this revision to Diff 33815. jtamate added a comment. Make some friends functions. A bad type in copy didn't allowed me the use of the module functions save/load/debugUDSEntry, REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12734: Scale up folder icon before creating preview overlays

rkflx added a comment. In D12734#259445 , @muhlenpfordt wrote: > I wanted to be careful here since I'm a bit afraid of changing library functions. If you think it's ok for `Applications/18.04` I'll rebase it. How else would you fix

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a comment. Forgot to mention this... There's a nice test application in `kio` for viewing a folder's preview in any desired size (created by `KIO::PreviewJob`): `previewtest`. Just enter the full path to the folder here. REPOSITORY R320 KIO Extras BRANCH master

D12696: Use the new uds implementation

jtamate updated this revision to Diff 33809. jtamate added a comment. Don't use java style. As UDSEntryPrivate is private, declare public methods save, load and debugUDSEntry, otherwise I couldn't access the private d pointer from the << and >> operators. REPOSITORY R241 KIO CHANGES