KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/45/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 05 Jun 2018 05:50:08 + Build duration: 6 min 51 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Jun 2018 05:36:58 + Build duration: 6 min 41 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 05 Jun 2018 05:36:58 + Build duration: 1 min 30 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Jun 2018 05:05:20 + Build duration: 2 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 05 Jun 2018 05:05:20 + Build duration: 1 min 37 sec and counting JUnit Tests

D13343: Properly reset plugins

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks ^^' REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D13343 To: elvisangelaccio, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13315: Detect mime type of local files based on their contents

miklosm added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:730 > That and also (broken) NFS mounts. We have that in quite a few places where > seemingly innocent local files can freeze the entire UI, so I'd rather not > introduce another place where this may happen. >

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13342: Fix regression when pasting binary data from clipboard

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Commit b73355da3f

D13343: Properly reset plugins

elvisangelaccio created this revision. elvisangelaccio added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY This patch fixes a small

D13268: Add signal for devices's address changing

drosca added a comment. Do you have a dev account? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D13268 To: andreysemenov, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

andreysemenov added a comment. In D13268#273515 , @drosca wrote: > Do you have a dev account? I think i don't. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D13268 To: andreysemenov, drosca Cc:

D12520: [PasteJob] Emit KDirNotify on paste

broulik added inline comments. INLINE COMMENTS > elvisangelaccio wrote in paste.cpp:125 > Missing `this` as the receiver argument? This is a `static` so there's no `this` and we also just access `job` and then call another `static` method REPOSITORY R241 KIO REVISION DETAIL

D13268: Add signal for devices's address changing

andreysemenov added a comment. In D13268#273519 , @drosca wrote: > In D13268#273516 , @andreysemenov wrote: > > > In D13268#273515 , @drosca wrote: > >

D13328: A backend is required for kdnssd

adridg edited the test plan for this revision. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D13328 To: adridg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

drosca added a comment. In D13268#273516 , @andreysemenov wrote: > In D13268#273515 , @drosca wrote: > > > Do you have a dev account? > > > I think i don't. Ok, your name and e-mail

D13268: Add signal for devices's address changing

This revision was automatically updated to reflect the committed changes. Closed by commit R269:41b41939c028: Add signal for devicess address changing (authored by andreysemenov, committed by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13268?vs=35331=35511#toc REPOSITORY

D13268: Add signal for devices's address changing

andreysemenov removed a reviewer: mlaurent. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D13268 To: andreysemenov, drosca, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

aacid added a comment. I'm with you that having a possibility to just compile kdnssd without any backend may be of value so i would either not commit this or improve the cmake so there's a way to say I_KNOW_WHAT_I_AM_DOING_KEEP_GOING REPOSITORY R272 KDNSSD REVISION DETAIL

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/59/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Jun 2018 20:08:37 + Build duration: 7 min 10 sec and counting JUnit Tests

D13308: Filter out duplicate plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R495:727ce79c815d: Filter out duplicate plugins (authored by elvisangelaccio). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13308?vs=35472=35557 REVISION

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/24/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 04 Jun 2018 20:08:37 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/35/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 04 Jun 2018 20:08:37 + Build duration: 2 min 14 sec and counting JUnit Tests

D13215: FrameSVG: Recache maskFrame if enabledBorders has been changed

zzag updated this revision to Diff 35542. zzag added a comment. Rebase. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13215?vs=35338=35542 BRANCH fix-framesvg-alphamask REVISION DETAIL https://phabricator.kde.org/D13215 AFFECTED

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 169 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/169/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Jun 2018 16:49:18 + Build duration: 6 min 24 sec and counting

D13287: FrameSVG: Delete redundant checks

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b169aa50f917: FrameSVG: Delete redundant checks (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13287?vs=35414=35541

D13286: FrameSVG: Fix QObject include

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a363815a796a: FrameSVG: Fix QObject include (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13286?vs=35413=35540 REVISION

D13287: FrameSVG: Delete redundant checks

zzag added a comment. In D13287#273556 , @apol wrote: > :( am I not plasma enough? Sorry, I still don't know who is who. :D REPOSITORY R242 Plasma Framework (Library) BRANCH framesvg-redundant-checks REVISION DETAIL

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13328: A backend is required for kdnssd

adridg updated this revision to Diff 35524. adridg added a comment. Use the right place (sorry Christophe, to use a Dutch phrase: I must have been looking with my nose). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13328?vs=35514=35524 BRANCH

D13328: A backend is required for kdnssd

cgiboudeaux added inline comments. INLINE COMMENTS > adridg wrote in CMakeLists.txt:65-66 > Hi. If you're posting a review, please provide constructive input. If there > are policies or guidelines about places, please link to them. If there > aren't, but you would prefer a change, please

D13328: A backend is required for kdnssd

adridg added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:65-66 > wrong place Hi. If you're posting a review, please provide constructive input. If there are policies or guidelines about places, please link to them. If there aren't, but you would prefer a change,

D13287: FrameSVG: Delete redundant checks

apol added a comment. :( am I not plasma enough? REPOSITORY R242 Plasma Framework (Library) BRANCH framesvg-redundant-checks REVISION DETAIL https://phabricator.kde.org/D13287 To: zzag, #plasma, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13328: A backend is required for kdnssd

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:65-66 > ecm_install_po_files_as_qm(po) > +else() > +message(FATAL_ERROR "Either Avahi or DNSSD is required for KDE > applications to make use of multicast DNS/DNS-SD service discovery") > endif() wrong place

D13328: A backend is required for kdnssd

adridg added a comment. Something to consider, though, is that it might perhaps be useful to have kdnssd build -- without a backend -- for environments where there is no real dnssd and any service discovery returns "not found". Requiring a backend makes that impossible. (So something

D13328: A backend is required for kdnssd

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY Refuse to build if there are no backends for DNSSD at all. The messages for the OPTIONAL

D13327: Fix conversion error when compiled against MDNSRESPONDER option

sitter added a comment. `-DQT_NO_CAST_FROM_BYTEARRAY` is a default define from `KDEFrameworkCompilerSettings.cmake`, so kdnssd should be working. The reason it wasn't is likely because most/all distributions build with avahi. Additionally, build.kde.org seems to build without avahi and

D13191: [server] Small code cleanup in SurfaceInterface

romangg edited the summary of this revision. REPOSITORY R127 KWayland BRANCH surfaceCodeCleanup REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13191: [server] Small code cleanup in SurfaceInterface

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH surfaceCodeCleanup REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham,

D13327: Fix conversion error when compiled against MDNSRESPONDER option

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY If QT_NO_CAST_FROM_BYTEARRAY is set, along with using MDNSRESPONDER, then the implicit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 167 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/167/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Jun 2018 08:33:29 + Build duration: 8 min 11 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 04 Jun 2018 08:33:29 + Build duration: 3 min 35 sec and counting

D13222: Use QDateTime for interfacing with QML

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d15f0fa8322d: Use QDateTime for interfacing with QML (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13222?vs=35217=35509

D13222: Use QDateTime for interfacing with QML

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D13222 To: fvogt, #plasma, #frameworks, davidedmundson Cc: ngraham, Zren, sharvey,

D13287: FrameSVG: Delete redundant checks

zzag added a comment. @apol Do I need to wait for other reviewers (from plasma)? Or I can land it right away? REPOSITORY R242 Plasma Framework (Library) BRANCH framesvg-redundant-checks REVISION DETAIL https://phabricator.kde.org/D13287 To: zzag, #plasma, #frameworks, apol Cc:

D13315: Detect mime type of local files based on their contents

broulik added inline comments. INLINE COMMENTS > apol wrote in kfileitem.cpp:730 > I'm not sure that makes sense. The fact that it's a local url doesn't mean it > will be fast to read. > FUSE appears as local urls and it's slow. That and also (broken) NFS mounts. We have that in quite a few

D13222: Use QDateTime for interfacing with QML

fvogt added a comment. In D13222#273334 , @ngraham wrote: > If the behavior changed in Qt 5.11, does the new code need a Qt version check, or is the patch backwards-compatible with earlier Qt versions? The latter, as it says in the test