D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns updated this revision to Diff 36735. bruns marked an inline comment as done. bruns added a comment. added @since 5.48 tags use @code/@endcode add KFormat::Unit::Hertz remaining comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns marked 10 inline comments as done. bruns added inline comments. INLINE COMMENTS > kossebau wrote in kformatprivate.cpp:138-145 > Are we sure those unit symbols do not need to be localized? What about > languages using different scripts (cyrillic, chinese, arabic, etc)? Yes. As you said,

D13571: Correct KFormat::formatBytes examples

bruns updated this revision to Diff 36731. bruns added a comment. Use @code/@endcode Reword extended documentation for precision parameter REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13571?vs=36234=36731 BRANCH kformat_doc REVISION DETAIL

D11828: Simplify orPostingIterator and make it faster

bruns marked an inline comment as done. bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Can someone please review this change? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, michaelh, #frameworks Cc:

D13747: Fuzzy filename search for Baloo

bruns added a comment. In D13747#283539 , @michaeleden wrote: > @bruns decoupling makes sense, but eventually there will be a need for a db right? > And I will definitely make those test cases, but I may ask for some help on how they're

D13700: implement reading of the replaygain tags

bruns added a comment. In D13700#282353 , @astippich wrote: > In D13700#282253 , @bruns wrote: > > > "dB" is nothing more than deci-Bel, i.e. 0.1 Bel. You can convert the value to e.g. mB or uB.

D13747: Fuzzy filename search for Baloo

michaeleden added a comment. @bruns decoupling makes sense, but eventually there will be a need for a db right? And I will definitely make those test cases, but I may ask for some help on how they're done in baloo. REPOSITORY R293 Baloo REVISION DETAIL

D12233: Avoid manipulation of lists with quadratic complexity

bruns added a comment. In D12233#279389 , @bruns wrote: > Still waiting for a final review ... Hello! Anyone at home? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc:

D13747: Fuzzy filename search for Baloo

bruns added a comment. I would very much prefer a test driven approach here: - Write down in english prosa what you want to match - Create some test cases - Add implementation classes Up to this point, you don't need any real database, QMap or std::map will do. Decoupling this

D13402: FrameSvg: Simplify updateSizes

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13496: FrameSvg: Update mask frame if image path has been changed

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13496 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13747: Fuzzy filename search for Baloo

michaeleden added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13747 To: michaeleden, vhanda, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13747: Fuzzy filename search for Baloo

michaeleden created this revision. michaeleden added a reviewer: vhanda. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. michaeleden requested review of this revision. REVISION SUMMARY This is a proof of concept

D12820: Add KWayland virtual desktop protocol

hein added a dependent revision: D13745: Implement support for virtual desktops on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich added a comment. Unfortunately it does not apply here because the base commit cannot be found. Also, may I already add an request? It would be great if the unit Hertz is included since it is used in baloo-widgets REPOSITORY R244 KCoreAddons REVISION DETAIL

D13698: Improve ECMAddAppIconMacro.

dschmidt marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36719. dschmidt added a comment. Remove debug spam ... REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36718=36719 BRANCH app-icon-modernization REVISION DETAIL

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36718. dschmidt added a comment. Commit fixes to the actual ECMAddAppIconMacro REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36715=36718 BRANCH app-icon-modernization REVISION DETAIL

D13698: Improve ECMAddAppIconMacro.

dschmidt edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36715. dschmidt added a comment. Squashed everything into one commit, sigh. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36713=36715 BRANCH app-icon-modernization REVISION DETAIL

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36713. dschmidt added a comment. Removed crap commit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36712=36713 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AFFECTED FILES

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36712. dschmidt added a comment. Fix macOS tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36710=36712 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AFFECTED FILES

D13698: Improve ECMAddAppIconMacro.

dschmidt added a comment. Added license, documentation and Alex Merry as copyright holder as the find module for png2ico was written by him. REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel,

D13698: Improve ECMAddAppIconMacro.

dschmidt marked 4 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36710. dschmidt added a comment. - Add copyright, license and documentation to FindIcoTool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36707=36710 BRANCH app-icon-modernization REVISION DETAIL

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY The current build system used an incomplete

D13698: Improve ECMAddAppIconMacro.

dschmidt updated this revision to Diff 36707. dschmidt added a comment. Tests stub and parameter rename CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36564=36707 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 AFFECTED FILES

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/27/ Project: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 26 Jun 2018 17:46:27 + Build duration: 2 min 38 sec and counting JUnit

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker added a comment. issued fixed and submitted rebased patch, thanks for reviewing REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13406 To: habacker, ilic, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

This revision was automatically updated to reflect the committed changes. habacker marked an inline comment as done. Closed by commit R249:3e44fb72a16d: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed… (authored by habacker). CHANGED PRIOR TO COMMIT

D13425: File indexer closing improvements.

smithjd retitled this revision from "file indexer closing inprovements." to "File indexer closing improvements.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov,

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36703. smithjd added a comment. Change commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36418=36703 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: file indexer closing inprovements.

smithjd updated this revision to Diff 36702. smithjd added a comment. Change git commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36416=36702 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 36701. smithjd added a comment. re-word commits. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=36417=36701 BRANCH master-scheduler (branched from master) REVISION DETAIL https://phabricator.kde.org/D13216

D13721: [ECMGenerateHeaders] Add option for other header file extension than .h

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5207cdeb2359: [ECMGenerateHeaders] Add option for other header file extension than .h (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D13722: Don't export kf5-config to the CMake config file

This revision was automatically updated to reflect the committed changes. Closed by commit R239:2ba94cc64e11: Dont export kf5-config to the CMake config file (authored by vkrause). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13722?vs=36644=36697

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Tue, 26 Jun 2018 16:03:52 + Build duration: 21 min and counting JUnit Tests

D12820: Add KWayland virtual desktop protocol

romangg added inline comments. INLINE COMMENTS > plasma-virtual-desktop.xml:55 > + > + > + This needs more description. Other events below as well. > plasmavirtualdesktop_interface.cpp:181 > + > +PlasmaVirtualDesktopInterface >

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/50/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 16:03:52 + Build duration: 4 min 20 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 26 Jun 2018 16:03:52 + Build duration: 3 min 40 sec and counting

D13733: Add provider auto test

habacker marked an inline comment as done. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D13733 To: habacker, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13733: Add provider auto test

habacker updated this revision to Diff 36693. habacker added a comment. - add documentation tp Provider::requestConfig() REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13733?vs=36668=36693 BRANCH master REVISION DETAIL

D8964: Fix two bugs in KMessageWidget

aacid added a comment. Restricted Application added a subscriber: kde-frameworks-devel. In D8964#175503 , @dhaumann wrote: > Please test the following: > > 1. load an existing file in kwrite: kwrite myFile > 2. touch it on console, e.g. echo

D13257: [server] Send frame event instead of flush on relative pointer motion

This revision was automatically updated to reflect the committed changes. Closed by commit R127:5e195c2a67ce: [server] Send frame event instead of flush on relative pointer motion (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/24/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 26 Jun 2018 14:37:42 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/62/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Jun 2018 14:37:42 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/34/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 26 Jun 2018 14:37:42 + Build duration: 11 min and counting JUnit Tests Name:

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg added a comment. Correct, in the end we want to combine input events and send them batched. For now the KWayland code does not allow this in general. REPOSITORY R127 KWayland BRANCH fixRelativeMotionFrame REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux added a comment. Thanks, just remove the trailing space before the 2 closing parenthesis. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D10166 (branched from master) REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid, cgiboudeaux Cc: kde-frameworks-devel,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D10166 (branched from master) REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid updated this revision to Diff 36684. aacid added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. make logical-op gcc only REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D13733: Add provider auto test

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Autotests are good, but so is documentation - in principle this is good, but new public functions without documentation isn't really acceptable :) Apart from that, though, looks

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni updated this revision to Diff 36678. anthonyfieroni added a comment. - Use recursive mutex - Unit test updated REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13627?vs=36523=36678 REVISION DETAIL https://phabricator.kde.org/D13627

D13722: Don't export kf5-config to the CMake config file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D13722 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13721: [ECMGenerateHeaders] Add option for other header file extension than .h

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R240 Extra CMake Modules BRANCH supportotherheaderextensions REVISION DETAIL https://phabricator.kde.org/D13721 To: kossebau, apol Cc: apol,

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. In D13406#277236 , @habacker wrote: > > BTW: I was faced to this on trying to understand the ki1i8n build system,

D13698: Improve ECMAddAppIconMacro.

cgiboudeaux added inline comments. INLINE COMMENTS > vpinon wrote in FindIcoTool.cmake:1 > Hello, > FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure > I can really claim the copyright. > In any case, I would choose the same license as all other ECM files (among >

D13733: Add provider auto test

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY The provider is checked by fetching the server

D13732: Add debug output for all network requests

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Only get requests had a debug output TEST PLAN