D14360: Remove custom icon selection for trash

pino added a comment. In D14360#299441 , @shubham wrote: > indirectly you mean to transfer all the logic to helper function No, I suggested something like: bool KFilePlaceEditDialog::canEditIcon() const { return

D14360: Remove custom icon selection for trash

shubham added a comment. indirectly you mean to transfer all the logic to helper function REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

pino added a comment. In D14360#299439 , @shubham wrote: > pino, I understood your idea of having a helper class function, but the condition for editing the icon will remain the same ( based on its scheme), what can be the other condition?

D14360: Remove custom icon selection for trash

shubham added a comment. pino, I understood your idea of having a helper class function, but the condition for editing the icon will remain the same ( based on its scheme), what can be the other condition? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To:

D14360: Remove custom icon selection for trash

pino requested changes to this revision. pino added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplaceeditdialog.cpp:66 > +// Get icon except for trash > +if (url.scheme() != QLatin1String("trash")) { > +icon = dialog->icon();

D13819: dummy commit to test pre-review CI

bshah removed a project: Frameworks. bshah removed a subscriber: kde-frameworks-devel. Restricted Application added a project: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, michaelh, ngraham, bruns, kde-frameworks-devel

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B1283: Diff 38634! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is unstable Link to build: https://build.kde.org/job/Reviews/job/13819/3/ See console output for more information: https://build.kde.org/job/Reviews/job/13819/3/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38633. shubham added a comment. Check before getting the icon, whether it's editable or not REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38524=38633 REVISION DETAIL https://phabricator.kde.org/D14360

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38634. bshah added a comment. - Revert "make it fail" - break test REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38632=38634 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build has FAILED Link to build: https://build.kde.org/job/Reviews/job/13819/2/ See console output for more information: https://build.kde.org/job/Reviews/job/13819/2/console REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819

D13819: dummy commit to test pre-review CI

Harbormaster failed remote builds in B1282: Diff 38632! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38632. bshah added a comment. - make it fail REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38631=38632 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is green https://build.kde.org/job/Reviews/job/13819/1/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 38631. bshah added a comment. - change REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=38500=38631 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D14434: add functions to access keywords

jpoelen added a comment. This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel,

D14434: add functions to access keywords

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

tundracomp added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Any review of this would be greatly apprechiated… REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: tundracomp Cc:

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is green https://build.kde.org/job/Reviews/job/38500/4/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

tundracomp added a comment. Could I get a new review on this please!? REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: ltoscano, cgiboudeaux, #frameworks, michaelh, ngraham, bruns

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

bruns added inline comments. INLINE COMMENTS > parser.cpp:58 > parseMetadataXml(xml); > -} else if (elements.contains(xml.name().toString())) { > +} else if (stringList_contains_stringRef(elements, xml.name())) { > item = parseXml(xml);

D14237: Make Konqi look good in HiDPI

bruns added a comment. I have traced the image with GIMPs selection tool, "convert selection to path" and export path as SVG. IMHO works best for tracing pixel art. F6154333: konqui.png F6154332: konqui.svg

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 334 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/334/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Jul 2018 14:46:43 + Build duration: 24 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/91/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 27 Jul 2018 14:46:43 + Build duration: 9 min 59 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 181 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/181/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 27 Jul 2018 14:46:43 + Build duration: 3 min 45 sec and counting CONSOLE OUTPUT

D12945: kcoredirlister lstItems benchmark

This revision was automatically updated to reflect the committed changes. Closed by commit R241:908bfca9fe72: kcoredirlister lstItems benchmark (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12945?vs=38134=38612#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D14397: Support libcanberra for audio notification

broulik added a comment. > Currently, libcanberra is tested on Linux only. I restored the Phonon option for when canberra isn't available on the platform. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure,

D14397: Support libcanberra for audio notification

alexeymin added a comment. But `Currently, libcanberra is tested on Linux only.`  Plasma-pa and plasma-whatever can use anything and be Linux-centric, KNotifications is a framework, isn't it? ++vote for QtMultimedia option... REPOSITORY R289 KNotifications REVISION DETAIL

D14397: Support libcanberra for audio notification

broulik added a comment. > phonon works just fine That's not true. If it worked fine, this patch would not exist, as I would not have apps freeze for seconds on teardown of Phonon objects, or latencies beyond all comparison REPOSITORY R289 KNotifications REVISION DETAIL

D14397: Support libcanberra for audio notification

sitter added a comment. In D14397#299073 , @rjvbb wrote: > > That's reinventing the wheel to a point. > > Creating Qt after Gtk or vice-versa was also reinventing the wheel to a much larger extent - so is adding more and more OS features

D14397: Support libcanberra for audio notification

nicolasfella added a comment. Not using something because it's from a "rival GUI" is not a valid argument. FWIW plasma-pa already uses Glib and Canberra. QtMultimedia uses GStreamer as backend on Unix, so it pulls in glib anyway. The only advantage, if any, of using QtMultimedia is that it

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/33/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.9 Date of build: Fri, 27 Jul 2018 10:29:31 + Build duration: 4 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/13/ Project: Frameworks ki18n kf5-qt5 AndroidQt5.11 Date of build: Fri, 27 Jul 2018 10:29:31 + Build duration: 4 min 17 sec and counting

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Jul 2018 10:29:31 + Build duration: 2 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.10/17/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 27 Jul 2018 10:29:31 + Build duration: 1 min 1 sec and counting JUnit Tests

D14397: Support libcanberra for audio notification

rjvbb added a comment. > That's reinventing the wheel to a point. Creating Qt after Gtk or vice-versa was also reinventing the wheel to a much larger extent - so is adding more and more OS features to Qt as has been going on for years. libcanberra comes from "the other" GUI

D13744: Let ki18n macro file name follow style of other find_package related files

mart added a comment. KI18n fails to install now REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13744 To: habacker, apol, ilic Cc: mart, kde-frameworks-devel, leinir, michaelh, ngraham, bruns

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

apol added a comment. In D14401#298611 , @aacid wrote: > Does this really make a difference? I was looking at heaptrack and this function was a point of contention, maybe not a big deal. > Also... fix qt to get

D14401: Don't instantiate a QStringRef into a QString only to search in a QStringList

This revision was automatically updated to reflect the committed changes. Closed by commit R235:1b7564fabf2b: Dont instantiate a QStringRef into a QString only to search in a QStringList (authored by apol). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE

D14397: Support libcanberra for audio notification

sitter added a comment. In D14397#298557 , @ngraham wrote: > Impressive work, Kai! However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library.

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker updated this revision to Diff 38569. habacker added a comment. - rebased REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13743?vs=36708=38569 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13743 AFFECTED FILES CMakeLists.txt

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 44 - Failure!

ki18n --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix//bin/sh: kdeinit5: command not foundCannot find file: /home/jenkins/workspace/Frameworks ki18n kf5-qt5 SUSEQt5.10/build/DartConfiguration.tcl Site:Build name: (empty)Create new tag: 20180727-0853

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 32 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/32/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.9 Date of build: Fri, 27 Jul 2018 08:50:26 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 27 Jul 2018 08:50:26 + Build duration: 45 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/12/ Project: Frameworks ki18n kf5-qt5 AndroidQt5.11 Date of build: Fri, 27 Jul 2018 08:50:26 + Build duration: 55 sec and counting CONSOLE OUTPUT

D13744: Let ki18n macro file name follow style of other find_package related files

This revision was automatically updated to reflect the committed changes. Closed by commit R249:382cf9ca29ad: Let ki18n macro file name follow style of other find_package related files (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13744?vs=38567=38568#toc

D13744: Let ki18n macro file name follow style of other find_package related files

habacker updated this revision to Diff 38567. habacker added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. - rebased REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D12945: kcoredirlister lstItems benchmark

jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns