D14978: Add unit test that checks Format data

This revision was automatically updated to reflect the committed changes. Closed by commit R216:e4d317da92a1: Add unit test that checks Format data (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14978?vs=40349&id=40351 REVI

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 107 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/107/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 24 Aug 2018 06:45:44 + Build duration: 16 sec and counting

D14978: Add unit test that checks Format data

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH check-full-formats (branched from master) REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel,

D14978: Add unit test that checks Format data

dhaumann updated this revision to Diff 40349. dhaumann added a comment. - Verify Definition::formats() contain all formats from 1...N REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14978?vs=40172&id=40349 BRANCH check-full-formats (branched f

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. Are you going to land this? REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano, b

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 40346. smithjd added a comment. - New DBus method updateIndex(). - Document indexing options. - Prevent a scheduler race condition. - Run de-indexing file check in parallel. - Rebase for separate statechanged functors. REPOSITORY R293 Baloo CHAN

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 40345. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36703&id=40345 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL https://phabricator.kde.

D13425: File indexer closing improvements.

smithjd updated this revision to Diff 40344. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36702&id=40344 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 40343. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D15048: Re-write the file index scheduler. Combine content indexer suspend logic.

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15048 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15048: Re-write the file index scheduler. Combine content indexer suspend logic.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Update the balooctl tool with the changed suspend/resume behaviour. Re-order and use IndexerState to pr

D15047: Export the StorageDevices object.

smithjd marked an inline comment as done. smithjd added a comment. In D15047#314477 , @bruns wrote: > There is no need for this, just create a new StorageDevices where you need it. > Creating a second StorageDevices instance in a process is qu

D15047: Export the StorageDevices object.

bruns added a comment. There is no need for this, just create a new StorageDevices where you need it. Creating a second StorageDevices instance in a process is quite cheap. INLINE COMMENTS > fileindexerconfig.cpp:322 > // been explicitly added in the include list > -const auto allM

D15047: Export the StorageDevices object.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

D11529: Balooctl: Deindex unfound files with check command.

smithjd edited dependencies, added: D15047: Export the StorageDevices object., D13216: Overhaul the file index scheduler.; removed: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #ba

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bru

D13424: Run a file changed check when the file watches are updated.

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, sp

D15047: Export the StorageDevices object.

smithjd added a reviewer: broulik. smithjd added a comment. This was included in https://phabricator.kde.org/D11529 and is now broken out. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michae

D15047: Export the StorageDevices object.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL https://phabricator.kde

D13906: add missing include

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH add_include REVISION DETAIL https://phabricator.kde.org/D13906 To: astippich, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngr

D14940: kformattest: Use plural suffix (s) consequently

aacid added a comment. In D14940#313853 , @habacker wrote: > I see - Qt lacks support for choosing the correct translation string for floating point values like this: > > qreal value = 1.0; >tr("%n second(s)", nullptr, value). > >

D15000: Display mounted file system type in properties dialog

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40312. shubham added a comment. Add mounted from label REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40236&id=40312 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdi

D15000: Display mounted file system type in properties dialog

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15013: balootctl: fix 396535

jausmus added a comment. In D15013#314082 , @bruns wrote: > 1. Use a proper commit message, with subject and body > 2. Please use "arc diff ..." to upload the diff, revisions without context are hard to review. Will do, my apologies. Ha

D15013: balootctl: fix 396535

jausmus added a comment. In D15013#313885 , @mgallien wrote: > In D15013#313880 , @jausmus wrote: > > > In D15013#313867 , @anthonyfieroni wrote: > > >

D15013: balootctl: fix 396535

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. 1. Use a proper commit message, with subject and body 2. Please use "arc diff ..." to upload the diff, revisions without context are hard to review. REPOSITORY R293 Baloo REVIS

D15023: [server] Add selectionChanged signal

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This signal notifies a compositor about selection changes on a seat. REPOSITORY R127

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

ngraham abandoned this revision. ngraham added a comment. Don't need this; not the right approach. The original motivation for doing this (to work around the broken placeholder text in the PC2 TextField) is being fixed in the PC2 TextField with D15021 and

D15021: Workaround bug with native rendering and opacity in TextField text

ngraham added a comment. Anyway, confirmed that this works around the problem for me. +1 REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: ngraham, kde-fram

D15021: Workaround bug with native rendering and opacity in TextField text

broulik added a comment. And potentially `QtQuickControlsPrivate` import but I recall it had some sideeffects that we needed, despite not using anything from it(?) REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricato

D15021: Workaround bug with native rendering and opacity in TextField text

ngraham added a comment. We could also get rid of the `import QtQuick.Window 2.2` line since it only existed to get `Screen.devicePixelRatio`, which this patch removes. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabr

D15021: Workaround bug with native rendering and opacity in TextField text

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D15021 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, michael

D15021: Workaround bug with native rendering and opacity in TextField text

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Problem is identified in https://bugreports.qt.io/browse/QTBUG-70

D14990: [Icon Item] Watch KIconLoader icon change when using QIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0ab02c05205: [Icon Item] Watch KIconLoader icon change when using QIcon (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14990?vs=40195&id=40287#toc REPOSITORY R242 Pla

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 203 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/203/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 23 Aug 2018 09:31:58 + Build duration: 3 min 3 sec and counting JUn

D14990: [Icon Item] Watch KIconLoader icon change when using QIcon

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14990 To: broulik, #plasma, TheAssassin, mart Cc: azubieta, kde-frameworks-devel, michaelh, ngraham, bruns

D15017: Attach property to "delegate"

This revision was automatically updated to reflect the committed changes. Closed by commit R296:be68566c38ae: Attach property to "delegate" (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15017?vs=40283&id=40284 REVISION DETAIL ht

D15017: Attach property to "delegate"

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D15017 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15017: Attach property to "delegate"

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise crashes when switching between KCMs BUG: 397367 TEST PLAN Can reliab

D15013: balootctl: fix 396535

mgallien added a comment. In D15013#313880 , @jausmus wrote: > In D15013#313867 , @anthonyfieroni wrote: > > > Do not use QDir::separator > > > > if (!folder.endsWith(QLatin1Char('/')) { > >

D15006: Allow to turn of the QStandardPaths lookups

vkrause added a comment. Ah, perfect :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15006 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D15006: Allow to turn of the QStandardPaths lookups

cullmann added a comment. > Nice :) One thing that came to mind for static builds is that we probably need to manually initialize the qrc files in Repository, as that doesn't work automatically then. But if you take them out anyway, that's not a problem. We do that ;=) static void i

D15006: Allow to turn of the QStandardPaths lookups

vkrause added a comment. Nice :) One thing that came to mind for static builds is that we probably need to manually initialize the qrc files in Repository, as that doesn't work automatically then. But if you take them out anyway, that's not a problem. REPOSITORY R216 Syntax Highlighting R

D15013: balootctl: fix 396535

jausmus added a comment. In D15013#313867 , @anthonyfieroni wrote: > Do not use QDir::separator > > if (!folder.endsWith(QLatin1Char('/')) { > folder += QLatin1Char('/'); > } > Does balooctl not need cross platform sup

D15006: Allow to turn of the QStandardPaths lookups

cullmann added a comment. I think now all things are in place for MIT like usage by other tools. The AbsInt CI tells that tests still pass on macOS/Linux/Windows with both FEATURE_NO_STANDARD_PATHS on and SYNTAX_RESOURCE off. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://

D15006: Allow to turn of the QStandardPaths lookups

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ee0aa575255b: Allow to turn of the QStandardPaths lookups (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15006?vs=40257&id=40280

D15006: Allow to turn of the QStandardPaths lookups

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Good point regarding the initialization order, adding stuff is easier there than removing things. The only alternative I can think of would be lazy-loading in Repository, so you have the

D15013: balootctl: fix 396535

anthonyfieroni added a comment. Do not use QDir::separator if (!folder.endsWith(QLatin1Char('/')) { folder += QLatin1Char('/'); } REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 To: jausmus Cc: anthonyfieroni, kde-frameworks-devel, #baloo, asha

D14994: [Windows Device] Show device label only if there is one

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9182bfe35ab1: [Windows Device] Show device label only if there is one (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14994?vs=40202&id=40278 R

D14940: kformattest: Use plural suffix (s) consequently

habacker added a comment. I see - Qt lacks support for choosing the correct translation string for floating point values like this: qreal value = 1.0; tr("%n second(s)", nullptr, value). which should return **1.0 second** qreal value = 1.34; tr("%n second(s)", nullpt