D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham updated this revision to Diff 41374. ngraham added a comment. Adjust message string REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15318?vs=41370=41374 BRANCH samba-auto-re-upload-after-save (branched from master) REVISION DETAIL

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham,

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome. Tested it out, and this definitely helps for 1366x768. Doesn't regress the 1920x1090 or larger case, either. To get High DPI support working, I bet we need to multiply some

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

ngraham updated this revision to Diff 41370. ngraham added a comment. Implement first pass at some user-friendly error checking REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15318?vs=41305=41370 BRANCH samba-auto-re-upload-after-save (branched from master)

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. I just realized the output was HTML. Ok, I can see what is going on now. If you could let me know if I am missing the "code-editor" though, that would be great! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To:

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. In D15340#322631 , @dhaumann wrote: > Sure, please use kdesrc-build as described here: > https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source > > Once setup, you can build everything by invoking

D14724: autotests: don't fail if an unrelated window shows up.

jtamate added a comment. It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 . or ctest -j4 . 13/15 Test #3: plasma-dialogstatetest ...***Failed2.42 sec 3/15 Test #3: plasma-dialogstatetest ...***Failed1.71 sec REPOSITORY R242

D14724: autotests: don't fail if an unrelated window shows up.

dfaure added a comment. @hein - or anyone else - ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D15407: Fix OCS provider URL in about dialog

dhaumann added a reviewer: alexanderschmidt. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D15407 To: broulik, #frameworks, leinir, alexanderschmidt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15408: Don't assert deleting the temporary file

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Change the names of the temporary files to something more difficult for

D15407: Fix OCS provider URL in about dialog

broulik created this revision. broulik added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Fixes loading provider information TEST PLAN The URL stored at

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/55/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 10 Sep 2018 15:01:26 + Build duration: 8 min 30 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/111/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 10 Sep 2018 15:01:26 + Build duration: 3 min 25 sec and counting JUnit Tests Name: (root)

D15406: Manually resize KCMUtilDialog to sizeHint()

valeriymalov created this revision. valeriymalov added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY Workaround for https://bugreports.qt.io/browse/QTBUG-3459

D14530: Fix crash when save a QImage to the eps format file

kossebau added a comment. Given this here still shows up in my phabricator list, and having given "smart" ;) comments on the bug report, please find a patch based on my comments at D15405 . REPOSITORY R287 KImageFormats REVISION DETAIL

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

kossebau created this revision. kossebau added reviewers: zccrs, dfaure, pino. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Deny any capabilities when there is no QApp instance. BUG: 397040

D15177: Emit signals when a package is installed/uninstalled

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in packagejob.cpp:90 > Can this be invalid or does `install` already check for validity? bool PackageJobThread::installPackage(const QString , const QString , OperationType operation) { ... if (!meta.isValid()) {

D15177: Emit signals when a package is installed/uninstalled

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D15177 To: davidedmundson, #plasma, broulik Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/9/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 10 Sep 2018 10:42:23 + Build duration: 3 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.11 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.11/16/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 10 Sep 2018 10:42:13 + Build duration: 2 min 8 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/17/ Project: kf5-qt5 AndroidQt5.11 Date of build: Mon, 10 Sep 2018 10:42:15 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.11 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.11/15/ Project: kf5-qt5 AndroidQt5.11 Date of build: Mon, 10 Sep 2018 10:42:12 + Build duration: 37 sec and counting CONSOLE OUTPUT

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Please unite the includedDefinitions() Beside that, I think it would make sense to have the resolveIncludeKeywords() part inside the KeywordList class, then we don't need

D15177: Emit signals when a package is installed/uninstalled

broulik added inline comments. INLINE COMMENTS > packagejob.cpp:90 > +if (ok) { > +const QString pluginId = d->package->metadata().pluginId(); > +const QStringList serviceTypes = > d->package->metadata().serviceTypes(); Can this be invalid or does `install`

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

broulik abandoned this revision. broulik added a comment. Was an idea :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15242 To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15397: Perl: fix brackets, variables, string references and others

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d0c698198ec8: Perl: fix brackets, variables, string references and others (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15397: Perl: fix brackets, variables, string references and others

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-perl REVISION DETAIL https://phabricator.kde.org/D15397 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D15397: Perl: fix brackets, variables, string references and others

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice, looks a lot better in the comparison screenshots. I had this issues in my own scripts, too, but was too dumb to fix that myself, thanks ;=) REPOSITORY R216 Syntax

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.11 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.11/44/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 10 Sep 2018 08:10:40 + Build duration: 1 min 10 sec and counting

D15390: Bash: fix parameter & brace expansion

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15390 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars,

D15397: Perl: fix brackets, variables, string references and others

nibags retitled this revision from "Perl: fix brackets, variables, strings ref. and some improvements" to "Perl: fix brackets, variables, string references and others". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15397 To: nibags, cullmann, dhaumann,

D15397: Perl: fix brackets, variables, strings ref. and some improvements

nibags edited the summary of this revision. nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15397 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel,

D15397: Perl: fix brackets, variables, strings ref. and some improvements

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-perl REVISION DETAIL https://phabricator.kde.org/D15397 AFFECTED

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. The properties##CSS variant is really just like what I wanted, too! Nice. Only nitpick API wise: I would not expose the difference between includedDefinitions and includedKeywordDefinitions, I would just like to have all included definitions in

D15390: Bash: fix parameter & brace expansion

dhaumann accepted this revision. dhaumann added a comment. +1, thanks. REPOSITORY R216 Syntax Highlighting BRANCH fix-bash REVISION DETAIL https://phabricator.kde.org/D15390 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel,