KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 222 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/222/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 15 Sep 2018 03:57:08 + Build duration: 26 min and counting JUnit Tests Name: (root)

D14757: Warn user before copy/move operation if available space is not enough

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D15513: Fix dangling reference with "auto" becoming "QStringBuilder"

This revision was automatically updated to reflect the committed changes. Closed by commit R6:ea5416f8f99a: Fix dangling reference with auto becoming QStringBuilder (authored by kossebau). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15513?vs=41661=41668

D15513: Fix dangling reference with "auto" becoming "QStringBuilder"

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH fixqstringliteralvsauto REVISION DETAIL https://phabricator.kde.org/D15513 To: kossebau, ivan, mlaurent, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham,

D15513: Fix dangling reference with "auto" becoming "QStringBuilder"

kossebau created this revision. kossebau added reviewers: ivan, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY With QT_USE_QSTRINGBUILDER being enabled, code best is checked with clazy

D15511: Add support for Code 128 barcodes

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15511 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15511: Add support for Code 128 barcodes

vkrause added inline comments. INLINE COMMENTS > svuorela wrote in code128barcodetest.cpp:111 > doesn't QCOMPARE automatically output both ? Yep, but not perfectly aligned underneath each other, which is extremely helpful for spotting bit differences. REPOSITORY R280 Prison REVISION DETAIL

D15511: Add support for Code 128 barcodes

vkrause updated this revision to Diff 41659. vkrause added a comment. Remove copy/paste mistake. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15511?vs=41657=41659 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15511 AFFECTED FILES

D15511: Add support for Code 128 barcodes

svuorela added inline comments. INLINE COMMENTS > CMakeLists.txt:26 > +) > +# qt5_add_resources(aztecbarcodetest_srcs aztec/aztec.qrc) > + copy/paste error ? > code128barcodetest.cpp:111 > +qDebug() << "Expected:" << output; > +} > +QCOMPARE(v, output); doesn't

D6513: Add support for Attica tags support

ngraham added a comment. FYI, this included an ABI change to `SearchRequest` that broke Discover: https://bugs.kde.org/show_bug.cgi?id=398412 REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra,

D15511: Add support for Code 128 barcodes

vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D15511 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15511: Add support for Code 128 barcodes

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15511 AFFECTED FILES autotests/CMakeLists.txt

ABI break in KNewStuff

Packagers, There's an ABI break in KNewStuff 5.55 (2ad3e66d81b63495a59d012f673af7bd854b53d7) It's released now, I don't think we have any option as fixing it would mean we have 2 ABI breaks. Can people please rebuild everything that depends on it. Especially plasma-discover. See

D14757: Warn user before copy/move operation if available space is not enough

shubham retitled this revision from "Warn user before copy operation if available space is not enough" to "Warn user before copy/move operation if available space is not enough". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc:

D14757: Warn user before copy operation if available space is not enough

shubham updated this revision to Diff 41655. shubham edited reviewers, added: broulik; removed: cfeck. shubham added a comment. Done above requested changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=39531=41655 REVISION DETAIL

D15068: Bindings: Correct handling of sources containing utf-8

This revision was automatically updated to reflect the committed changes. Closed by commit R240:28da9e614f66: Bindings: Correct handling of sources containing utf-8 (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15068?vs=40392=41646#toc REPOSITORY R240 Extra CMake

D15431: Make PersonPluginManager API public

This revision was automatically updated to reflect the committed changes. Closed by commit R307:73a72d53325f: Make PersonPluginManager API public (authored by poboiko). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15431?vs=41640=41645 REVISION DETAIL

D15497: Fix CMakeLists.txt issues

This revision was automatically updated to reflect the committed changes. Closed by commit R307:13d933732b78: Fix CMakeLists.txt issues (authored by poboiko). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15497?vs=41641=41643 REVISION DETAIL

D15068: Bindings: Correct handling of sources containing utf-8

bruns added a comment. In D15068#325752 , @bcooksley wrote: > The code itself looks fine to me - the change on line 752 is to allow handling of macOS / Windows line endings in addition to just Unix line endings I presume? Yes. Thats

D15497: Fix CMakeLists.txt issues

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R307 KPeople BRANCH cmake-issues (branched from master) REVISION DETAIL https://phabricator.kde.org/D15497 To: poboiko, #frameworks, dvratil, apol Cc:

D15431: Make PersonPluginManager API public

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Nice, thank you! REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15431 To: poboiko, #kde_pim, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns,

D15068: Bindings: Correct handling of sources containing utf-8

bruns added a comment. In D15068#325659 , @jtamate wrote: > Another solution (not tested here but used in other projects) could be to use > with open(source, "r", encoding="utf-8") as f: > (or if the file could contain the aberration BOM,

D15068: Bindings: Correct handling of sources containing utf-8

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. INLINE COMMENTS > sip_generator.py:752 > # > -return "".join(extract).replace("\n", " ") > +return b''.join(extract).decode('utf-8').replace("\r\n", "

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/53/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 14 Sep 2018 12:04:42 + Build duration: 1 min 50 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Sep 2018 12:04:42 + Build duration: 1 min 2 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/22/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 14 Sep 2018 12:04:42 + Build duration: 32 sec and counting CONSOLE OUTPUT [...truncated

D15497: Fix CMakeLists.txt issues

poboiko updated this revision to Diff 41641. poboiko added a comment. Fixed global includes REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15497?vs=41612=41641 BRANCH cmake-issues (branched from master) REVISION DETAIL

D15497: Fix CMakeLists.txt issues

poboiko marked an inline comment as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15497 To: poboiko, #frameworks, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15431: Make PersonPluginManager API public

poboiko marked 3 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15431 To: poboiko, #kde_pim, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D15431: Make PersonPluginManager API public

poboiko updated this revision to Diff 41640. poboiko added a comment. Added some documentation REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15431?vs=41616=41640 REVISION DETAIL https://phabricator.kde.org/D15431 AFFECTED FILES

D14938: Force ki18n to build with the libintl.so path

sdepiets added a comment. In D14938#325850 , @sars wrote: > If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it. Correct me if I'm wrong, but

D14938: Force ki18n to build with the libintl.so path

sdepiets added a comment. In D14938#325850 , @sars wrote: > If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it. Correct me if I'm wrong, but

D15497: Fix CMakeLists.txt issues

dvratil requested changes to this revision. dvratil added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > personactionsmodel.cpp:21 > #include > -#include > +#include > #include This looks suspicious. When compiling, you should not need to refer to ``,

D15431: Make PersonPluginManager API public

dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Just some minor details and we are good to go :) INLINE COMMENTS > personpluginmanager.h:34 > class KPEOPLE_EXPORT PersonPluginManager > { Sorry, forgot to mention this in

D14938: Force ki18n to build with the libintl.so path

sars added a comment. If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it. REPOSITORY R877 Craft Blueprints for KDE REVISION DETAIL https://phabricator.kde.org/D14938 To: sdepiets, #craft,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#134955 , @graesslin wrote: > I like that refactoring  - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt? Maybe `findSurfaceHelper`. REPOSITORY

D14938: Force ki18n to build with the libintl.so path

vonreth added reviewers: bcooksley, arichardson. REPOSITORY R877 Craft Blueprints for KDE REVISION DETAIL https://phabricator.kde.org/D14938 To: sdepiets, #craft, vonreth, #frameworks, bcooksley, arichardson Cc: vonreth

KDE CI: Frameworks » kxmlgui » kf5-qt5 FreeBSDQt5.11 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20FreeBSDQt5.11/7/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 14 Sep 2018 09:40:15 + Build duration: 9 min 34 sec and counting

D15431: Make PersonPluginManager API public

poboiko marked 4 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15431 To: poboiko, #kde_pim, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D15431: Make PersonPluginManager API public

poboiko updated this revision to Diff 41616. poboiko added a comment. - Switched to QMutexLocker - Changed behavior of `addDataSource` to override existing (and delete it) - Added documentation for `addDataSource` - Switched to KPeople logging category introduced recently REPOSITORY

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 221 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/221/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Sep 2018 09:05:45 + Build duration: 2 min 26 sec and counting JUnit Tests Name:

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:819 > position is a float So, it would be fine to return `true` in the following case: QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10)); ? REPOSITORY R127 KWayland REVISION DETAIL

D15497: Fix CMakeLists.txt issues

poboiko created this revision. poboiko added reviewers: Frameworks, dvratil, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Remove redundant install(FILES) and fix PREFIX for KPeople/Widgets

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in surface_interface.cpp:819 > Shouldn't it be QRect instead? position is a float REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: davidedmundson, zzag,

D15068: Bindings: Correct handling of sources containing utf-8

bcooksley added a comment. The code itself looks fine to me - the change on line 752 is to allow handling of macOS / Windows line endings in addition to just Unix line endings I presume? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15068 To: bruns,

D15431: Make PersonPluginManager API public

dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Looks good, just some minor nitpicks. - > There some ancient compatibility code inside PersonPluginManagerPrivate::loadDataSourcePlugins(), which was added 3 years

D13034: Add mechanism to notify other clients of config changes over DBus

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kconfigwatcher.cpp:72 > +watchedPaths name(); > +for (const QString file: d->m_config->additionalConfigSources()) { > +watchedPaths <<

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > surface_interface.cpp:819 > + > +return !size.isEmpty() && QRectF(QPoint(0, 0), size).contains(position); > +} Shouldn't it be QRect instead? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/38/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 14 Sep 2018 07:00:10 + Build duration: 5 min 32 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/64/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Sep 2018 07:00:10 + Build duration: 5 min 13 sec and counting JUnit Tests Name:

D15068: Bindings: Correct handling of sources containing utf-8

jtamate added a comment. Another solution (not tested here but used in other projects) could be to use with open(source, "r", encoding="utf-8") as f: (or if the file could contain the aberration BOM, you could use "utf-8-sig") And it should convert automatically all kind of line-ends