D15780: YAML: add literal & folded block styles

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c32cf6020931: YAML: add literal folded block styles (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15780?vs=42389=42456

D15780: YAML: add literal & folded block styles

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-literal-style-yaml REVISION DETAIL https://phabricator.kde.org/D15780 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting, turbov Cc: turbov, kwrite-devel, kde-frameworks-devel,

D15771: Logcat & SELinux: improvements for the new Solarized schemes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:5dbf2ec3fe1d: Logcat SELinux: improvements for the new Solarized schemes (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:896d3bda6c1d: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new… (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

This revision was automatically updated to reflect the committed changes. Closed by commit R244:288d6d3a9d18: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15558?vs=41771=42453

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/57/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 28 Sep 2018 01:24:36 + Build duration: 4 min 29 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 28 Sep 2018 01:24:36 + Build duration: 4 min 10 sec and counting JUnit Tests Name: (root)

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D15558 To: bruns, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns added a comment. In D15558#333027 , @apol wrote: > So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right? > Makes sense to me to remove this line then, if the default behaviour works for us (it seems so).

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

apol added a comment. So the problem is that nobody is defining KDE_INSTALL_PYTHONBINDINGSDIR right? Makes sense to me to remove this line then, if the default behaviour works for us (it seems so). REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D15558 To:

D15558: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

bruns added a comment. Ping! REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D15558 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15715: remove own implementation of QString to TString conversion for taglibwriter

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D15704: increase test coverage of taglibwriter

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > taglibwritertest.cpp:74 > + > +QTest::addRow("mp3") > +<< QStringLiteral("mp3") Can you sort the tests alphabetically? It does not matter much, but

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

akrutzler added inline comments. INLINE COMMENTS > dfaure wrote in mtpstorage.cpp:499 > DBus timeouts are actually configurable, if you need to block until the copy > is done, btw. In my previous approach I increased the timeout to 10 minutes. This worked fine until I downloaded a file of

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

akrutzler updated this revision to Diff 42450. akrutzler marked 13 inline comments as done. akrutzler added a comment. - Rebase - Remove unrelated changes - Remove Q_FUNC_INFO - Remove private static methods from header file - Use currentDateTimeUtc instead of currentDateTime -

D15715: remove own implementation of QString to TString conversion for taglibwriter

bruns added a comment. Can you copy the summary verbatim from D15614 , and just add a "See also D15614 "? Otherwise, good to go. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715

D15220: implement more basic tags for taglibwriter

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:67 > taglib only allows unsigned int for year and track, so I don't know how > that's possible with taglib. > I added checks to

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I've written you a unit test. I can either take over this or upload as a separate review that you can merge in. INLINE COMMENTS > zzag wrote in

D15645: Add scheme selection menu with a "System" entry.

amhndu retitled this revision from "[WIP] Add scheme selection menu with a "System" entry." to "Add scheme selection menu with a "System" entry.". amhndu edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu,

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

nibags added a comment. I attach two files. The "usr.bin.firefox" file causes the error on line 31 and "usr.bin.apparmor-profile-test" on line 184. F6288872: usr.bin.firefox F6288873: usr.bin.apparmor-profile-test

D15806: [Fstab] Remove AIX support

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN make REPOSITORY R245 Solid BRANCH os_cleanup REVISION DETAIL

D15805: [Fstab] Remove Tru64 (__osf__) support

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN make REPOSITORY R245 Solid BRANCH os_cleanup REVISION DETAIL

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I would say: this should go in to workaround the current issue. If you have a file, that triggers the "freeze" with the old version, I would be happy to get it here as

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

nibags added a comment. I did debug with gdb and valgrind, but the information is not relevant, since Kate freezes and I have to kill the process (I think I used the term "crash" incorrectly :S). I have done some tests and the problem is in the use of `#pop!some_context` on the main

D14472: Set Dialog flag for JobDialog

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14472: Set Dialog flag for JobDialog

nicolasfella added a comment. Ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15800: Create and install solid.categories for kdebugsettings

This revision was automatically updated to reflect the committed changes. Closed by commit R245:c16e60d3ba1e: Create and install solid.categories for kdebugsettings (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15800?vs=42432=42434

D15799: [Fstab] Add support for categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R245:5c50fa7b7ddc: [Fstab] Add support for categorized logging (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15799?vs=42431=42433 REVISION DETAIL

D15800: Create and install solid.categories for kdebugsettings

bruns added a comment. In D15800#332850 , @broulik wrote: > Oh, I thought `kdebugsettings` was somehow magical. Unfortunately not ... Would be nice if we could at least autogenerate the *.categories file from the

D15800: Create and install solid.categories for kdebugsettings

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Oh, I thought `kdebugsettings` was somehow magical. REPOSITORY R245 Solid BRANCH fstab_support_non_networkshares REVISION DETAIL https://phabricator.kde.org/D15800 To: bruns,

D15800: Create and install solid.categories for kdebugsettings

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN install solid.categories into config directory start kdebugsettings REPOSITORY R245 Solid

D15799: [Fstab] Add support for categorized logging

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15799 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15799: [Fstab] Add support for categorized logging

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Add infrastructure to use categorized logging in the fstab backend TEST PLAN make

D15778: Log wallet open failure errors

arjun removed a reviewer: mlaurent. arjun marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

arjun added a reviewer: mlaurent. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

arjun updated this revision to Diff 42430. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15778?vs=42381=42430 REVISION DETAIL https://phabricator.kde.org/D15778 AFFECTED FILES src/runtime/kwalletd/kwalletd.cpp To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh,

D15798: [Fstab] Show non-empty share name in case root fs is exported

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R245:419a551baa3e: [Fstab] Show non-empty share name in case root fs is exported (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D15798: [Fstab] Show non-empty share name in case root fs is exported

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Alright, ship it REPOSITORY R245 Solid BRANCH ensure_nonempty_nfs_exportname REVISION DETAIL https://phabricator.kde.org/D15798 To: bruns, #frameworks, broulik Cc:

D15798: [Fstab] Show non-empty share name in case root fs is exported

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > broulik wrote in fstabdevice.cpp:45 > This should probably be moved outside this if, you get the same bug when you > do ``//server/` SMB/Cifs share names can never be empty, i.e. you always have `//server/`

D15795: Fix warnings about deprecated install dirs

dinoh added inline comments. INLINE COMMENTS > ltoscano wrote in KDEInstallDirs.cmake:564 > I'm going to comment only on this, but the others (most, if not all) are the > same. If you check the definition of _define_relative, this parameter is: > > oldstylename (optional): the old-style name

D15798: [Fstab] Show non-empty share name in case root fs is exported

broulik added inline comments. INLINE COMMENTS > fstabdevice.cpp:45 > m_product = m_device.mid(m_device.indexOf(":/") + 2); > +if (m_product.isEmpty()) { > +m_product = QStringLiteral("/"); This should probably be moved outside this if, you get the same bug when you

D15798: [Fstab] Show non-empty share name in case root fs is exported

bruns edited the summary of this revision. bruns added a reviewer: broulik. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15798 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The leading slash is stripped to save some space for the human readable description

D15644: Provide option to hide menu bar for Ksysguard

ngraham added a comment. Awesome job, @lsartorelli. For your next trick, would you like to create `KStandardAction::showMenubarWithWarning` (or something like that)? This would essentially duplicate the code you've written here, but it would be in a new central location so we could ensure

D15795: Fix warnings about deprecated install dirs

ltoscano added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:564 > "documentation bundles generated using kdoctools" > -HTML_INSTALL_DIR) > +KDE_INSTALL_DOCBUNDLEDIR) > _define_relative(KCFGDIR DATAROOTDIR "config.kcfg" I'm going to comment only on this, but the others

D15795: Fix warnings about deprecated install dirs

dinoh added reviewers: apol, bruns, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15795 To: dinoh, apol, bruns, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

dinoh created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. dinoh requested review of this revision. REVISION SUMMARY KDEInstallDirs.cmake used the deprecated format for install dirs internally and thus caused a

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 155 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/155/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 27 Sep 2018 11:21:18 + Build duration: 15 min and counting JUnit Tests Name: (root)

D15705: Also raise configuration window when reusing it

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ea6cf10f4250: Also raise configuration window when reusing it (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 230 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/230/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 27 Sep 2018 11:21:18 + Build duration: 2 min 28 sec and counting JUnit Tests Name:

D15705: Also raise configuration window when reusing it

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15705 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15644: Provide option to hide menu bar for Ksysguard

This revision was automatically updated to reflect the committed changes. Closed by commit R106:3a3220d41ac4: Provide option to hide menu bar for Ksysguard (authored by lsartorelli, committed by sitter). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D15644: Provide option to hide menu bar for Ksysguard

sitter accepted this revision. sitter added a comment. It's perfect now! REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks, sitter Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15745: Implement Media and MediaEndpoint API

drosca added inline comments. INLINE COMMENTS > mweichselbaumer wrote in media_p.h:37 > MediaPrivate will later act as parent for child objects (inheriting QObject). Then just parent them to Media instead of private class. REVISION DETAIL https://phabricator.kde.org/D15745 To: