romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> surface_interface.cpp:461
> }
> -} else if (!target->buffer && emitChanged) {
> +} else if (!target->buffer) {
> su
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R120:17380886d9b8: [Devicenotifications Engine] Keep at most
one notification per UDI (authored by bruns).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D1589
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Firefox sends
wl_surface@37.damage(0, 0, 808, 622)
wl_surfac
romangg updated this revision to Diff 42764.
romangg marked 3 inline comments as done.
romangg added a comment.
- Remove rects call
- Respect buffer scale
- Test damage against scaled surface
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15910?vs=4276
ngraham updated this revision to Diff 42763.
ngraham added a comment.
Make the separator line touch the line drawn by the scrollview when it's
scrollable
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15194?vs=40798&id=42763
BRANCH
ta
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/22/
Project:
kf5-qt5 SUSEQt5.9
Date of build:
Tue, 02 Oct 2018 22:51:54 +
Build duration:
3 min 53 sec and counting
JUnit Tests
Name: (root) F
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/28/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Tue, 02 Oct 2018 22:51:54 +
Build duration:
1 min 4 sec and counting
JUnit Tests
Name: (root)
dfaure closed this revision.
REPOSITORY
R287 KImageFormats
REVISION DETAIL
https://phabricator.kde.org/D15890
To: dfaure, cfeck
Cc: jtamate, kde-frameworks-devel, michaelh, ngraham, bruns
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in surface_interface.cpp:450
> scale is also a transform.
>
> Note also that the damage signal is used in kwin assuming it's surface local.
Thanks! After applying the output transform **and** the scale transform, the
damaged
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> surface_interface.cpp:450
> +typedef OutputInterface::Transform Tr;
> +const Tr tr = target->transform;
zzag added inline comments.
INLINE COMMENTS
> surface.cpp:244
> +{
> +for (const QRect &r : region.rects()) {
> +damageBuffer(r);
`for (const QRect &r : region) {`
rects() is obsolete. http://doc.qt.io/qt-5/qregion-obsolete.html#rects
REPOSITORY
R127 KWayland
REVISION DETAIL
h
romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.
REVISION SUMMARY
Missing from our surface handling was the damage_buffer call introduced in
version 4 o
zrax created this revision.
Herald added a project: Frameworks.
zrax requested review of this revision.
REVISION SUMMARY
Fix a compile failure on Windows due to the use of QSysInfo enums which are
not fully qualified.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D159
Hi,
I quite like Qt Creator's feature that highlights blocks (in code) by applying
a gradient of background darkening that makes code less conspicuous the further
it is outside the current context. Has something like this ever been considered
for Kate-based editors?
I also find Creators defaul
romangg added a dependent revision: D15900: Add unit test for subsurface input
mask detection.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-dev
romangg added a dependency: D7038: [server] Respect input region of
sub-surfaces on pointer surface focus.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15900
To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added a comment.
Read this
https://community.kde.org/Infrastructure/Get_a_Developer_Account#Who_Can_Apply_For_a_KDE_Developer_Account.3F
and then go here: https://identity.kde.org/index.php?r=developerApplication
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/29/
Project:
kf5-qt5 SUSEQt5.9
Date of build:
Tue, 02 Oct 2018 17:00:40 +
Build duration:
7 min 15 sec and counting
JUnit Tests
Name: (root) F
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/41/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Tue, 02 Oct 2018 17:00:40 +
Build duration:
2 min 4 sec and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:9658d727bdae: Use _NET_WM_WINDOW_TYPE_COMBO instead of
_NET_WM_WINDOW_TYPE_COMBOBOX (authored by zzag).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15353?v
davidedmundson added a comment.
I think maybe it should, but it should be changed with surfaceAt
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasm
zzag added a comment.
> QRectF(QPoint(0, 0), size()).contains(position)
Shouldn't it be QRect instead? (again)
If it should be QRectF indeed, could someone please explain why?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, grae
davidedmundson accepted this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel,
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngrah
romangg marked an inline comment as done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel,
ragreen, Pitel, schernikov, michaelh, ZrenBot, ng
romangg updated this revision to Diff 42733.
romangg added a comment.
- Update version number
- Do code duplication instead of pointers
- Add comment about code duplication
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7038?vs=42725&id=42733
BRANCH
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15900
AFFE
romangg updated this revision to Diff 42725.
romangg added a comment.
Rebase on master.
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7038?vs=18059&id=42725
BRANCH
inputRegionSubSurfaces
REVISION DETAIL
https://phabricator.kde.org/D7038
AFFECTED FI
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
device_notifier_qml_fix2
REVISION DETAIL
https://phabricator.kde.org/D15892
To: bruns, #frameworks, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezh
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> broulik wrote in devicenotificationsengine.cpp:39
> This potentially breaks applets relying on the structure of that name? Not
> sure how big of an issue this is as far as "API promise" we give for
> dataengi
cfeck added inline comments.
INLINE COMMENTS
> jtamate wrote in rgb.cpp:702
> Shouldn't it be QLatin1String("\x01\xda\x01")?
> startsWith has a QLatin1String overloaded method, but will it be used if a
> char* is used as argument or will it use the QString method? I just don't
> know the answer
madcatx added a comment.
@elvisangelaccio: OK, what do I have to do?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15873
To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andr
broulik added a comment.
I think this makes sense
INLINE COMMENTS
> devicenotificationsengine.cpp:39
> {
> -const QString source = QStringLiteral("notification %1").arg(m_id++);
> +const QString source = QStringLiteral("%1 notification").arg(udi);
>
This potentially breaks applets
32 matches
Mail list logo