KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 438 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/438/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Oct 2018 04:34:15 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 1

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System

shubham retitled this revision from "Warn user before copy/move job if required space exceeds the maximum volume size of a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System". REPOSITORY R241 KIO REVISION DETAIL

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System

shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System". REPOSITORY R241 KIO REVISION DETAIL

D16266: [Extractor] Make extractor crash resilient

bruns updated this revision to Diff 43777. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16266?vs=43769=43777 BRANCH mimetype_handling REVISION DETAIL https://phabricator.kde.org/D16266 AFFECTED FILES

D16267: [Extractor] Improve commandline debugging, forward stderr

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5ce6e8718bab: [Extractor] Improve commandline debugging, forward stderr (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16267?vs=43774=43776#toc REPOSITORY R293 Baloo

D16267: [Extractor] Improve commandline debugging, forward stderr

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, nice. REPOSITORY R293 Baloo BRANCH mimetype_handling REVISION DETAIL https://phabricator.kde.org/D16267 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc:

D16253: [Scheduler] Remove extraneous set of content indexing flag

This revision was automatically updated to reflect the committed changes. Closed by commit R293:efad0343a5c6: [Scheduler] Remove extraneous set of content indexing flag (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16253?vs=43757=43775

D16267: [Extractor] Improve commandline debugging, forward stderr

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case baloo_file is started from an interactive

D16253: [Scheduler] Remove extraneous set of content indexing flag

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16253 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D16256: [Scheduler] Reuse fileinfo from FilteredDirIterator

This revision was automatically updated to reflect the committed changes. Closed by commit R293:19e9edaec570: [Scheduler] Reuse fileinfo from FilteredDirIterator (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16256?vs=43749=43773 REVISION

D16256: [Scheduler] Reuse fileinfo from FilteredDirIterator

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH indexer_cleanup REVISION DETAIL https://phabricator.kde.org/D16256 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

ngraham added a comment. Very nice catch! I'm afraid my brain is not big enough to review this one though. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16254: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3807fd53d935: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16263: [Scheduler] Remove superfluous m_extractorIdle variable

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a8f03d1a374a: [Scheduler] Remove superfluous m_extractorIdle variable (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16263?vs=43767=43771

D16254: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH indexer_cleanup REVISION DETAIL https://phabricator.kde.org/D16254 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16263: [Scheduler] Remove superfluous m_extractorIdle variable

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16263 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D16197: provide a list of supported mimetypes for embeddedimagedata

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > embeddedimagedatatest.cpp:48 > +testAudioFile = testFilePath("test.opus"); > + >

D16266: [Extractor] Make extractor crash resilient

bruns updated this revision to Diff 43769. bruns marked 2 inline comments as done. bruns added a comment. coding style REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16266?vs=43768=43769 BRANCH mimetype_handling REVISION DETAIL

D16266: [Extractor] Make extractor crash resilient

bruns marked 3 inline comments as done. bruns added inline comments. INLINE COMMENTS > apol wrote in extractorprocess.cpp:35 > Shouldn't it check the exitCode too? the exitCode is "only valid for normal exits" (Qt docu ), and 0 otherwise. > apol

D15960: Don't check if file is directory based on mime-type

bruns added a comment. The reference to `QDirIterator` is misleading, as it applies only to the `UnIndexedFileIterator`, the `ModifiedFileIndexer` just receives paths. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks Cc: bruns,

D16266: [Extractor] Make extractor crash resilient

apol added inline comments. INLINE COMMENTS > extractorprocess.cpp:35 > +connect(_extractorProcess, QOverload QProcess::ExitStatus>::of(::finished), > +[=](int exitCode, QProcess::ExitStatus exitStatus) > +{ Shouldn't it check the exitCode too? >

D15795: Fix warnings about deprecated install dirs

bruns resigned from this revision. bruns added a comment. sorry, busy with other stuff REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15795 To: dinoh, apol, dfaure Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for this patch! There are a few things: 1. Let's check for this condition before doing a check for whether there's enough free space on the disk, or else it will

D16266: [Extractor] Make extractor crash resilient

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Connect to QProcess::finished to detect the exit status.

D16263: [Scheduler] Remove superfluous m_extractorIdle variable

bruns updated this revision to Diff 43767. bruns added a comment. add missing line to patch REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16263?vs=43762=43767 REVISION DETAIL https://phabricator.kde.org/D16263 AFFECTED FILES

D16265: [Scheduler] Use flag to track when a runner is going idle

bruns updated this revision to Diff 43766. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16265?vs=43765=43766 REVISION DETAIL https://phabricator.kde.org/D16265 AFFECTED FILES src/file/fileindexscheduler.cpp

D16265: [Scheduler] Use flag to track when a runner is going idle

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Only one runner should be queued/running at a given time,

D16263: [Scheduler] Remove superfluous m_extractorIdle variable

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Having the variable is quite pointless, as hardly anyone

D15763: Set correct image attributes on directory thumbnail

ngraham added a comment. +1 from me too. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef,

D16253: [Scheduler] Remove extraneous set of content indexing flag

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16253 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16253: [Scheduler] Remove extraneous set of content indexing flag

bruns updated this revision to Diff 43757. bruns added a comment. also write the id in replaceDocument, not only addDocument REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16253?vs=43745=43757 REVISION DETAIL https://phabricator.kde.org/D16253 AFFECTED

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

bruns added a comment. birthTime is supported by QTs QFileInfo::birthTime(). For the implementation, see here: https://code.woboq.org/qt5/qtbase/src/corelib/io/qfilesystemengine_unix.cpp.html#329 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham,

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16256: [Scheduler] Reuse fileinfo from FilteredDirIterator

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The FilteredDirIterator already builds a QFileInfo for

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Baloo uses the metadata change time (stat.st_ctime, man 7

D16254: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The mimetype is already determined in the iterator, no

D16253: [Scheduler] Remove extraneous set of content indexing flag

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The content indexing flag is already set by the

D16167: Instead of copying and clearing the file list, just move it

bruns added a comment. `auto runnable = new NewFileIndexer(m_db, m_config, std::exchange(m_newFiles, {}));` would work, but that is C++14 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16167 To: bruns, #baloo, #frameworks, poboiko Cc: kde-frameworks-devel,

D16167: Instead of copying and clearing the file list, just move it

bruns abandoned this revision. bruns added a comment. Does not work as wanted, as the compiler squeezes in a QStringList copy construction and the moves the temporary. Afterwards the temporary is empty(), but the filelist is not. REPOSITORY R293 Baloo REVISION DETAIL

D16250: Use lambdas instead of std::bind()

volkov added a comment. @davidedmundson Lambdas are more readable. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

shubham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16250: Use lambdas instead of std::bind()

ivan added a comment. @davidedmundson Lambdas are generally faster to compile and execute. `std::bind` can make code less verbose, but that is not the case here. @bruns Well... Qt has quite a few strange guidelines that we don't follow :) REPOSITORY R127 KWayland REVISION

D16250: Use lambdas instead of std::bind()

bruns added a comment. In D16250#344183 , @ivan wrote: > The parentheses are not necessary when a lambda has no arguments. > > [something]() { ::: } > > > can become: > > [something] { ::: } > > > > KWin uses

D16250: Use lambdas instead of std::bind()

davidedmundson added a comment. > Use lambdas instead of std::bind() Why? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin Cc: davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

D16250: Use lambdas instead of std::bind()

ivan added a comment. The parentheses are not necessary when a lambda has no arguments. [something]() { ::: } can become: [something] { ::: } KWin uses both of these from what I've seen. Personally, I prefer the second. Otherwise, +1 for the change. REPOSITORY

D16250: Use lambdas instead of std::bind()

volkov added a reviewer: KWin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16250 To: volkov, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16250: Use lambdas instead of std::bind()

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16250 AFFECTED FILES

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

shubham added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16165: Don't crash on invalid exiv2 data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5eee9ac75b7d: Dont crash on invalid exiv2 data (authored by poboiko). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16165?vs=43526=43736 REVISION DETAIL

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

shubham created this revision. shubham added a reviewer: ngraham. shubham added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. shubham requested review of this revision. REVISION SUMMARY BUG: 198772 TEST PLAN 1.Prepare copy/move job.

D12820: Add KWayland virtual desktop protocol

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH mart/plasmavirtualdesktop REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein, davidedmundson Cc: davidedmundson, zzag, bshah,

D15763: Set correct image attributes on directory thumbnail

anthonyfieroni added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,

D15510: Introduce HKDF

volkov added a comment. D16248 REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: bcooksley, dfaure

D15510: Introduce HKDF

bcooksley added a comment. This has made the FreeBSD CI builds unhappy unfortunately: https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20FreeBSDQt5.11/15/console Due to various issues, QCA isn't built on the Linux CI systems

D12820: Add KWayland virtual desktop protocol

mart added a comment. In D12820#297896 , @mart wrote: > RFC: add back some info for the layout? (in particular: rows and orientation, tought orientation is a bit concerning as is view-spacific) it was decided no, we care only about the