D15645: Add scheme selection menu with a "System" entry.

pino requested changes to this revision. pino added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcolorschememanager.cpp:52 > +QAction *const resetAction = new > QAction(index.data(Qt::DecorationRole).value(), > +

D15645: Add scheme selection menu with a "System" entry.

ngraham added a comment. Thanks, that lets it compile. I'm feeling a bit stupid right now, so could you help me figure out what's needed to test this? `kcolorschemedemo.cpp` does not actually seem to build an executable. Regardless, wouldn't it make sense to expose this new feature in the

D16471: [RFC] Listen for added DBus interfaces instead of registered services

fvogt updated this revision to Diff 44334. fvogt added a comment. Fix bad merge REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16471?vs=44332=44334 BRANCH ifadded REVISION DETAIL https://phabricator.kde.org/D16471 AFFECTED FILES

D16471: [RFC] Listen for added DBus interfaces instead of registered services

fvogt created this revision. fvogt added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY When the service is registered, the interfaces might not be available yet. So wait for those instead. BUG: 400359

D16464: [KSambaShare] Trim trailing / from share path

bruns edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16465: [KSambaShare] Make "net usershare info" parser testable

bruns retitled this revision from "[KSambaShare] Make "net usershare list" parser testable" to "[KSambaShare] Make "net usershare info" parser testable". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16465 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel,

D16466: [KSambaShare] Add unit test for "net usershare info" parser

bruns retitled this revision from "[KSambaShare] Add unit test for "net usershare list" parser" to "[KSambaShare] Add unit test for "net usershare info" parser". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16466 To: bruns, #frameworks, broulik Cc:

D16465: [KSambaShare] Make "net usershare list" parser testable

bruns added a dependent revision: D16466: [KSambaShare] Add unit test for "net usershare list" parser. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16465 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16464: [KSambaShare] Trim trailing / from share path

bruns added a dependent revision: D16466: [KSambaShare] Add unit test for "net usershare list" parser. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16464 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare list" parser

bruns created this revision. bruns added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The existing tests depend on the runtime environment, i.e. they read the

D16465: [KSambaShare] Make "net usershare list" parser testable

bruns created this revision. bruns added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY KSambaSharePrivate::sync() reads from the runtime environment of the user and

D16464: [KSambaShare] Trim trailing / from share path

bruns created this revision. bruns added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When adding usershares manually on the command line, it is common to have a

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- (Updated Oct. 27, 2018, 4:38 p.m.) Status -- This change has been

D16421: Improve emblem contrast, legibility and consistency

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

ndavis added a comment. In D16421#349331 , @ngraham wrote: > Thanks for the updates. I know it's a PITA, but would you mind updating the image in the Summary section? Done. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

ndavis updated this revision to Diff 44313. ndavis added a comment. Add 16 and 22 px versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44308=44313 BRANCH emblem-outlines (branched from master) REVISION DETAIL

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 189 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/189/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 27 Oct 2018 15:31:29 + Build duration: 6 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 245 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/245/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 27 Oct 2018 15:31:29 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 188 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/188/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 27 Oct 2018 15:15:30 + Build duration: 2 min 43 sec and counting CONSOLE OUTPUT

D14632: keyword rule: Spport for keywords inclusion from another language/file

cullmann added a comment. I merged that now. I bumped the version + required kate version Git commit f2c29ec618da08ebe9d17ff739e8b12bf3c33fff by Christoph Cullmann. Committed on 27/10/2018 at 15:14.

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 244 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/244/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 27 Oct 2018 15:15:04 + Build duration: 46 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 187 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/187/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 27 Oct 2018 15:12:34 + Build duration: 2 min 55 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 243 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/243/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 27 Oct 2018 15:12:34 + Build duration: 50 sec and counting CONSOLE OUTPUT

D14632: keyword rule: Spport for keywords inclusion from another language/file

This revision was automatically updated to reflect the committed changes. Closed by commit R216:83a5c8ce9882: keyword rule: Spport for keywords inclusion from another language/file (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D16421: Improve emblem contrast, legibility and consistency

ndavis updated this revision to Diff 44308. ndavis added a comment. Add dark versions of previous change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44304=44308 BRANCH emblem-outlines (branched from master) REVISION DETAIL

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16415 To: phily, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel,

D16416: z/OS CLIST file syntax highlighting

cullmann added a comment. To properly push it with you as author, what is your full name + mail address? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16416 To: phily, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann,

D16416: z/OS CLIST file syntax highlighting

cullmann accepted this revision. cullmann added a comment. I can add the test for you, otherwise this look ok to go in. Thanks for the contribution. The Alert include is missing, but I am not sure if it is really needed ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D16421: Improve emblem contrast, legibility and consistency

ngraham added a comment. Thanks for the updates. I know it's a PITA, but would you mind updating the image in the Summary section? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg,

D16421: Improve emblem contrast, legibility and consistency

ndavis updated this revision to Diff 44304. ndavis added a comment. Improve arrow visibility on vcs emblems Add emblem-encrypted-locked Change emblem-locked back to orange REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16421?vs=44248=44304 BRANCH

D16414: Changes to REXX syntax highlighting

cullmann closed this revision. cullmann added a comment. Hmpf, arc failed :/ But the stuff is in at least: Git commit e07306d9c22f6426d6b50287eee532555d74ac75 by Christoph Cullmann. Committed on 27/10/2018 at 14:36. Pushed by cullmann into branch 'master'. add test file +

D16414: Changes to REXX syntax highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the test file, I fixed the no longer existing ref and pushed the stuff! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16414

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

cullmann added a comment. Hi, could one remove the two hard-coded colors and just use a different builtin defStyleNum? Beside that, have you some small example script that we could add as auto-test? e.g. something perhaps a bit larger than the snippets I can find on

D16414: Changes to REXX syntax highlighting

phily updated this revision to Diff 44283. phily added a comment. Removed typo in test script REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16414?vs=44282=44283 REVISION DETAIL https://phabricator.kde.org/D16414 AFFECTED FILES

D16414: Changes to REXX syntax highlighting

phily updated this revision to Diff 44282. phily added a comment. Did not include the syntax file itself in my last update, now the diff includes both. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16414?vs=44281=44282 REVISION DETAIL

D16414: Changes to REXX syntax highlighting

phily updated this revision to Diff 44281. phily added a comment. Added test file to autotests/input/test.rexx as well as upgrading the version number REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16414?vs=44180=44281 REVISION DETAIL