D16929: Remove dead search provider

cgiboudeaux added a comment. In D16929#360570 , @vkrause wrote: > Remove more dead search providers, just checking for non-resolving domains isn't enough. mmh.. http://www.cnrtl.fr/definition/$something works fine here REPOSITORY R241

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

rjvbb added a comment. > Btw., the 2 nullptr in the disconnect can be left out, or? Not to my understanding. From the docs: Disconnect everything connected to a specific signal: disconnect(myObject, SIGNAL(mySignal()), 0, 0); equivalent to the non-static overloaded

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

cullmann added a comment. Btw., the 2 nullptr in the disconnect can be left out, or? + a comment for the future would be nice in the code REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16927 To: rjvbb, #ktexteditor, #frameworks, cullmann Cc: cullmann,

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16927 To: rjvbb, #ktexteditor, #frameworks, cullmann Cc: cullmann, kde-frameworks-devel,

D16934: Add help-browser symlink to 16px and 22px directories

trickyricky26 edited the summary of this revision. trickyricky26 added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16934 To: trickyricky26, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16934: Add help-browser symlink to 16px and 22px directories

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-help-browser-symlink (branched from master) REVISION DETAIL

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 updated this revision to Diff 45611. trickyricky26 added a comment. This revision is now accepted and ready to land. - Fix naming of ascending and descending versions; make ascending versions less confusing; fix symlink sort-name I have flipped the naming of the ascending

D16929: Remove dead search provider

vkrause retitled this revision from "Remove dmoz search provider" to "Remove dead search provider". vkrause edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16929 To: vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16929: Remove dmoz search provider

vkrause updated this revision to Diff 45609. vkrause added a comment. Remove more dead search providers, just checking for non-resolving domains isn't enough. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16929?vs=45605=45609 BRANCH master REVISION

D16931: Extract more tags from exif metadata

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Extract more metadata from exif that can be easily mapped to the

D16931: Extract more tags from exif metadata

astippich added a dependency: D16617: fix extraction of GPS altitude for exif data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16931 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16617: fix extraction of GPS altitude for exif data

astippich added a dependent revision: D16931: Extract more tags from exif metadata. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 added a comment. So you're saying the direction of the arrows is consisten with the current way, as long as the ascending and descending names are switched, correct? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg,

D16930: Android: improve clang support

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks ok to me, less stuff to set manually is always good. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D16930 To: apol,

D12114: Revive 'Description' property for DublinCore metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R286:103f86746b8a: Revive Description property for DublinCore metadata (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16930: Android: improve clang support

apol created this revision. apol added reviewers: Build System, Android, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Infer the toolchain we are using through

D16929: Remove dmoz search provider

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Service is dead. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16929

D16196: add a description property to KFileMetaData

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:32c1e88ed922: add a description property to KFileMetaData (authored by astippich). REPOSITORY R286 KFileMetaData

Re: Regression in Frameworks - DBus Hangs

On Sat, Nov 17, 2018 at 4:30 AM David Edmundson wrote: > > > Don't thank me yet, I locked up one of the build jobs, sorry. > https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.9/380/console Diagnostic output available from D-Bus: jenkins@6934489e2599:~> qdbus

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

cfeck added a comment. On lists that are sorted alphabetically A-Z (i.e. ascending), the first item is at the top, the last at the bottom. That's why user interfaces show an arrow pointing down; they show the direction of item "flow". REPOSITORY R266 Breeze Icons REVISION DETAIL

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

emateli added a comment. @trickyricky26 I think we should stick to whatever conventions the KDE community has. I checked with Dolphin and the arrow goes up for descending and up for ascending, however the VDG makes these calls in the end. REPOSITORY R266 Breeze Icons REVISION DETAIL

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 planned changes to this revision. trickyricky26 added a comment. @emateli 1. You're absolutely right about that, don't know how I missed this. With the correct naming, should the arrows still point to the end with longer lines? 2. They are sorted, but some lines were

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

emateli added a comment. 1. Aren't the names in reverse? `view-sort-ascending` shows a list in descending order 2. In `view-sort-descending` the items are not even sorted. Not sure how i feel about that. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master)

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 retitled this revision from "Add a generic sorting options icon" to "Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme". trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY

D16905: Add a generic sorting options icon

trickyricky26 updated this revision to Diff 45599. trickyricky26 edited the test plan for this revision. trickyricky26 added a comment. This revision is now accepted and ready to land. - Add new generic sorting icons, rename existing ordered sorting icons to -name scheme (see updated

D16905: Add a generic sorting options icon

ngraham added a comment. All right, let's go with that. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

trickyricky26 added a comment. | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | - | --- | - | -- | | `16px`| F6427148: view-sort-16.svg.png

D16905: Add a generic sorting options icon

ngraham added a comment. I prefer that version, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

trickyricky26 added a comment. This is how the set looks with the arrows above the lines in the descending versions: | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | - | --- | - | --

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16927 To: rjvbb, #ktexteditor, #frameworks Cc: kde-frameworks-devel, kwrite-devel, michaelh, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D16905: Add a generic sorting options icon

ngraham added a comment. For the `-descending` versions, could we consider moving the arrows up so they don't obscure some of the horizontal lines? The effect is okay for the larger versions, but I think it doesn't work for the 16px version because the descending nature of the lines is

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360449 , @trickyricky26 wrote: > I wasn't quite sure if I should use 2px strokes in the `32px` versions, so I used 1px for now as that is more consistent with the rest. > If there are no more suggestions, I

D16925: Use HTTPS for all search providers that support it

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ce74ff959524: Use HTTPS for all search providers that support it (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16925?vs=45594=45595 REVISION

D16905: Add a generic sorting options icon

trickyricky26 added a comment. I made all necessary versions of these icons (`24px` not shown since they're the same as `22px`): | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | -- | --- | - | -- | |

D16925: Use HTTPS for all search providers that support it

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16925 To: vkrause, #frameworks, cfeck, elvisangelaccio, pino, apol Cc: apol,

D16925: Use HTTPS for all search providers that support it

ngraham added reviewers: Frameworks, cfeck, elvisangelaccio, pino. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16925 To: vkrause, #frameworks, cfeck, elvisangelaccio, pino Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16919: Re-add DBus test

hindenburg added a comment. yea - feel free to commit any changes related to this yourself if you want. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hindenburg Cc: hindenburg, konsole-devel, ngraham,

Re: Regression in Frameworks - DBus Hangs

Don't thank me yet, I locked up one of the build jobs, sorry. https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.9/380/console >Pipeline kf5-qt5 SUSEQt5.9 Output isn't too helpful, though I am surprised to see kf5.kinit.klauncher in the logs when I'm supposedly invoking

D16925: Use HTTPS for all search providers that support it

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This still has to be propagated through all translations to take effect though. REPOSITORY R241 KIO BRANCH

D16919: Re-add DBus test

davidedmundson added a comment. CI seems to be frozen again. :( REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hindenburg Cc: hindenburg, konsole-devel, ngraham, maximilianocuria

D16919: Re-add DBus test

This revision was automatically updated to reflect the committed changes. Closed by commit R319:3eb9a34f62c8: Re-add DBus test (authored by davidedmundson, committed by hindenburg). REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16919?vs=45568=45591 REVISION

D16919: Re-add DBus test

hindenburg accepted this revision. hindenburg added a comment. This revision is now accepted and ready to land. Thanks so much for looking into this. REPOSITORY R319 Konsole BRANCH master REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks,

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. Something side-ways related: I went down this hole because cmake's `generate_export_header` failed because of an unsupported flag that was added. Regardless of how we implement things here, shouldn't there be something like `ecm_generate_export_header` which empties

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. > Thus these places need to be turned into: > > ... > if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "3.8") > elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS

D16905: Add a generic sorting options icon

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. I don't like the hiding of the if-branches as argument to macro. We shouldn't to this as it makes the code harder to understand. The general issue with the existing code here

Re: Regression in Frameworks - DBus Hangs

On Fri, Nov 16, 2018 at 11:04 PM David Edmundson wrote: > > A running KJob would not show in a backtrace. > > Update at https://phabricator.kde.org/D16919 Ah I see. Thanks for taking a look into that. Cheers, Ben

D16919: Re-add DBus test

davidedmundson created this revision. davidedmundson added reviewers: Konsole, Frameworks. Herald added a project: Konsole. Herald added a subscriber: konsole-devel. davidedmundson requested review of this revision. REVISION SUMMARY Ported from KProcess::startDetached to a QProcess we can kill

Re: Regression in Frameworks - DBus Hangs

A running KJob would not show in a backtrace. Update at https://phabricator.kde.org/D16919

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system Cc: apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb retitled this revision from "[ECM] use a macro to test compiler flag support" to "[ECM] use a macro to add compiler flags conditionally". rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D16894: [ECM] use a macro to test compiler flag support

rjvbb updated this revision to Diff 45567. rjvbb added a comment. A simpler version, setting CMAKE__FLAGS directly (also fixes a persistence error in my previous implementation). I've thought some more about "why not just use check__compiler_flag everywhere". I think that the risk with

Re: Regression in Frameworks - DBus Hangs

On Wed, Nov 14, 2018 at 8:17 AM Ben Cooksley wrote: > > On Tue, Nov 13, 2018 at 2:25 PM David Edmundson > wrote: > > > > I don't think application CI jobs run with workspace available. I also > > can't think of anything that's been merged in workspace. > > That's correct. CI Jobs are only

D16643: Correct the accept flag of the event object on DragMove

hein added a comment. @mart ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16196: add a description property to KFileMetaData

astippich added a comment. I'm gonna merge this tonight to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,