D17495: [KMessageBox] Fix minimum dialog size when details are requested

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17495 To: cfeck, ngraham, elvisangelaccio, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.9 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.9/69/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 06:51:50 + Build duration: 3 min 6 sec and counting JUnit Tests Name:

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.11 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 06:51:50 + Build duration: 3 min 14 sec and counting JUnit Tests Name:

D17497: A minor typo in ipv4 test

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7036e0ade135: A minor typo in ipv4 test (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17497?vs=47321=47322 REVISION DETAIL

D17497: A minor typo in ipv4 test

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17497 To: pranavgade, jgrulich, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. If you get deleted in-between that, the slot is never called again by the timer. That means you are save. It will just naturally stop work if the widget/... is destroyed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To:

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > everything could have happened, e.g. the search bar got deleted because the view got delete OK, but I still do not see why that will be different with that singleShot approach. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459

D17436: BrightScript: Remove unused keyword list 'end'

dlevin added a comment. Thanks for the fix, yes it is valid. Previously "end" was used as a standalone keyword, but keyword requires space after the word. Now it used in StringDetect to detect cases like "end sub" and "endsub" in the same rule. REPOSITORY R216 Syntax Highlighting

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. After you return from processEvents, everything could have happened, e.g. the search bar got deleted because the view got delete => all things you do afterwards might do "something". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459

D17474: A minor bug in ipv4 and ipv6 test

pranavgade added a comment. In D17474#374522 , @pranavgade wrote: > This change causes the ipv4 address test to fail due to a difference in size of list. > [F6468448 ] D17497: A minor typo in

D17497: A minor typo in ipv4 test

pranavgade created this revision. pranavgade added reviewers: jgrulich, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY A minor typo in ipv4setting test was causing the test to fail after

D17496: Change network/web color icons to consistent style

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17496 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17496: Change network/web color icons to consistent style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old style didn't match the sharp, grid aligned style of most Breeze icons and there

D17466: Fix doxygen markdown rendering

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. As discussed or IRC REPOSITORY R264 KApiDox BRANCH fix_yaml_rendering REVISION DETAIL https://phabricator.kde.org/D17466 To: argonel, apol Cc: apol, kde-frameworks-devel,

D17466: Fix doxygen markdown rendering

apol added a comment. ~~~{.yaml} hallo ~~~ But then it doesn't work here. Is it maybe possible to force the usage of github markdown on it? REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D17466 To: argonel Cc: apol, kde-frameworks-devel, kde-doc-english,

D17466: Fix doxygen markdown rendering

argonel added a comment. The use of tildes for doxygen code blocks is documented here: https://www.stack.nl/~dimitri/doxygen/manual/markdown.html#md_fenced REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D17466 To: argonel Cc: apol, kde-frameworks-devel,

Re: KDE Frameworks web page

El dilluns, 10 de desembre de 2018, a les 14:43:14 CET, Jonathan Riddell va escriure: > Frameworks has no web page and the announcements still point to the > 5.0 announcement for more information. > > So here's a proposal for adding to kde.org/products/ > >

D17495: [KMessageBox] Fix minimum dialog size when details are requested

cfeck edited the test plan for this revision. cfeck added reviewers: ngraham, elvisangelaccio. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17495 To: cfeck, ngraham, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17495: [KMessageBox] Fix minimum dialog size when details are requested

cfeck created this revision. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. cfeck requested review of this revision. REVISION SUMMARY QLabel with wordWrap enabled still needs the minimumSize workaround, which conflicts with the

D17460: fixups for `extern` and `pragma`

dhaumann added a comment. Could you also extend the unit test in autotest/input/highlight.d? See e.g.: https://github.com/KDE/syntax-highlighting/commit/66367f8e636623a2dbb8ee6add9c7f36683605a2 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17460

D17441: tune editing actions for large number of small edits

cullmann added a comment. In D17441#374925 , @ngraham wrote: > In D17441#374924 , @dhaumann wrote: > > > I guess it's ok to have this in. But please use this version at your daily work ;) I think

D17441: tune editing actions for large number of small edits

ngraham added a comment. In D17441#374924 , @dhaumann wrote: > I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers... I always use Kate from git master. Is there anything

D17441: tune editing actions for large number of small edits

dhaumann added a comment. I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: anthonyfieroni,

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. You can't really do that in threads, you need to access the buffer, otherwise you can redo all things again in extra logic (like using the ranges for getting replacement ranges) I still think the normal single shot stuff should do the trick in most cases.

D17459: SearchBar: Add Cancel button to stop long running tasks

brauch added a comment. I would also advise against calling processEvents() to keep UIs responsive in all cases. It's tempting, but it is near impossible to get it right. What about conflicting actions, close/resize events, dbus calls, etc etc that are handled here? I think the right

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Hmpf! Some googling didn't help. Just some thoughts. - Adding a couple of checks where ever just to block in case of a running S could be a little cumbersome - What we need would be an QObject::processEvents, so that only the Cancle button is a live but no

D17491: Fix documentation, QValueList isn't a thing anymore

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D17491 AFFECTED

D17466: Fix doxygen markdown rendering

apol added a comment. If we are doing markdown, it could make sense why such common markdown isn't working too, otherwise this is bound to happen anyway. I've actually never seen this ~~~ thing. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D17466 To: argonel Cc:

D17479: Fix build without phonon

This revision was automatically updated to reflect the committed changes. Closed by commit R305:78a1dcc794f5: Fix build without Phonon (authored by heikobecker). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17479?vs=47283=47288 REVISION DETAIL

D17469: applications-games icon for dark theme

abetts added a comment. It's looking good. I would say change the last tone to a tad lighter. The gray has too much black in it. I would probably move the hue to the yellow side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze,

D17479: Fix build without phonon

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh la la, I didn't even realize phonon was optional. New code is much better. REPOSITORY R305 KNotifyConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D17479 To:

D17425: Added DCB settings

pranavgade retitled this revision from "dcb settings" to "Added DCB settings". pranavgade edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: cfeck, kde-frameworks-devel, michaelh, ngraham,

D17425: dcb settings

cfeck added a comment. Please keep the Repository settings. Additionally, please format the title and description according to https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425

D17480: Fix warnings

apol closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D17480 To: apol, #frameworks, mart, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17425: dcb settings

cfeck set the repository for this revision to R282 NetworkManagerQt. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17479: Fix build without phonon

broulik added a reviewer: sitter. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D17479 To: heikobecker, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17480: Fix warnings

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D17480 To: apol, #frameworks, mart, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17480: Fix warnings

apol created this revision. apol added reviewers: Frameworks, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Now it doesn't complain about being undefined anymore REPOSITORY R858 Qt Quick Controls 2:

D17479: Fix build without phonon

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY f6d55baf5aa88eaab6b2f96c025064f081d13cea

D17425: dcb settings

pranavgade updated this revision to Diff 47282. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47279=47282 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17469: applications-games icon for dark theme

ndavis added a comment. In D17469#374557 , @guoyunhe wrote: > In D17469#374494 , @ndavis wrote: > > > Here's a rough draft of something similar to the Logitech F 710, but with colors that are more

D17425: dcb settings

jgrulich added a comment. This was last round, otherwise it's ready to go, just fix the remaining issues. Thanks. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsettingtest.cpp:28 > +#include > +#include > + Include not needed. > dcbsetting.cpp:220 > +} else { > +return false; > +} You can remove the else branch and have just return false. > dcbsetting.cpp:254 > +} else { > +

D17469: applications-games icon for dark theme

ndavis added a comment. In D17469#374605 , @ngraham wrote: > This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it. An outline would not look

D17425: dcb settings

pranavgade updated this revision to Diff 47279. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47270=47279 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

cfeck set the repository for this revision to R282 NetworkManagerQt. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

ngraham added subscribers: pstefan, ngraham. ngraham added a comment. This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it. REPOSITORY R266 Breeze Icons REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > That always leads to evil things, like e.g. what happens if you press the X button of the view/window during that. I assume you have read that article a longer time ago and have these paragraph regarding `Manual event processing` in mind. > This

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47275. loh.tar added a comment. - Check every 500 lines or 100 machtes, whatever is first - Fix false check due to wrong math as long no match was found REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsettingtest.cpp:30 > + > +typedef QList UintList; > + Why? This type is defined in generictypes.h. > dcbsetting.h:30 > + > +typedef QList UintList; > + Again, this is defined in generictypes.h. > pranavgade wrote in dcbsetting.h:49 > I

KDE Frameworks web page

Frameworks has no web page and the announcements still point to the 5.0 announcement for more information. So here's a proposal for adding to kde.org/products/ https://www.kde.org/products/frameworks/ Are the highlights still the best we can choose? Are there any example applications we can

D17469: applications-games icon for dark theme

guoyunhe added a comment. In D17469#374494 , @ndavis wrote: > Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller

D17425: dcb settings

pranavgade added a comment. Sorry, I had forgot about that. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

pranavgade updated this revision to Diff 47270. pranavgade marked 6 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47267=47270 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.11 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 10 Dec 2018 12:03:36 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.9 - Build # 68 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.9/68/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 10 Dec 2018 12:03:36 + Build duration: 4 min 5 sec and counting JUnit Tests Name:

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.h:89 > +bool priorityFlowControl(quint32 userPriority) const; > +void setPriorityFlowControl(UintList list); > +UintList priorityFlowControl() const; const UintList > dcbsetting.h:94 > +quint32

D17474: A minor bug in ipv4 and ipv6 test

This revision was automatically updated to reflect the committed changes. Closed by commit R282:2edc30be9f3e: A minor bug in ipv4 and ipv6 test (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17474?vs=47268=47269 REVISION

D17474: A minor bug in ipv4 and ipv6 test

pranavgade added a comment. This change causes the ipv4 address test to fail due to a difference in size of list. [F6468448 ] REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17474 To: pranavgade, jgrulich Cc:

D17474: A minor bug in ipv4 and ipv6 test

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Some QCOMPAREs were comparing a value in a map with itself. Fixed.

D17425: dcb settings

pranavgade updated this revision to Diff 47267. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47263=47267 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.h:106 > +/ > +void setPriorityFlowControlList(UintList list); > +UintList priorityFlowControlList() const; Move them please among the rest of methods, so all related methods are next to each other. Also use please

D17469: applications-games icon for dark theme

ndavis added a comment. Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original DualShock controller and white Xbox 360 controller: 100% F6468233: Screenshot_20181210_062352.png

D17419: Add view-private icon

ndavis added a comment. Here's a rough draft of something similar to the F710 , but with colors that are more similar to the original DualShock controller and white Xbox 360 controller: 100% F6468233: Screenshot_20181210_062352.png

D17425: dcb settings

pranavgade updated this revision to Diff 47263. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47261=47263 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in dcbsetting.cpp:59 > Yes please. Okay, im on it But on the other hand, it will add 12 functions unnecessarily REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh,

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > pranavgade wrote in dcbsetting.cpp:59 > Yeah, that would help. > Do you think I should do that? Yes please. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

pranavgade updated this revision to Diff 47261. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47253=47261 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.cpp:59 > + > +for (int i = 0; i < 8; ++i) setPriorityFlowControl(i, > other->priorityFlowControl(i)); > +for (int i = 0; i < 8; ++i) setPriorityBandwidth(i, > other->priorityBandwidth(i)); This is odd, maybe we should

D17469: applications-games icon for dark theme

ndavis added reviewers: VDG, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

ndavis added a comment. In general, color icons are the same in Breeze and Breeze Dark while monochrome icons change their primary color. I think the light and dark versions of this icons should be the same. I think the overall design of this icon needs to be changed though. The

D17425: dcb settings

pranavgade marked 12 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

emateli added a comment. @anishgiri What is the advantage of using this outlined version of the Konsole icon(which we haven't seen in a light scheme yet) compared to using one of the monochrome icons already available? REPOSITORY R266 Breeze Icons REVISION DETAIL

D17469: applications-games icon for dark theme

guoyunhe updated this revision to Diff 47254. guoyunhe added a comment. Clean up Inkscape metadata REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=47251=47254 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17469 AFFECTED

D17425: dcb settings

pranavgade updated this revision to Diff 47253. pranavgade marked 15 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47243=47253 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in dcbsetting.cpp:464 > Oh, right, you don't have methods for that. In that case you can again use > Q_D(const DcbSetting) and push there d->priorityFlowControl and others. I can use Q_D in fromMap, but i get this error in

D17469: applications-games icon for dark theme

guoyunhe updated this revision to Diff 47251. guoyunhe added a comment. Add modified icon with light background REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=47245=47251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17469

D17469: applications-games icon for dark theme

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17469 AFFECTED FILES

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.cpp:53 > + > +for (int i = 0; i < 8; ++i) setPriorityFlowControl(i, > other->priorityFlowControl(i)); > +for (int i = 0; i < 8; ++i) setPriorityBandwidth(i, > other->priorityBandwidth(i)); Not this way. > pranavgade wrote

D17425: dcb settings

pranavgade marked an inline comment as done. pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in dcbsetting.cpp:31 > You can initialize also all the lists here, because they have default values > as well. how do i do that? i am getting this error: error: class

D17425: dcb settings

pranavgade updated this revision to Diff 47243. pranavgade marked 7 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47235=47243 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt