KDE CI: Frameworks » kdeclarative » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Failure!

2019-03-03 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 04 Mar 2019 05:59:50 + Build duration: 1 hr 54 min and counting CONSOLE OUTPUT

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

2019-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:514835418c9d: Restore FindFontconfig backward compatibility for plasma-desktop (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D19438: Add syntax definition for Elm language to syntax-highlighting

2019-03-03 Thread Bonghyun Kim
bonghyunkim planned changes to this revision. bonghyunkim added a comment. In D19438#422676 , @dhaumann wrote: > Could you elaborate what Elm is used for? > Also, could you please provide a small test file (also MIT licensed) that we can use

D19461: Logcat: fix dsError color with underline="0"

2019-03-03 Thread Nibaldo González
nibags added a comment. Not seem, from what I see it is a recent bug. I just checked it in KDE Frameworks 5.48.0 (Fedora 28) and it works correctly REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19461 To: nibags, #framework_syntax_highlighting,

D19501: Do not use deprecated KUrlRequester::fileDialog()

2019-03-03 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R317:32502e83a1a6: Do not use deprecated KUrlRequester::fileDialog() (authored by aspotashev). REPOSITORY R317 Kross CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19501?vs=53090=53100

D19461: Logcat: fix dsError color with underline="0"

2019-03-03 Thread Nibaldo González
nibags updated this revision to Diff 53099. nibags added a comment. - Add tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19461?vs=52939=53099 BRANCH logcat-fix-error-color REVISION DETAIL https://phabricator.kde.org/D19461 AFFECTED

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 07:17:39 + Build duration: 4 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 06:04:14 + Build duration: 1 hr 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 18 - Fixed!

2019-03-03 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 06:03:23 + Build duration: 1 hr 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 06:03:31 + Build duration: 1 hr 8 min and counting BUILD ARTIFACTS

D19503: Improve code: Remove temp container just to iterate

2019-03-03 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove temp container TEST PLAN autotest ok REPOSITORY R283 KAuth BRANCH

D19298: Make it compile without foreach

2019-03-03 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R283:cd7490e85008: Make it compile without foreach (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19298?vs=52526=53097#toc REPOSITORY R283 KAuth CHANGES SINCE LAST

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 05:59:34 + Build duration: 1 hr 3 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

2019-03-03 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 05:59:50 + Build duration: 52 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 05:59:41 + Build duration: 50 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/38/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 06:33:11 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 06:03:23 + Build duration: 38 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 05:57:19 + Build duration: 44 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Mar 2019 05:57:09 + Build duration: 41 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 06:03:31 + Build duration: 34 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 15 - Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/15/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 06:01:09 + Build duration: 37 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/37/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 06:04:14 + Build duration: 28 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 06:03:31 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 24 - Fixed!

2019-03-03 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/24/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 06:03:23 + Build duration: 27 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 06:02:53 + Build duration: 26 min and counting JUnit Tests Name: projectroot

D19442: [Kfilemetada] Make it compile without foreach

2019-03-03 Thread Laurent Montel
mlaurent added a comment. Arg it was commited by error I reverted it REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19442 To: mlaurent, dfaure, apol, bruns Cc: bruns, astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, spoorun,

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 06:02:44 + Build duration: 25 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 06:01:09 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/48/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 05:59:34 + Build duration: 21 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 05:59:34 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdeclarative » kf5-qt5 SUSEQt5.10 - Build # 16 - Failure!

2019-03-03 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20SUSEQt5.10/16/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 05:59:50 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Failure!

2019-03-03 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 05:59:50 + Build duration: 16 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/13/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 05:59:42 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 05:59:41 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 05:58:19 + Build duration: 13 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 05:57:19 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 05:57:19 + Build duration: 8 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Mar 2019 05:57:09 + Build duration: 6 min 56 sec and counting JUnit Tests Name:

D19442: [Kfilemetada] Make it compile without foreach

2019-03-03 Thread Laurent Montel
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R286:fcb1ec08bde9: [Kfilemetada] Make it compile without foreach (authored by mlaurent). REPOSITORY R286 KFileMetaData

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 04 Mar 2019 05:57:09 + Build duration: 6 min 35 sec and counting BUILD ARTIFACTS

Re: generating emoticon themes from emoji fonts

2019-03-03 Thread Aleix Pol
On Sun, Mar 3, 2019 at 11:37 AM René J.V. Bertin wrote: > > Hi, > > Is there a tool that can be used to generate themes for KEmoticons from TTF > fonts like Apple Colour Emoji or even "mixed" fonts like Segoe UI Symbol, > preferably with a selectable resolution/size for the generated images? >

D19501: Do not use deprecated KUrlRequester::fileDialog()

2019-03-03 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R317 Kross BRANCH fix-deprecated REVISION DETAIL https://phabricator.kde.org/D19501 To: aspotashev, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19501: Do not use deprecated KUrlRequester::fileDialog()

2019-03-03 Thread Alexander Potashev
aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REPOSITORY R317 Kross BRANCH fix-deprecated REVISION DETAIL https://phabricator.kde.org/D19501 AFFECTED FILES

D19500: [KDirModel] Fix job urls change signal connection

2019-03-03 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, jtamate. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The private slot declaration for `_k_slotJobUrlsChanged` got removed as part

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19499 To: vkrause, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

2019-03-03 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D18943#424029 , @vkrause wrote: > What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop... kdelibs4support provides one. REPOSITORY R240 Extra CMake

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

2019-03-03 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY I don't understand where plasma-desktop actually finds that old find module, but this

D18943: Add Fontconfig find modudle

2019-03-03 Thread Volker Krause
vkrause added a comment. D19499 fixes that here REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18943 To: vkrause, cgiboudeaux Cc: matthieugras, kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

D18943: Add Fontconfig find modudle

2019-03-03 Thread Volker Krause
vkrause added a comment. In D18943#423969 , @matthieugras wrote: > This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst). Confirmed on a clean rebuild here too.

D19498: loadLibrary: Use enum values to define what type of plugin we load

2019-03-03 Thread Alexander Potashev
aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REVISION SUMMARY Enum values are more lightweight and easier to compare than strings. TEST PLAN The manual test

D19494: [kconfigwidgets] make it compile without foreach

2019-03-03 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R265:386ea3a786f5: [kconfigwidgets] make it compile without foreach (authored by mlaurent). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19494?vs=53071=53081

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Mar 2019 19:58:33 + Build duration: 33 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 30 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Mar 2019 19:58:33 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/47/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 19:58:33 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D19494: [kconfigwidgets] make it compile without foreach

2019-03-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Remember to check that the loop doesn't modify the variable that it's iterating over, btw. Seems fine here. REPOSITORY R265 KConfigWidgets BRANCH compile_without_foreach

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-03-03 Thread Peter Wu
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d8fcc1e8c62c: Fix Invalid URL: QUrl(some.txt) warnings in Save dialog (authored by Lekensteyn). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19027?vs=53066=53080

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-03-03 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19027 To: Lekensteyn, ngraham, dfaure, fvogt, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

2019-03-03 Thread Matthieu Gras
matthieugras added a comment. This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst). REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18943 To: vkrause, cgiboudeaux Cc:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 17:35:12 + Build duration: 3 min 15 sec and counting JUnit Tests Name:

D19494: [kconfigwidgets] make it compile without foreach

2019-03-03 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R265 KConfigWidgets

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 17:07:12 + Build duration: 1 min 1 sec and counting JUnit Tests Name:

D18915: Fix batchrename changing extension to lower case

2019-03-03 Thread cfoster
cfoster updated this revision to Diff 53068. cfoster added a comment. - Change GetFileExtension to take QString REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=52691=53068 BRANCH arcpatch-D18915 REVISION DETAIL https://phabricator.kde.org/D18915

D18915: Fix batchrename changing extension to lower case

2019-03-03 Thread cfoster
cfoster marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-03-03 Thread Peter Wu
Lekensteyn updated this revision to Diff 53066. Lekensteyn marked 2 inline comments as done. Lekensteyn added a comment. @dfaure I've replaced the outdated comment, how does this version look? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19027?vs=51736=53066

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-03-03 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. OK. I'm open to being convinced out of my crazy idea. :) In any event, this is good. Thanks for your work on this @chinmoyr! REPOSITORY R241 KIO BRANCH arcpatch-D10663 REVISION DETAIL https://phabricator.kde.org/D18904 To:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 29 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Mar 2019 13:23:07 + Build duration: 15 min and counting BUILD ARTIFACTS

D19491: generic config interface

2019-03-03 Thread Christoph Cullmann
cullmann updated this revision to Diff 53063. cullmann added a comment. better error checking for ::value fix coding style REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19491?vs=53060=53063 BRANCH arcpatch-D19491 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 46 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/46/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 13:23:07 + Build duration: 7 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/42/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Mar 2019 13:23:07 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

D19170: Fix crash while moving files

2019-03-03 Thread David Hallas
hallas closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19170 To: hallas, #frameworks, elvisangelaccio, dfaure Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/28/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Mar 2019 11:56:06 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 45 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/45/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 11:56:06 + Build duration: 8 min 4 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/41/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Mar 2019 11:56:06 + Build duration: 6 min 16 sec and counting BUILD ARTIFACTS

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

2019-03-03 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R241:01a7e0e757d3: Fix NTFS hidden check for symlinks to NTFS mountpoints (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18479?vs=50132=53061

D19491: generic config interface

2019-03-03 Thread Christoph Cullmann
cullmann added reviewers: KTextEditor, dhaumann, loh.tar. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19491 To: cullmann, #ktexteditor, dhaumann, loh.tar Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19491: generic config interface

2019-03-03 Thread Christoph Cullmann
cullmann added a comment. Other approach to generic config. Takes the ideas of D18894 with some tweaks. Uses enums for the keys (thought ATM puts that into an int in the interface, one might alter that later with some templatizing of the KateConfig.

D19491: generic config interface

2019-03-03 Thread Christoph Cullmann
cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY instead of member per entry, use key/value with QVariant instead of manual local/global config,

D19486: Add UDev find module

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FindUDev.cmake:86 > +set(UDEV_INCLUDE_DIR ${UDev_INCLUDE_DIRS}) > + > +include(FeatureSummary) mark_as_advanced(UDEV_FOUND UDEV_LIBS UDEV_INCLUDE_DIR)

D19486: Add UDev find module

2019-03-03 Thread Volker Krause
vkrause updated this revision to Diff 53055. vkrause added a comment. Add backward compatibility variables. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19486?vs=53047=53055 BRANCH master REVISION DETAIL

generating emoticon themes from emoji fonts

2019-03-03 Thread René J . V . Bertin
Hi, Is there a tool that can be used to generate themes for KEmoticons from TTF fonts like Apple Colour Emoji or even "mixed" fonts like Segoe UI Symbol, preferably with a selectable resolution/size for the generated images? Thanks, R.

D18894: [RFC] General config interface

2019-03-03 Thread Christoph Cullmann
cullmann added a comment. Hi, sorry that I didn't look earlier at this ;=) I think in principle, that goes into the right direction. For more compile-time safety I would like to have enums. For the internal design: I would use the QVariant types and I would avoid that

D19486: Add UDev find module

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D19486#423728 , @cgiboudeaux wrote: > We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Mar 2019 10:21:46 + Build duration: 4 min 29 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/18/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Mar 2019 10:21:46 + Build duration: 4 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 03 Mar 2019 10:21:46 + Build duration: 3 min 13 sec and counting JUnit Tests Name:

D19437: [knewstuff] Remove qt5.13 deprecated method

2019-03-03 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R304:f7fbcc13f518: [knewstuff] Remove qt5.13 deprecated method (authored by mlaurent). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19437?vs=53049=53053 REVISION

D19299: Make it compile without foreach

2019-03-03 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R244:e4474e7bc1a6: Make it compile without foreach (authored by mlaurent). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19299?vs=53048=53052 REVISION DETAIL

D19486: Add UDev find module

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux added a comment. We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57 INLINE COMMENTS > FindUDev.cmake:24 > +# The UDev

D19437: [knewstuff] Remove qt5.13 deprecated method

2019-03-03 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH remove_deprecated_qt5.13 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19437 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

2019-03-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19299: Make it compile without foreach

2019-03-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I see, that's because the old file isn't utf8, for the diff. Well, next time it'll work ;) INLINE COMMENTS > mlaurent wrote in kpluginmetadata.cpp:233 > people was const. So I thought

D19422: Fix upper/lower case rename on case insensitive fs

2019-03-03 Thread Robert Hoffmann
hoffmannrobert marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19422 To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

2019-03-03 Thread Robert Hoffmann
hoffmannrobert updated this revision to Diff 53051. hoffmannrobert added a comment. QDir not required, just add '/' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19422?vs=52833=53051 BRANCH fix_case_rename REVISION DETAIL

D18943: Add Fontconfig find modudle

2019-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:e3b6c8708c48: Add Fontconfig find modudle (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18943?vs=51849=53050#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE

D19437: [knewstuff] Remove qt5.13 deprecated method

2019-03-03 Thread Laurent Montel
mlaurent updated this revision to Diff 53049. mlaurent added a comment. Use exitstatus REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19437?vs=52879=53049 BRANCH remove_deprecated_qt5.13 (branched from master) REVISION DETAIL

D19299: Make it compile without foreach

2019-03-03 Thread Laurent Montel
mlaurent added a comment. for faceicontest it's phabricator which doesn"t like no UTF8 file I converted to utf8 with iconv but it still don't like it... {code} @@ -1,5 +1,5 @@ /* - * Copyright (C) 2014 Nicol341s Alvarez + * Copyright (C) 2014 Nicolás Alvarez -

D19299: Make it compile without foreach

2019-03-03 Thread Laurent Montel
mlaurent updated this revision to Diff 53048. mlaurent added a comment. Fix as requested by david REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19299?vs=52527=53048 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 27 - Still Unstable!

2019-03-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 03 Mar 2019 09:06:15 + Build duration: 24 min and counting BUILD ARTIFACTS

D19299: Make it compile without foreach

2019-03-03 Thread Laurent Montel
mlaurent marked an inline comment as done. mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in kpluginmetadata.cpp:233 > needs a const local var, no? people was const. So I thought that it was not necessary. But I created it. REPOSITORY R244 KCoreAddons REVISION DETAIL

D19486: Add UDev find module

2019-03-03 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This one is originally coming from Solid, but there are several more copies in our

  1   2   >