D19621: ViewPrivate: Make deselection by arrow keys more handy

dhaumann added a comment. 1. Please add a unit test (easy in this case) 2. Please test with right to left text layout, and mixed text layout. 3. Please keep the blinking cursor, this would be separate patch anyways. 4. What happens if you have "persistent selection" enabled? REPOSITORY

D19629: Change media-skip* and media-seek* style

ngraham accepted this revision. ngraham added a comment. Much better. REPOSITORY R266 Breeze Icons BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg, rooty, ngraham Cc: ngraham, rooty, kde-frameworks-devel, michaelh, bruns

D19629: Change media-skip* and media-seek* style

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. A quick google search (mpv, VLC, windows media player, etc.) revealed that the change you're proposing is actually more in keeping with the standard than what we've been using

D19629: Change media-skip* and media-seek* style

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Make media-skip* look more like standard skip forward/back symbols Make media-seek*

D19621: ViewPrivate: Make deselection by arrow keys more handy

ngraham added a comment. In D19621#427614 , @loh.tar wrote: > > I would recommend also hiding the blinking insertion point while text is selected. > > Then you lost the hint what may happens by e.g. Shift-Left/RightArrow I guess that

D19511: ViewPrivate: Disable read-only mode action when doc is modified

loh.tar added a comment. @ngraham Nate? Your opinion to the question? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh,

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar added a comment. > I would recommend also hiding the blinking insertion point while text is selected. Then you lost the hint what may happens by e.g. Shift-Left/RightArrow REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/39/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 00:12:34 + Build duration: 15 min and counting BUILD ARTIFACTS

D19620: Use a searchbar similar to the one in okular

ngraham accepted this revision. ngraham added a comment. Nice work! REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 00:12:30 + Build duration: 3 min 51 sec and counting BUILD ARTIFACTS

D19287: [ExtractorCollection] Load extractor plugins lazily

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2952f6bc9eca: [ExtractorCollection] Load extractor plugins lazily (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19287?vs=52488=53489

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53488. ognarb edited the summary of this revision. ognarb added a comment. This revision is now accepted and ready to land. Use placeholder text and clearButton REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE

D19621: ViewPrivate: Make deselection by arrow keys more handy

ngraham added a comment. Nice! This is one of my top annoyances with Kate vs other text editors I use! There's one issue: while text is selected, there's still a blinking insertion point at the start or end of the selection which is no longer accurate, since it will jump to the start or

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19598 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

T10554: KDiff3 to join Applications?

mreeves renamed this task from "KDiff3 to join Applications" to "KDiff3 to join Applications?". TASK DETAIL https://phabricator.kde.org/T10554 To: mreeves Cc: cfeck, aacid, kde-frameworks-devel, mreeves

D18915: Fix batchrename changing extension to lower case

bruns added inline comments. INLINE COMMENTS > batchrenamejob.cpp:170 > +if (extensionLen) { > +extension = filename.right(extensionLen); > +} else { You can just return here. > batchrenamejob.cpp:175 > +if (dotIndex != -1) { > +extension =

D18915: Fix batchrename changing extension to lower case

cfeck added inline comments. INLINE COMMENTS > cfeck wrote in batchrenamejob.cpp:165 > Function/method names are usually lowercase. Also, we don't add `get` for > getters, only `set` for setters. > > ⇒ `fileExtension()` ? > > Additionally, we pass QString via reference > > ⇒ `QString ` ?

D18915: Fix batchrename changing extension to lower case

cfeck added inline comments. INLINE COMMENTS > bruns wrote in batchrenamejob.cpp:165 > `QString extension = GetFileExtension(url.fileName());` > ... > `static QString BatchRenameJobPrivate::GetFileExtension(QString filename)` Function/method names are usually lowercase. Also, we don't add `get`

D19620: Use a searchbar similar to the one in okular

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Yes, I think this is better and it's good to be consistent. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks,

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. Use these, they're more similar to the titlebar shade button, but aligned to the pixel grid better. I will change the `go-*` icons in another patch. F6674647: collapse-all16.svg F6674648: collapse-all22.svg

D19620: Use a searchbar similar to the one in okular

ognarb retitled this revision from "Use a searchbar similar to the one from okular" to "Use a searchbar similar to the one in okular". REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

loh.tar retitled this revision from "DocumentPrivate: Make auto bracket slightly smarter" to "DocumentPrivate: Skip auto quotes when these looks already balanced". loh.tar edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19598

D19617: Support NET_WM_STATE_FOCUSED

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in netwm_def.h:506 > Whatever I put in @since is always wrong by the time I commit it anyway It's 5.57; 5.56 has already been tagged. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19617 To:

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch move the cursor to the start or end of the

D19557: Update css

ognarb updated this revision to Diff 53469. ognarb added a comment. Improve display inline media REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53367=53469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19620: Use a searchbar similar to the one from okular

ognarb edited the summary of this revision. ognarb added reviewers: VDG, Frameworks. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19620: Use a searchbar similar to the one from okular

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Improve consistency between different KDE apps. It's not perfect (close button isn't aligned). Screenshot

D19617: Support NET_WM_STATE_FOCUSED

apol added a comment. +1 otherwise INLINE COMMENTS > netwininfotestwm.cpp:440 > const QByteArray demandsAttention = > QByteArrayLiteral("_NET_WM_STATE_DEMANDS_ATTENTION"); > +const QByteArray focused = QByteArrayLiteral("_NET_WM_STATE_FOCUSED"); > + Indent with the rest? :P

D19617: Support NET_WM_STATE_FOCUSED

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in netwm_def.h:506 > 5.56 or 5.57? Whatever I put in @since is always wrong by the time I commit it anyway REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19617 To: davidedmundson, #kwin Cc:

D19617: Support NET_WM_STATE_FOCUSED

zzag added inline comments. INLINE COMMENTS > netwm_def.h:506 > + Only the window manager is allowed to change it. > + @since 5.56 > + **/ 5.56 or 5.57? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19617 To: davidedmundson, #kwin

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > taglibextractor.cpp:364 > +lstASF = asfTags->attribute("Author"); > +QStringList authors; > for (const auto& attribute : qAsConst(lstASF)) { This

D19608: DocumentPrivate: Make bracket handling smart

loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19608 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor,

D19617: Support NET_WM_STATE_FOCUSED

davidedmundson added a dependency: D19613: Support NET_WM_STATE_FOCUSED. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19617 To: davidedmundson, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19617: Support NET_WM_STATE_FOCUSED

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Used in kwin Unit test REPOSITORY R278 KWindowSystem BRANCH

D18601: Rewrite taglib writer to use property interface

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibwriter.cpp:70 > No, I cannot use the the PropertyMap for ASF/MP4, those atoms/attributes are > unsupported in the PropertyMap and need to be handled separately. I would > have done so if it is possible. > I really do not

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Mar 2019 14:41:13 + Build duration: 9 min 53 sec and counting BUILD ARTIFACTS

D19599: textfield height based only on clear text

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a2749dc9c718: textfield height based only on clear text (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19599?vs=53446=53449

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/38/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Mar 2019 14:41:13 + Build duration: 4 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 08 Mar 2019 14:41:13 + Build duration: 4 min 23 sec and counting JUnit Tests

D19608: DocumentPrivate: Make bracket handling smart

loh.tar updated this revision to Diff 53444. loh.tar retitled this revision from "[WIP] DocumentPrivate: Make bracket handling smart" to "DocumentPrivate: Make bracket handling smart". loh.tar edited the test plan for this revision. loh.tar added a comment. - Fixes to pass autotests CHANGES

D19599: textfield height based only on clear text

mart updated this revision to Diff 53446. mart added a comment. - better formatting REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19599?vs=53445=53446 BRANCH arcpatch-D19599 REVISION DETAIL https://phabricator.kde.org/D19599

D19599: textfield height based only on clear text

mart updated this revision to Diff 53445. mart added a comment. - use just M REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19599?vs=53381=53445 BRANCH arcpatch-D19599 REVISION DETAIL https://phabricator.kde.org/D19599 AFFECTED

KDE CI: Frameworks » khtml » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20WindowsMSVCQt5.11/32/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 08 Mar 2019 14:17:28 + Build duration: 5 min 20 sec and counting JUnit Tests Name:

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > I think for **reading** it as generic as possible is fine, but for writing > being a little bit more explicit does not hurt. > > My proposal for Ape and Ogg is to split the writing for these to two >

D17302: Add test for adding properties to result

astippich added a comment. ping REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19287: [ExtractorCollection] Load extractor plugins lazily

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH lazy_loading REVISION DETAIL https://phabricator.kde.org/D19287 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson,

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19575: Add collapse-all and expand-all action icons

trickyricky26 updated this revision to Diff 53430. trickyricky26 added a comment. - Name -symbolic icons properly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53315=53430 BRANCH collapse-expand-all-icons (branched from master) REVISION

inroduction

hey there,i am new to this community and this community seems very exciting to me i was going through ideas list and found Barcode scanning infrastructure project.As i am already implementing this for blind people so i would like to work on this issue as well in my GSOC 2019. can anybody help me

D19602: [KParts] Fix compilation for Qt 5.13

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. That's a weird new API... REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D19602 To: matthieugras, apol Cc: apol, kde-frameworks-devel, michaelh,

D19461: Logcat: fix dsError color with underline="0"

nibags updated this revision to Diff 53426. nibags added a comment. - Update styles REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19461?vs=53099=53426 BRANCH logcat-fix-error-color REVISION DETAIL https://phabricator.kde.org/D19461

D19599: textfield height based only on clear text

sitter added a comment. LGTM, but do we need the MMM there? Wouldn't one M do? Or if control.text is always a string we don't need the ""+ at all? INLINE COMMENTS > TextFieldStyle.qml:60 > > -implicitHeight: Math.max(control.cursorRectangle.height * 1.6, >

D19608: [WIP] DocumentPrivate: Make bracket handling smart

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann, mwolff. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch checks if the entered closing

D18673: Add symlinks for flatpak

nibags added a comment. In D19324 the icons for `code` and `code-oss` were added, which also need symbolic links for Flatpak (`com.visualstudio.code` & `com.visualstudio.code.oss`) REPOSITORY R266 Breeze Icons REVISION DETAIL