KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Mar 2019 04:38:55 + Build duration: 27 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Mar 2019 04:38:55 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/47/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Mar 2019 04:38:55 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 82 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/82/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Mar 2019 04:37:32 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Mar 2019 04:37:32 + Build duration: 5 min 30 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 51 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/51/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Mar 2019 04:37:32 + Build duration: 2 min 17 sec and counting JUnit Tests Name: (root)

D19696: Add blender thumbnailer

2019-03-13 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 53848. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Issues fixed. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19696?vs=53820=53848 BRANCH master REVISION DETAIL

D19696: Add blender thumbnailer

2019-03-13 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > bruns wrote in blendercreator.cpp:134 > So does the code I linked to. No need to cook your own. Ah, sorry. I misunderstood what was written in doc. It really does swap them. REPOSITORY R373 Image Thumbnailers REVISION DETAIL

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis added a comment. In D17469#430647 , @ngraham wrote: > Hmm, I see what you mean. Okay, let's go with this one! > > BTW, the duplicate test fails as of f2509047d4372f1a59d8f8b5ff009146f1a6adcb

D19734: Fix compilation with Android API level >= 26

2019-03-13 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19734 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T10262: Integrate KIO Slaves into file system using FUSE gateway

2019-03-13 Thread Nathaniel Graham
ngraham added a subscriber: fvogt. ngraham added a comment. I'm not involved in GSoC this year but maybe you can talk to @fvogt about it. I think he may have already started the work, but might appreciate extra eyes and fingers! :) TASK DETAIL https://phabricator.kde.org/T10262 To:

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hmm, I see what you mean. Okay, let's go with this one! BTW, the duplicate test fails as of f2509047d4372f1a59d8f8b5ff009146f1a6adcb

T10262: Integrate KIO Slaves into file system using FUSE gateway

2019-03-13 Thread Alexander Saoutkin
feverfew added a comment. @ngraham I'll be having some free time this summer. I was thinking if we could solidify this task into exactly what we need to do so we can get a proposal in for GSoC? TASK DETAIL https://phabricator.kde.org/T10262 To: cfeck, feverfew Cc: feverfew, #frameworks,

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis added a comment. In D17469#430616 , @ngraham wrote: > No room? Instead of widening the grips by one pixel to make room for the contrast border, how about building it in, effectively narrowing the grips by one pixel? That's what I

D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods

2019-03-13 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY FrameSvg updates the margins e.g. on a Theme change already in its internal

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Nathaniel Graham
ngraham added a comment. No room? Instead of widening the grips by one pixel to make room for the contrast border, how about building it in, effectively narrowing the grips by one pixel? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis,

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis updated this revision to Diff 53839. ndavis added a comment. Darken the handle grips REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=53836=53839 BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis added a comment. In D17469#430573 , @ngraham wrote: > Better, but the dark parts of the dark version still disappear against a dark background. Most of the time we solve this with a transparent outline (we did this for the clock icon

D18664: Baloo engine: treat every non-success code as a failure

2019-03-13 Thread Valeriy Malov
This revision was automatically updated to reflect the committed changes. Closed by commit R293:eb68430ae5f4: Baloo engine: treat every non-success code as a failure (authored by valeriymalov). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18664?vs=53608=53838#toc REPOSITORY R293

D19736: Add screen-rotate-auto-on/off

2019-03-13 Thread Noah Davis
ndavis added a comment. In D19736#430545 , @ngraham wrote: > Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder if it might benefit from using a single circular line with an arrowhead instead, like this comically crude

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 33 - Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/33/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Mar 2019 21:50:55 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Mar 2019 21:50:55 + Build duration: 3 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/33/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 13 Mar 2019 21:50:55 + Build duration: 2 min 8 sec and counting JUnit Tests Name:

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Nathaniel Graham
ngraham added a comment. Better, but the dark parts of the dark version still disappear against a dark background. Most of the time we solve this with a transparent outline (we did this for the clock icon recently), and I think that could work well here too. REPOSITORY R266 Breeze Icons

D17469: Give applications-games more contrast with Breeze Dark

2019-03-13 Thread Noah Davis
ndavis retitled this revision from "applications-games icon for dark theme" to "Give applications-games more contrast with Breeze Dark". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis,

D17469: applications-games icon for dark theme

2019-03-13 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

2019-03-13 Thread Noah Davis
ndavis updated this revision to Diff 53836. ndavis added a comment. Change style for Breeze and Breeze Dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=47254=53836 BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL

D19736: Add screen-rotate-auto-on/off

2019-03-13 Thread Nathaniel Graham
ngraham added a comment. Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder if it might benefit from using a single circular line with an arrowhead instead, like this comically crude mockup illustrates: F6689810: Screenshot_20190313_150037.png

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

2019-03-13 Thread Nikita Sirgienko
sirgienko closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19570 To: sirgienko, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, sars,

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

2019-03-13 Thread Noah Davis
ndavis added a comment. We did agree to have Qt and GTK settings separate in T8871 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

2019-03-13 Thread Nathaniel Graham
ngraham added a comment. In D19733#430500 , @ndavis wrote: > I don't think the light/dark window background looks good. It also gives the wrong message because the Colors KCM is what controls the window background color. The Window Decoration

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

2019-03-13 Thread Noah Davis
ndavis added a comment. BTW, when you change an icon into a symlink or vice versa, can you delete the icon you're changing in a separate commit and then add the new version of the icon? `arc patch` doesn't work when a file has been changed from or to a symlink. REPOSITORY R266 Breeze

D19696: Add blender thumbnailer

2019-03-13 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > blendercreator.cpp:67 > +QPointer gzFile; > +if(file.peek(2).startsWith("\x1F\x8B")) { // gzip magic (each gzip > member starts with ID1(0x1f) and ID2(0x8b)) > +file.close(); This requires a comment, stating gzip compression is

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

2019-03-13 Thread Noah Davis
ndavis added a comment. I don't think the light/dark window background looks good. It also gives the wrong message because the Colors KCM is what controls the Window background. The Window Decoration KCM icon has the same issue, but that already exists. Perhaps you should put buttons or

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

2019-03-13 Thread loh tar
loh.tar added a comment. OK. I spend some time again, but give up now. I've got the feeling that these key event handling is not very well engineered. May someone else take a closer look for some better solution, or at least try this patch, if it breaks some other functionality.

D19736: Add screen-rotate-auto-on/off

2019-03-13 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

2019-03-13 Thread Noah Davis
ndavis updated this revision to Diff 53826. ndavis edited the test plan for this revision. ndavis added a comment. - Increase spacing between outside rotation marks and screen REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=53825=53826 BRANCH

D19736: Add screen-rotate-auto-on/off

2019-03-13 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

2019-03-13 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Screen auto rotate icons for D19690 REPOSITORY

D19696: Add blender thumbnailer

2019-03-13 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 53820. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Moved to kdegraphics-thumbnailer Got rid of operator>>() and fixed other issues. REPOSITORY R373 Image Thumbnailers CHANGES SINCE LAST UPDATE

D19696: Add blender thumbnailer

2019-03-13 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > bruns wrote in blendercreator.cpp:57 > I think this is already done by the calling code - the thumbnailer gets only > called when the mimetype matches. This part is required because blender can save files with gzip compression. Examples here :

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

2019-03-13 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon" to "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons". REPOSITORY R266 Breeze Icons REVISION DETAIL

D19734: Fix compilation with Android API level >= 26

2019-03-13 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Starting with API level 26, these methods are actually available and we don't need our dummy declarations anymore.

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon

2019-03-13 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-applications icon" to "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon". GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D19733: Add preferences-desktop-theme-applications icon

2019-03-13 Thread Björn Feber
GB_2 retitled this revision from "Add preferences-desktop-theme-windows icon" to "Add preferences-desktop-theme-applications icon". GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D19733: Add preferences-desktop-theme-windows icon

2019-03-13 Thread Björn Feber
GB_2 updated this revision to Diff 53813. GB_2 added a comment. Rename files and make icons more accurate REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53811=53813 BRANCH add-preferences-desktop-theme-windows-icon (branched from master)

D19733: Add preferences-desktop-theme-windows icon

2019-03-13 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-windows icon

2019-03-13 Thread Björn Feber
GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Adds an application style icon, adds a symlink and renames the old one to

D19338: New location for KNSRC files

2019-03-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Works great, thanks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19500: [KDirModel] Fix job urls change signal connection

2019-03-13 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik, #frameworks, dfaure, jtamate Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19732: [KWidgetAddons] Fix build with Qt 5.13

2019-03-13 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19732 To: matthieugras, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

2019-03-13 Thread Noah Davis
ndavis commandeered this revision. ndavis edited reviewers, added: guoyunhe; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19732: [KWidgetAddons] Fix build with Qt 5.13

2019-03-13 Thread Matthieu Gras
matthieugras created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. matthieugras requested review of this revision. REVISION SUMMARY QColor::dark(bool) is deprecated TEST PLAN compiles REPOSITORY R236 KWidgetsAddons BRANCH master

D19728: [GridViewKCM] Fix implicit width calculation

2019-03-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R296:72f438f8e7ad: [GridViewKCM] Fix implicit width calculation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19728?vs=53799=53800

D19728: [GridViewKCM] Fix implicit width calculation

2019-03-13 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19728 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

2019-03-13 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Take into account paddings around the page and scroll view and also use the

D19728: [GridViewKCM] Fix implicit width calculation

2019-03-13 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19728 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/16/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Mar 2019 14:42:13 + Build duration: 5 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Mar 2019 14:42:13 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

2019-03-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 13 Mar 2019 14:42:13 + Build duration: 57 sec and counting JUnit Tests Name:

D19719: [kpackages] compile without foreach

2019-03-13 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R290:2dd8e902e539: [kpackages] compile without foreach (authored by mlaurent). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19719?vs=53768=53796 REVISION DETAIL

D19718: [kiconthemes] compiles without foreach

2019-03-13 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R302:2603a8ac4da6: [kiconthemes] compiles without foreach (authored by mlaurent). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19718?vs=53767=53795 REVISION

D19338: New location for KNSRC files

2019-03-13 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19719: [kpackages] compile without foreach

2019-03-13 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH fix_compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19719 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham,

D19718: [kiconthemes] compiles without foreach

2019-03-13 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19718 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

2019-03-13 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH configfileextensions REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

2019-03-13 Thread loh tar
loh.tar added a comment. hm, it may better to avoid to call that function at all in case of Ctrl-F (?) Will take a look. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19408 To: loh.tar, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel,

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

2019-03-13 Thread Christoph Cullmann
cullmann added a comment. I am unsure about the toplevel &&, wouldn't one just want that for the return case? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19408 To: loh.tar, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel,

D19338: New location for KNSRC files

2019-03-13 Thread Dan Leinir Turthra Jensen
leinir added a comment. Quick ping, be good to get this in sometime before it becomes late again... :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot,

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

2019-03-13 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R288:4f4298539104: [KUiServerJobTracker] Update destUrl before finishing the job (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE

D17469: applications-games icon for dark theme

2019-03-13 Thread Yunhe Guo
guoyunhe added a comment. In D17469#429992 , @ndavis wrote: > @guoyunhe Do you mind if I commandeer this? Go ahead! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg, ndavis

D19719: [kpackages] compile without foreach

2019-03-13 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R290 KPackage

D19718: [kiconthemes] compiles without foreach

2019-03-13 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R302 KIconThemes