D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a3ed87ca7808: kconfig_compiler: new kcfgc args HeaderExtension SourceExtension (authored by kossebau). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D19602: [KParts] Fix compilation for Qt 5.13

mlaurent added a comment. Ping do you want that we commit for you ? Otherwise I will do it as I need this patch. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D19602 To: matthieugras, apol, mlaurent Cc: mlaurent, apol, kde-frameworks-devel,

D19768: Fixes memory leak of ssh_session

hallas closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19768 To: hallas, #frameworks, sitter, aacid Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D19696: Add blender thumbnailer

bruns added a comment. Save the two nitpicks, looks good to me now. Anyone else any comments? INLINE COMMENTS > blendercreator.cpp:24 > +#include > +#include > + Really required? > blendercreator.cpp:29 > +#include > +#include > +#include Unused ... REPOSITORY R373 Image

D18915: Fix batchrename changing extension to lower case

bruns added a comment. Now, a unit test would be nice ... INLINE COMMENTS > batchrenamejob.cpp:177 > +} > +return QStringLiteral(); > +} This should be `return QString();`, wont get any cheaper than that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915

D19771: Use placeholder instead of label

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53928. ognarb added a comment. Use Unicode ellipsis REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53906=53928 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19771: Use placeholder instead of label

ognarb planned changes to this revision. ognarb added a comment. Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms. So the

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

ndavis retitled this revision from "Give applications-games more contrast with Breeze Dark" to "Give applications-games and input-gaming more contrast with Breeze Dark". REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL

D17469: Give applications-games more contrast with Breeze Dark

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe, ngraham Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh,

D17469: Give applications-games more contrast with Breeze Dark

ndavis updated this revision to Diff 53925. ndavis added a comment. Update input-gaming and make circle around dpad and colored buttons darker REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=53839=53925 BRANCH arcpatch-D17469 (branched from

D19767: Fix malloc/delete mismatch

aacid added inline comments. INLINE COMMENTS > kio_sftp.cpp:446 > cPath = QFile::decodeName(sPath); > -delete sPath; > +free(sPath); > Use ssh_string_free_char ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure,

D19768: Fixes memory leak of ssh_session

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH fixes_memory_leak_of_session (branched from master) REVISION DETAIL https://phabricator.kde.org/D19768 To: hallas, #frameworks, sitter, aacid Cc: kde-frameworks-devel,

D19771: Use placeholder instead of label

ognarb updated this revision to Diff 53922. ognarb added a comment. Use proper Unicode ellipsis REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19771?vs=53919=53922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19771 AFFECTED FILES

D19771: Use placeholder instead of label

ognarb added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

ognarb edited the summary of this revision. ognarb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ndavis added a comment. In D19733#431237 , @GB_2 wrote: > In D19733#431139 , @ndavis wrote: > > > I think `preferences-desktop-theme-applications` is fine, but

D19771: Use placeholder instead of label

ognarb created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ognarb requested review of this revision. REVISION SUMMARY See https://hig.kde.org/style/writing/placeholder.html Also change Find -> Search in Search and

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 added a comment. In D19733#431139 , @ndavis wrote: > I think `preferences-desktop-theme-applications` is fine, but `preferences-desktop-theme-windowdecorations` looks odd with that border. F6691545: Screenshot_20190314_135511.png

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 139 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/139/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 14 Mar 2019 19:54:01 + Build duration: 2 min 19 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/52/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Mar 2019 19:54:01 + Build duration: 48 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 75 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Mar 2019 19:54:01 + Build duration: 46 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/83/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Mar 2019 19:54:01 + Build duration: 27 sec and counting CONSOLE OUTPUT

D19767: Fix malloc/delete mismatch

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D19768: Fixes memory leak of ssh_session

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19768 To: hallas, #frameworks, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 53914. cfoster added a comment. - Pass QString by reference REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=53068=53914 BRANCH arcpatch-D18915 REVISION DETAIL https://phabricator.kde.org/D18915 AFFECTED

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19767: Fix malloc/delete mismatch

anthonyfieroni added a reviewer: dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D19768: Fixes memory leak of ssh_session

hallas created this revision. hallas added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fixes memory leak of ssh_session. The mSession member variable is

D19767: Fix malloc/delete mismatch

hallas created this revision. hallas added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fixes pointer was allocated with malloc (by libssh) but freed with

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53906. ognarb added a comment. Remove icon to option button REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53505=53906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ndavis added a comment. I think `preferences-desktop-theme-applications` is fine, but `preferences-desktop-theme-windowdecorations` looks odd with that border. F6691545: Screenshot_20190314_135511.png REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Mar 2019 17:35:40 + Build duration: 9 min 52 sec and counting BUILD ARTIFACTS

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > ...aand that's exactly what happened. :( I'm not exhausted, my patch just works good enough (thanks also to feedback on here) to make me more interested in living the rest of my life rather than continue to explore alternatives. Maybe if an alternative

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/24/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 14 Mar 2019 17:35:40 + Build duration: 6 min 15 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Mar 2019 17:35:40 + Build duration: 4 min 28 sec and counting JUnit Tests Name:

D19734: Fix compilation with Android API level >= 26

This revision was automatically updated to reflect the committed changes. Closed by commit R244:35b0d2adf013: Fix compilation with Android API level = 26 (authored by vkrause). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19734?vs=53814=53901 REVISION

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. In D18380#409963 , @ngraham wrote: > I hope not, but that's the problem with the wall-of-text communication style. Eventually people get exhausted and the discussion peters out with nothing getting done.

D19764: Fix Minimap with QtCurve style

sars created this revision. sars added a reviewer: brauch. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sars requested review of this revision. REVISION SUMMARY The handle of the scrollbar in QtCurve is much smaller than the scrollbar

D19762: Only get clearTextPath when used

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It does some queries and introspection that takes up to 2ms. TEST PLAN

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar updated this revision to Diff 53891. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Use new sig/slot style - Move/Use KToggleAction in document as suggested - Fix not working throttle logic - Increase delay to 3sec - Remove unneeded

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 updated this revision to Diff 53883. GB_2 added a comment. Don't turn real files into symlinks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53882=53883 REVISION DETAIL https://phabricator.kde.org/D19733 AFFECTED FILES

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 updated this revision to Diff 53882. GB_2 added a comment. Update preferences-desktop-theme-applications icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19733?vs=53813=53882 BRANCH add-preferences-desktop-theme-windows-icon (branched from

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

GB_2 retitled this revision from "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons" to "Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons". REPOSITORY R266 Breeze Icons REVISION DETAIL

D19338: New location for KNSRC files

This revision was automatically updated to reflect the committed changes. Closed by commit R304:be0412024a46: New location for KNSRC files (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=53117=53869 REVISION DETAIL

D19750: [attica] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R235 Attica BRANCH

D19749: [baloo] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R293