D20852: Fix to show folding preview when move the mouse from bottom to top

loh.tar updated this revision to Diff 57082. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment. - Fix missing cleanup in case of unvalid mouse position - Give members more fitting names - Remove unneeded

D20748: Fix wrong "Unable to find service type" warnings

anthonyfieroni added inline comments. INLINE COMMENTS > desktopfileparser.cpp:402 > // in cache but we still must make our own copy > m_definitions << *def; > +} else { Where def is deleted? REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL

D20748: Fix wrong "Unable to find service type" warnings

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson, davidedmundson, mpyne, apol Cc: aacid,

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. If you want to use a library, then it would be better to mark it as a dependency in CMake rather than bundling it here. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: ltoscano,

D19812: Add a web page to view and compare icons of different sizes

guoyunhe abandoned this revision. guoyunhe added a comment. Using a library can save a lot of time. Just like many simple web pages use jQuery, D3 , etc. I don't have the ability to write it all by hands from scratch... REPOSITORY R266 Breeze Icons

D20852: Fix to show folding preview when move the mouse from bottom to top

brauch added a comment. I guess the intention of the highlight delay is that when you move your mouse across the border, the view doesn't flicker. The 150ms does this well enough for me, I never see a flicker at least ;) REPOSITORY R39 KTextEditor REVISION DETAIL

D20852: Fix to show folding preview when move the mouse from bottom to top

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch happens in that case nothing. You have to

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. At the minimum, I'd like to see the original/un-minified version rather than the illegible version here that's vulnerable to attack. But why do we even need it in the first place? The original is 12,000 lines of Javascript. Is it actually necessary to have such a

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#456869 , @ltoscano wrote: > The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch

D19812: Add a web page to view and compare icons of different sizes

ltoscano added a comment. The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch out the minified javascript and replace it with a dependency on a proper packaged

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. The code is stable version Vue.js. Source is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.min.js Uncompiled version is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.js I used to include it from remote URL. But someone think it is not

D19812: Add a web page to view and compare icons of different sizes

filipf added a comment. In D19812#456848 , @ngraham wrote: > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#456848 , @ngraham wrote: > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read.

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This would be the perfect place to sneak in malware (not saying you or the author have

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. In D20838#456831 , @meven wrote: > I have tested on my side, I don't understand why it does not work. > From dolphin desktop:/ you can drag'n drop fine but not from the folder view. > I receive events and desktop:/

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#456820 , @ngraham wrote: > Wow, it works and it's so nice. What an improvement! :) > Drop options are not needed here; this isn't a move/copy/symlink UI; it's simply a quick way to choose a

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57056. meven added a comment. Remove unnecessary comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57027=57056 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. Wow, it works and it's so nice. What an improvement! Drop options are not needed here; this isn't a move/copy/symlink UI; it's simply a quick way to choose a file that you happen to have visible in Dolphin or on the desktop. On that subject, I notice

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a comment. In D20301#453031 , @ngraham wrote: > I've been told that @bruns can review this sometime next week. :) Can't wait, the bug annoys me. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301

D20748: Fix wrong "Unable to find service type" warnings

dfaure added a reviewer: apol. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson, davidedmundson, mpyne, apol Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

aacid added inline comments. INLINE COMMENTS > apol wrote in ktar.cpp:289 > Doesn't QString have the same size limitation as QByteArray? I'll double check, also i now see that decodeName char creates a temporary qbytearray so that may be problematic too :/ REPOSITORY R243 KArchive REVISION

D19850: Make AppStream generation opt-in

apol abandoned this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 26 Apr 2019 14:34:16 + Build duration: 57 sec and counting JUnit Tests Name:

D20839: AppStream generation: make sure we look up for the package structure on packages that have metadata.desktop/json too

This revision was automatically updated to reflect the committed changes. Closed by commit R290:bf261881f6fe: AppStream generation: make sure we look up for the package structure on… (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson, zzag Cc: plasma-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D20839: AppStream generation: make sure we look up for the package structure on packages that have metadata.desktop/json too

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20839 To: apol, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

apol added inline comments. INLINE COMMENTS > ktar.cpp:289 > case 'L': > -name = QFile::decodeName(longlink.constData()); > +name = QFile::decodeName(longlink); > break; Doesn't QString have the same size limitation

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY QByteArray::resize doesn't work for std::numeric_limits::max() https://bugreports.qt.io/browse/QTBUG-75470 rumour is

D20627: Introduce CriticalNotificationType

davidedmundson accepted this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin, zzag, davidedmundson Cc: zzag, graesslin, kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

zzag added subscribers: graesslin, zzag. zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Hmm, in general this is quite delicate case because KWin/X11 is feature frozen... Given that there is no other way around (except using above state

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

zzag added a comment. Please land together with other revisions. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20628 To: broulik, #kwin, zzag Cc: zzag, davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > davidedmundson wrote in plasma-shell.xml:194 > since="6" > > See > https://github.com/wayland-project/wayland/blob/master/protocol/wayland.dtd Also, folks usually put

D20838: Allow to drop one file or one folder on KDirOperator

meven added inline comments. INLINE COMMENTS > apol wrote in kdiroperator.cpp:418 > This default change should be documented. Not sure I have done this correctly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel,

D20839: AppStream generation: make sure we look up for the package structure on packages that have metadata.desktop/json too

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN Generated the appstream for plasmoids in kdeplasma addons and they properly extend its

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57027. meven added a comment. Add a since in documentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57026=57027 BRANCH drop-kdiroperator REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57026. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57024=57026 BRANCH drop-kdiroperator REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20748: Fix wrong "Unable to find service type" warnings

aacid added a comment. It looks good to me, but i'm not sure i know enough about this code to give you an approved, but if noone else does, let's assume i did :D REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20748 To: dfaure, mart, arichardson,

D20838: Allow to drop one file or one folder on KDirOperator

apol added inline comments. INLINE COMMENTS > kdiroperator.cpp:418 > setFocusPolicy(Qt::WheelFocus); > +setAcceptDrops(true); > } This default change should be documented. > kdiroperator.cpp:1401 > +} else { > +QUrl url = urls.at(0); > + .constFirst()

D20838: Allow to drop one file or one folder on KDirOperator

meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Open questions: - drop options Todo: - Add automated tests BUG: 45154 FIXED-IN: 5.58 TEST PLAN

D20833: Simpler check for flatpak

apol updated this revision to Diff 57023. apol added a comment. No need for inSandbox to be a class member REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20833?vs=56999=57023 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20833

D20833: Simpler check for flatpak

apol added a comment. We still use it to check whether to initialise `portalDBusServiceExists`. I'll simplify it a bit. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20833 To: apol, #frameworks Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20833: Simpler check for flatpak

broulik added inline comments. INLINE COMMENTS > knotificationmanager.cpp:94 > > if (!qEnvironmentVariableIsEmpty("XDG_RUNTIME_DIR")) { > +d->inSandbox = QFileInfo::exists(QLatin1String("/.flatpak-info")); Do you need this check now, even, since you're not using it anymore?