D20877: Fix exivextractor crash with malformed files

astippich marked 2 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

astippich updated this revision to Diff 57157. astippich marked an inline comment as done. astippich added a comment. - add line break REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20877?vs=57135=57157 BRANCH fix_exiv_crash REVISION DETAIL

D19455: [knotification] compile without deprecated methods

mlaurent added a comment. +1 with albert idea. Or in CMakeLists.txt if (NOT APPLE) add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00) endif() As I can't compile against MacOsX we can exclude it. It will fix when we will switch to qt6 by os dev. REPOSITORY R289

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/41/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Apr 2019 03:33:02 + Build duration: 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/89/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Apr 2019 03:32:54 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/82/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 29 Apr 2019 03:32:54 + Build duration: 7 min 33 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/92/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 29 Apr 2019 03:32:53 + Build duration: 2 min 37 sec and counting JUnit Tests

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 36 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 29 Apr 2019 00:50:25 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 35 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 28 Apr 2019 19:03:23 + Build duration: 5 hr 47 min and counting

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 38 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/38/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 28 Apr 2019 18:00:26 + Build duration: 6 hr 46 min and counting

D20752: Add missing properties in kpackage-generic.desktop

apol accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D20752 To: dfaure, mart, apol, sitter Cc: #frameworks

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 28 Apr 2019 19:03:31 + Build duration: 4 hr 56 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/82/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 28 Apr 2019 19:03:16 + Build duration: 4 hr 45 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/43/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 28 Apr 2019 18:00:48 + Build duration: 4 hr 9 min and counting JUnit Tests Name:

D20589: Add QML to source code types

This revision was automatically updated to reflect the committed changes. Closed by commit R293:26d90fec2c74: Add QML to source code types (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20589?vs=56335=57150 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/81/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 28 Apr 2019 19:03:03 + Build duration: 1 hr 8 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:56 + Build duration: 2 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:53 + Build duration: 2 hr 1 min and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/87/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:41 + Build duration: 1 hr 56 min and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:39 + Build duration: 1 hr 54 min and counting JUnit Tests Name:

D20877: Fix exivextractor crash with malformed files

bruns added a comment. Otherwise, LGTM INLINE COMMENTS > astippich wrote in exiv2extractor.cpp:303 > Yep, forgot Can you add a line break here as well? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:36 + Build duration: 1 hr 39 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 28 Apr 2019 19:03:01 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/40/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 28 Apr 2019 18:00:25 + Build duration: 1 hr 23 min and counting JUnit Tests

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:32 + Build duration: 1 hr 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/91/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:31 + Build duration: 1 hr 4 min and counting JUnit Tests

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:31 + Build duration: 1 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:29 + Build duration: 53 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/37/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:29 + Build duration: 46 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/96/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:28 + Build duration: 39 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 53 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/53/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 28 Apr 2019 18:00:19 + Build duration: 30 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 17:56:27 + Build duration: 24 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/88/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Apr 2019 16:18:33 + Build duration: 55 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/88/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Apr 2019 16:18:20 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/33/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 28 Apr 2019 16:18:18 + Build duration: 18 min and counting BUILD ARTIFACTS

D19455: [knotification] compile without deprecated methods

aacid added a comment. In D19455#457367 , @bcooksley wrote: > This change has broken builds on macOS. > Please see https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console > > Whilst not documented in the Qt

D20877: Fix exivextractor crash with malformed files

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:303 > Shouldn't there be a check here as well? And probably move the > `ratio.second` to after its assignment and immediately return. Yep, forgot REPOSITORY R286

D20877: Fix exivextractor crash with malformed files

astippich updated this revision to Diff 57135. astippich added a comment. - also check for altitude ref REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20877?vs=57130=57135 BRANCH fix_exiv_crash REVISION DETAIL https://phabricator.kde.org/D20877

D20877: Fix exivextractor crash with malformed files

bruns added inline comments. INLINE COMMENTS > astippich wrote in exiv2extractor.cpp:299 > Unfortunately, empty() does not exist. Same was done in > https://phabricator.kde.org/D16165 Yes, probably as `count()` is O(1). > exiv2extractor.cpp:303 > it =

D20877: Fix exivextractor crash with malformed files

astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:299 > `!it->empty()` ? Unfortunately, empty() does not exist. Same was done in https://phabricator.kde.org/D16165 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To:

D20877: Fix exivextractor crash with malformed files

bruns added inline comments. INLINE COMMENTS > exiv2extractor.cpp:299 > Exiv2::ExifData::const_iterator it = > data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitude")); > -if (it != data.end() && (it->value().typeId() == Exiv2::unsignedRational > || it->value().typeId() ==

D20877: Fix exivextractor crash with malformed files

astippich added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

astippich created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Prevent a segfault by explicitly checking everywhere for valid entries. BUG: 405210 REPOSITORY

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 57125. loh.tar retitled this revision from "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection" to "Add option to treat some chars also as "auto bracket" only when we have a selection". loh.tar edited the summary of this

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#456847 , @ngraham wrote: > In D20838#456831 , @meven wrote: > > > I have tested on my side, I don't understand why it does not work. > > From dolphin desktop:/ you

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57124. meven added a comment. Allow KDirModel to accept more actions when dropping on the model, simplify implementation, translates kde url to mostlocalurls when dropping REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20827: Reword some text, a couple clean ups, add a separator

elvisangelaccio added a comment. @meven FYI this change broke the Frameworks string freeze: https://community.kde.org/Schedules/Frameworks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20827 To: meven, ngraham, #frameworks, #vdg, GB_2 Cc: elvisangelaccio,

[craft-blueprints-kde] kde/frameworks/tier3/knotifications: Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly.

Git commit aeaac2863f7383780197c667a6a961256af6b4f5 by Ben Cooksley. Committed on 28/04/2019 at 09:00. Pushed by bcooksley into branch 'master'. Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly. This is a Craft level

D19455: [knotification] compile without deprecated methods

bcooksley added a comment. This change has broken builds on macOS. Please see https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console Whilst not documented in the Qt Documentation, the `qmacfunctions.h` header (which is what is included by `#include `) has the