KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/90/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 01 May 2019 03:58:30 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 93 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/93/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 01 May 2019 03:58:30 + Build duration: 4 min 29 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/83/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 01 May 2019 03:58:29 + Build duration: 8 min 12 sec and counting BUILD ARTIFACTS

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

2019-04-30 Thread Albert Astals Cid
aacid updated this revision to Diff 57296. aacid edited the summary of this revision. aacid added a comment. better fix REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20844?vs=57042=57296 BRANCH arcpatch-D20844 REVISION DETAIL

D19455: [knotification] compile without deprecated methods

2019-04-30 Thread Albert Astals Cid
aacid added a comment. In D19455#457849 , @bcooksley wrote: > I'm fine with either fix, any objection to that being committed directly? Sorry if you were waiting for me, sure just go ahead REPOSITORY R289 KNotifications REVISION

D20924: [WIP] ViewConfig: Use new generic config interface

2019-04-30 Thread loh tar
loh.tar updated this revision to Diff 57293. loh.tar edited the summary of this revision. loh.tar added a comment. - ShowScrollBarPreview - ShowScrollBarMarks - ShowLineNumbers - Add some validator functions, please look at them CHANGES SINCE LAST UPDATE

Re: New framework: KCalCore

2019-04-30 Thread Allen Winter
Clazy is complaining about missing assign operators. Do we care? If so, I can take a look at adding them or if anyone else wants to do that. -Allen ./src/calendar.cpp line 305: for (it = vals.constBegin(); it != vals.constEnd(); ++it) { => Using assign operator but class QTypedArrayData

D20924: [WIP] ViewConfig: Use new generic config interface

2019-04-30 Thread loh tar
loh.tar added a comment. Ah, last hint: The diff is not against master. Should you really like to try it, I can fix that earlier, otherwise will do it when I'm done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor Cc: kwrite-devel,

D20924: [WIP] ViewConfig: Use new generic config interface

2019-04-30 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Done so far: - DynWordWrapAlignIndent -

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-04-30 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think this would be some initial solution for this issue. An highlighting specific config would be even cooler, but giving the user the choice to add additional chars (or

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/91/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 30 Apr 2019 17:32:37 + Build duration: 6 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/90/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 30 Apr 2019 17:24:33 + Build duration: 8 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/85/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Apr 2019 17:30:42 + Build duration: 1 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 84 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Apr 2019 17:24:32 + Build duration: 6 min 8 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 90 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/90/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 17:25:51 + Build duration: 1 min 4 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 89 - Still Unstable!

2019-04-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/89/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 17:24:33 + Build duration: 1 min 15 sec and counting JUnit Tests Name:

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-30 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R286:c14869f1b9af: [TaglibExtractor] Feed non-ogg *.spx file into extractor test (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20913: [TagLibExtractor] Fix crash on invalid Speex files

2019-04-30 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R286:61b1916c3e87: [TagLibExtractor] Fix crash on invalid Speex files (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20913?vs=57229=57281

D20918: [balooctl] Add command to show files failed to index

2019-04-30 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:74c8fcf5bb0d: [balooctl] Add command to show files failed to index (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20918?vs=57251=57280 REVISION

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-30 Thread Alexander Stippich
astippich accepted this revision. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20914 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-04-30 Thread Nathaniel Graham
ngraham added a comment. Any news on this @emateli? I'd really love to see it in Dolphin! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham,

D20913: [TagLibExtractor] Fix crash on invalid Speex files

2019-04-30 Thread Alexander Stippich
astippich accepted this revision. astippich added a comment. Given the outcome, I wish I never added support for speex files to the extractor because it was "easy to add". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20913 To: bruns, #baloo, #frameworks,

D20903: Fix bookmark pixmap painting on icon bar

2019-04-30 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:08d1537b7565: Fix bookmark pixmap painting on icon bar (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20903?vs=57203=57268 REVISION

D20897: Ensure the left border miss no change of the count of line number digits

2019-04-30 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:34fec148d283: Ensure the left border miss no change of the count of line number digits (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20913: [TagLibExtractor] Fix crash on invalid Speex files

2019-04-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Gross! Confirmed the fix. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20913 To: bruns, #baloo, #frameworks, ngraham, astippich Cc:

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

2019-04-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20914 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel,

D20918: [balooctl] Add command to show files failed to index

2019-04-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Quite nice, quite nice. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20918 To: bruns, #baloo, #frameworks, ngraham, astippich Cc:

D20918: [balooctl] Add command to show files failed to index

2019-04-30 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Baloo was missing any means to retrieve the list of

D20630: [Dialog] Add CriticalNotification type

2019-04-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20630 To: broulik, #plasma, #kwin, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20897: Ensure the left border miss no change of the count of line number digits

2019-04-30 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20897 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns,

D20903: Fix bookmark pixmap painting on icon bar

2019-04-30 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20903 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns,