D21078: Avoid infinite loop in "Toggle Contained Nodes" action

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. TEST PLAN Try and empty folding range like

D20958: New menu of syntax highlighting in the status bar

cullmann added a comment. Ok, thanks! REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 May 2019 03:45:41 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 May 2019 03:45:40 + Build duration: 9 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/95/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 May 2019 03:45:36 + Build duration: 7 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/88/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 May 2019 03:45:35 + Build duration: 7 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/98/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 08 May 2019 03:45:34 + Build duration: 4 min 15 sec and counting JUnit Tests

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 08 May 2019 00:40:53 + Build duration: 2 min 2 sec and counting JUnit Tests Name:

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

This revision was automatically updated to reflect the committed changes. bruns marked 2 inline comments as done. Closed by commit R245:ee77083102b1: [Fstab] Use folder-decrypted icon for encrypting fuse mounts (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D20958: New menu of syntax highlighting in the status bar

nibags added a comment. I'm going to move it to QListView (or QTreeView) in a future diff, I have checked and it isn't complicated to do. Now I want to test it a bit more before doing the commit. REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. Well, this patch can still go in then, it makes one of the two values correct :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: bruns, sasch, adridg, apol, kde-frameworks-devel, michaelh, ngraham

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson abandoned this revision. davidedmundson added a comment. I put it up as an RFC, as I spent too long debugging why I had a difference. I don't like that we're in this uncanny valley of neither disk space nor sum of file size, but maybe I should do it properly and show two

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 57733. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. loh.tar added a comment. - Make feature configurable CHANGES SINCE LAST UPDATE

D21063: Symlink arrow-*-double to go-*-skip

ndavis added a comment. Whoops. Forgot there were no 24px go-*-skip icons. I'll have to fix that and then the patch will work. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21063 To: ndavis, #vdg, ngraham Cc: jriddell, kde-frameworks-devel, michaelh,

D17071: Don't include any directory sizes in DirectorySizeJob

bruns added a comment. In D17071#461613 , @dfaure wrote: > I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 165 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/165/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 07 May 2019 15:46:51 + Build duration: 4 min 29 sec and counting JUnit Tests

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 May 2019 15:46:51 + Build duration: 1 min 50 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/108/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 07 May 2019 15:46:51 + Build duration: 1 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 101 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/101/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 07 May 2019 15:46:51 + Build duration: 5 min 27 sec and counting JUnit Tests Name: (root)

D21063: Symlink arrow-*-double to go-*-skip

jriddell added a comment. I've reverted this commit as it breaks compilation https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/78/console [ 79%] Generating res/breeze-icons.qrc 15:58:48 Error copying directory from

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 78 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 May 2019 14:56:21 + Build duration: 2 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 100 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/100/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 07 May 2019 14:56:21 + Build duration: 2 min 28 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 164 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/164/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 07 May 2019 14:56:21 + Build duration: 1 min 15 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 107 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/107/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 07 May 2019 14:56:21 + Build duration: 35 sec and counting CONSOLE OUTPUT

D21063: Symlink arrow-*-double to go-*-skip

This revision was automatically updated to reflect the committed changes. Closed by commit R266:04be2a08ab1b: Symlink arrow-*-double to go-*-skip (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21063?vs=57700=57723 REVISION DETAIL

D21063: Symlink arrow-*-double to go-*-skip

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arrows (branched from master) REVISION DETAIL https://phabricator.kde.org/D21063 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57707. meven added a comment. update since comment kio version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57636=57707 BRANCH arcpatch-D20838_1 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED

D21063: Symlink arrow-*-double to go-*-skip

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21063 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21063: Symlink arrow-*-double to go-*-skip

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Previously, the arrow-*-double icons were symlinked to go-top/bottom/first/last icons,

D20958: New menu of syntax highlighting in the status bar

cullmann accepted this revision. cullmann added a comment. I am ok with having this as is. If one can move it to QListView, nice, but that could be done in an extra request. Thanks for this great improvement. REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL