D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. Well, I'm also not full convinced about the current way, but how else? The point is, you can now add as much sets as you like and rel. quickly change between your presets. I read you request so, that we have at the end only some hardcoded offers which the user

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

This revision was automatically updated to reflect the committed changes. Closed by commit R39:783647154a0e: Avoid infinite loop in Toggle Contained Nodes action (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21078?vs=57747=57772#toc REPOSITORY R39 KTextEditor

D4234: Change algorithm for autobrace.

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cullmann, #ktexteditor, mwolff, brauch, cactus Cc: kde-frameworks-devel, nalvarez, mwolff, anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, domson, michaelh, ngraham,

D4234: Change algorithm for autobrace.

cullmann commandeered this revision. cullmann added a reviewer: cactus. cullmann added a comment. We altered stuff in D19608 . Could you try if that fits your needs? If not, perhaps we need a new review for what can be further improved, thanks.

D20083: Multiple level of autobrace

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20083 To: cullmann, cactus Cc: cullmann, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D20083: Multiple level of autobrace

cullmann commandeered this revision. cullmann added a reviewer: cactus. cullmann added a comment. We consider this fixed with D19608 . If you disagree, feel free to reopen this request. Btw., thanks for the incentive to submit a patch! REPOSITORY R39

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

cullmann requested changes to this revision. This revision now requires changes to proceed. REVISION DETAIL https://phabricator.kde.org/D17693 To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson,

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) Thanks for quick fix. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21078 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel,

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

cullmann added a comment. I am not sure about the "UserSetsOfCharsToEncloseSelection" part. Wouldn't it be enough to have the "CharsToEncloseSelection" config part and have the other thing just internal in the editor config page as "template" the user can select to fill the selection of

D21028: add multiple gestures and a handler class to KWidgetsAddons

ngraham added a comment. Since these are touch-only, maybe `KTouchGesture` or `KTouchHandler`? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh, #frameworks Cc: ngraham, apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

steffenh added a comment. Hi @ngraham, thanks for the link, I see KGesture is already used. I hope KGestureHandler is not too similar REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh, #frameworks Cc: ngraham, apol, nicolasfella, cfeck,

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The arrow-*-double icons were symlinked to the go-top/bottom/first/last icons. Those

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21084 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven added a reviewer: Frameworks. REPOSITORY R241 KIO BRANCH arcpatch-D20838_1 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. Given that nobody else from #frameworks has offered any review comments, I say let's get it in early in this Frameworks cycle (i.e. now-ish) so we have almost a month of testing before release. REPOSITORY R241 KIO

D21028: add multiple gestures and a handler class to KWidgetsAddons

ngraham added a comment. Here's a tip: you can use https://lxr.kde.org to search for existing class names and identifiers. https://lxr.kde.org/search?_filestring=kgesture&_string= REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh,

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. @ngraham Should I wait for some more review/testing, or LGTM means let's get this merge ASAP ? REPOSITORY R241 KIO BRANCH arcpatch-D20838_1 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D20958: New menu of syntax highlighting in the status bar

loh.tar added a comment. >> I could add a "Recent" section to the beginning of the menu, it would be useful. > > Nice! Just to be clear. That should to be work over session borders, not only the current one. Should you do it, here some bug report

D21079: make sure to also assert ScaledDirectories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7e974fd48e0d: make sure to also assert ScaledDirectories (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21079?vs=57753=57754 REVISION

D21079: make sure to also assert ScaledDirectories

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21079 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21079: make sure to also assert ScaledDirectories

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY Directories and ScaledDirectories do the same thing, the latter is however used for backwards compatibility with old

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 62 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/62/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 08 May 2019 08:39:06 + Build duration: 1 hr 26 min and counting JUnit Tests

D21028: add multiple gestures and a handler class to KWidgetsAddons

steffenh added a comment. Hi @nicolasfella, Ok, I need a new name, perhaps KGesture ? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh, #frameworks Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

steffenh added a comment. Hi @apol, Thanks for your time to look at my code. I know, I'am not good at this, so if you can point me at my errors I will try to correct this. INLINE COMMENTS > apol wrote in koneandtwofingerswipe.h:36 > Why is this commented out? Oops this should not be

D19455: [knotification] compile without deprecated methods

dfaure added a comment. OK, it looks like everyone is waiting on everyone else in this discussion. Done now: https://commits.kde.org/knotifications/adc20218571941d19281ad81520aec62e195b355 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To:

D15910: Implement wl_surface::damage_buffer

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b71e10359725: Implement wl_surface::damage_buffer (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15910?vs=48477=57749#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 08 May 2019 07:51:01 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 May 2019 07:51:01 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 08 May 2019 07:51:01 + Build duration: 5 min 18 sec and counting BUILD ARTIFACTS