D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

kossebau updated this revision to Diff 58040. kossebau added a comment. Be verbose about behavioural adaption in API dox REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21174?vs=57963=58040 BRANCH makehaselementprefixmatchexpectation

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/101/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 13 May 2019 22:09:34 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 13 May 2019 22:02:04 + Build duration: 11 min and counting BUILD ARTIFACTS

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Needed e.g. to fix the missing update of the mask on changing the size of the

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/100/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 13 May 2019 21:50:12 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 13 May 2019 21:50:12 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/104/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 21:52:47 + Build duration: 3 min 53 sec and counting JUnit Tests

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH donotcrashformask REVISION DETAIL

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9142155b5a5b: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing - (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D21179: FrameSvgItem: emit maskChanged always from doUpdate()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:084ba0f886d1: FrameSvgItem: emit maskChanged always from doUpdate() (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/103/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 21:50:13 + Build duration: 2 min 30 sec and counting JUnit Tests

D21146: KProcessInfoList -- add proclist backend for FreeBSD

pino added a comment. In D21146#463948 , @tcberner wrote: > Gargh, the code `kdelibs` code formatter changed a lot more in `kprocesslist_unix_proc.cpp` than wanted :/ Then just rename kprocesslist_unix.cpp to kprocesslist_unix_proc.cpp,

D21146: KProcessInfoList -- add proclist backend for FreeBSD

adridg added inline comments. INLINE COMMENTS > kprocesslist_unix_proc.cpp:56 > #else > +# ifdef Q_OS_FREEBSD > +static const char formatC[] = "pid,state,user,command"; Are there situations where you would end up here? I mean, libprocstat is in base, since 9.0, so it is unlikely to be

D21197: [KCoreDirLister] Remove assert in reinsert method

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Here I am trying to fix #405461. We reach this assertion in reinsert() after we

D21155: Truncate long filname before creating a link

ngraham accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D21155 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ngraham added a comment. In D20140#463834 , @ndavis wrote: > In D20140#458379 , @filipf wrote: > > > Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do: > >

D20708: Change input-* device icon styles, add 16px icons

ngraham added a comment. I think that looks good! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20708 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

ngraham added a comment. the icon theme can be considered to be VDG-maintained these days, andI think this passes the visual design test, but also the most important thing is that you as the app author like it! However if this is the actual icon you want to ship with the app, do we even

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21149 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

aacid added a comment. it's not a hot path since no one is using this since this didn't work until i fixed it last week. So basically this is just for fun/sport REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21149 To: aacid, apol Cc: apol,

D21169: Add app icon for the Kirogi Drone control app

hein added a comment. I'd say it's up to the Breeze maintainers. From my end I'm very interested in the app having a Breeze-compatible icon, because I'd like it to integrate well with KDE's workspaces and other apps. Review by the Breeze community is very appreciated to help with that.

D21179: FrameSvgItem: emit maskChanged always from doUpdate()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvgitemmoreemitmaskchanged REVISION DETAIL https://phabricator.kde.org/D21179 To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel,

D17595: Upstream Dolphin's file rename dialog

dhaumann added a comment. Yes, please ask Peter Penz and CC a public mailing list and/or use the relicense check script. I am sure Peter would agree to a license change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: ngraham, #frameworks, #dolphin, broulik

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixdoxofprefix REVISION DETAIL https://phabricator.kde.org/D21173 To: kossebau, #plasma, dhaumann Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

dhaumann added a comment. @hindenburg: lgtm, could you comment? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added inline comments. INLINE COMMENTS > kossebau wrote in framesvg.cpp:150 > But given the return, if the else needed? Actually some people recommend to > not use else after return. I might be Monday blind, sorry :) I guess it doesn't matter. :) REPOSITORY R242 Plasma Framework

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added a comment. +1 LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21174 To: kossebau, #plasma Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

kossebau updated this revision to Diff 58006. kossebau added a comment. appended -> at the end REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21173?vs=57961=58006 BRANCH fixdoxofprefix REVISION DETAIL

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

kossebau added inline comments. INLINE COMMENTS > apol wrote in framesvg.cpp:150 > if (prefix.endsWith(QLatin1Char('-'))) { > return hasElement(prefix % QLatin1String("center")); > } else > return hasElement(prefix % QLatin1String("-center")); But given the return, if the else

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added inline comments. INLINE COMMENTS > kossebau wrote in framesvg.cpp:150 > How would you use the `else`? Not yet with you what you mean here, if (prefix.endsWith(QLatin1Char('-'))) { return hasElement(prefix % QLatin1String("center")); } else return hasElement(prefix %

D21169: Add app icon for the Kirogi Drone control app

ngraham added a comment. In D21169#464291 , @apol wrote: > Let's add it when the application exists? We should do it beforehand so the app gets the proper Breeze icon on launch day. REPOSITORY R266 Breeze Icons REVISION DETAIL

D21169: Add app icon for the Kirogi Drone control app

hein added a comment. @trickyricky26 It's great! What do you think about adding the detailed SVG as 256 version? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26, hein, #vdg Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

kossebau added inline comments. INLINE COMMENTS > apol wrote in framesvg.cpp:150 > else? or we want to test --center if -center fails? How would you use the `else`? Not yet with you what you mean here, REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D21183: search in the new location for knsrc files

This revision was automatically updated to reflect the committed changes. Closed by commit R252:e0df1f28231c: search in the new location for knsrc files (authored by mart). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21183?vs=57997=58001

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 58000. meven added a comment. Review, removed a dead variable in test, use QRegularExpression REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57707=58000 BRANCH arcpatch-D20838 REVISION DETAIL

D20838: Allow to drop one file or one folder on KDirOperator

meven marked 8 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham, #frameworks Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21183: search in the new location for knsrc files

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In the words of the interwebs whenever someone days a certain number: nice :) REPOSITORY R252 Framework Integration BRANCH phab/newlocation REVISION DETAIL

D21183: search in the new location for knsrc files

mart updated this revision to Diff 57997. mart added a comment. use configSearchLocations REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21183?vs=57993=57997 BRANCH phab/newlocation REVISION DETAIL https://phabricator.kde.org/D21183

D21183: search in the new location for knsrc files

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:49 > > -const auto knsname = > QStandardPaths::locate(QStandardPaths::GenericConfigLocation, url.host()); > +auto knsname = >

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

apol added inline comments. INLINE COMMENTS > framesvg.cpp:150 > +return hasElement(prefix % QLatin1String("center")); > +} > + else? or we want to test --center if -center fails? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21174

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

apol added inline comments. INLINE COMMENTS > framesvg.h:230 > /** > - * Returns the prefix for SVG elements of the FrameSvg > + * Returns the prefix for SVG elements of the FrameSvg (including the > appended '-' if not empty) > * @return the prefix "appended" reads weird.

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kcmutils.git/commit/?id=0af14cfe4dc55c6dcc6680b367fd78d2cf79b37d REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D21115 To: broulik, #plasma, mart Cc: heikobecker, kde-frameworks-devel,

D21183: search in the new location for knsrc files

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY search in the new knsrc location, still fallback to the old one for compatibility TEST PLAN

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D21115 To: broulik, #plasma, mart Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/99/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 13 May 2019 09:25:48 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/92/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 13 May 2019 09:25:48 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/102/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 09:25:48 + Build duration: 1 min 46 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/91/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 13 May 2019 08:55:32 + Build duration: 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/98/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 13 May 2019 08:55:31 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/101/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 08:55:31 + Build duration: 2 min 14 sec and counting JUnit Tests

D21172: FrameSvg: also clear mask cache on clearCache()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH clearalsomaskcache REVISION DETAIL https://phabricator.kde.org/D21172 To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh,

D20958: New menu of syntax highlighting in the status bar

dhaumann added a comment. Btw, I think this is a really nice improvement! Keep it coming :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar,

D21119: [JobDialog] Also signal cancellation when window is closed by the user

This revision was automatically updated to reflect the committed changes. Closed by commit R495:b70018ee4b3e: [JobDialog] Also signal cancellation when window is closed by the user (authored by broulik). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D21179: FrameSvgItem: emit maskChanged always from doUpdate()

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY In that method we can assue a high chance that the mask is also affected.