KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/45/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 03 Jun 2019 00:58:24 + Build duration: 35 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/49/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 03 Jun 2019 00:58:23 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Jun 2019 00:58:24 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/84/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 03 Jun 2019 00:37:46 + Build duration: 11 min and counting JUnit Tests Name:

D21541: [FileIndexScheduler] Add new state for Idle on battery

This revision was automatically updated to reflect the committed changes. Closed by commit R293:191b40317957: [FileIndexScheduler] Add new state for Idle on battery (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21541?vs=59014=59044

D21540: [FileIndexScheduler] Postpone housekeeping tasks while on battery

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d40f3c4eb321: [FileIndexScheduler] Postpone housekeeping tasks while on battery (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21539: [FileIndexScheduler] Avoid emitting state changes multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R293:429c25772e4f: [FileIndexScheduler] Avoid emitting state changes multiple times (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21538: [balooctl] Clarify and extend status output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:54ee1b062c34: [balooctl] Clarify and extend status output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21538?vs=59011=59041 REVISION DETAIL

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The unit test lacks structure, please think about: - how you can split this into separate test cases (basic functionality, renaming, ...) - how to use a data driven approach

D21541: [FileIndexScheduler] Add new state for Idle on battery

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome! REPOSITORY R293 Baloo BRANCH scheduler_powersave REVISION DETAIL https://phabricator.kde.org/D21541 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel,

D21540: [FileIndexScheduler] Postpone housekeeping tasks while on battery

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21540 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D21539: [FileIndexScheduler] Avoid emitting state changes multiple times

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21539 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D21538: [balooctl] Clarify and extend status output

ngraham accepted this revision. ngraham added a comment. Much clearer! REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21538 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D21532: Format the aperture values as F numbers.

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH photo_aperture REVISION DETAIL https://phabricator.kde.org/D21532 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D21459: Always save view settings when switching from one view mode to another

ngraham added a comment. Could you rebase this on current master? It doesn't apply for me right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 116 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/116/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Jun 2019 19:58:34 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/126/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 02 Jun 2019 19:58:34 + Build duration: 8 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 126 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/126/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 02 Jun 2019 19:58:34 + Build duration: 7 min 21 sec and counting BUILD ARTIFACTS

D21459: Always save view settings when switching from one view mode to another

meven added a comment. With D21315 landing, great time to have a look at this review ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » oxygen-icons5 » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/oxygen-icons5/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 02 Jun 2019 19:40:21 + Build duration: 18 min and counting JUnit Tests Name:

D21315: Dolphin-style view modes in the file dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d3098ed7205a: Dolphin-style view modes in the file dialog (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21315?vs=58832=59032#toc REPOSITORY R241 KIO CHANGES SINCE

D21315: Dolphin-style view modes in the file dialog

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 115 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/115/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Jun 2019 19:27:39 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/125/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 02 Jun 2019 19:35:02 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/125/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 02 Jun 2019 19:27:39 + Build duration: 8 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 124 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/124/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Jun 2019 16:39:06 + Build duration: 1 day 2 hr and counting BUILD ARTIFACTS

D21290: kio_ftp: improve error handling when copying to FTP fails

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21290 To: dfaure, bruns, apol, kossebau Cc: kde-frameworks-devel, pino, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 114 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/114/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 02 Jun 2019 16:31:42 + Build duration: 2 hr 52 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/67/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Jun 2019 18:43:14 + Build duration: 1 day 0 hr and counting JUnit Tests

D21532: Format the aperture values as F numbers.

astippich updated this revision to Diff 59029. astippich added a comment. - change formatting REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21532?vs=59003=59029 BRANCH photo_aperture REVISION DETAIL https://phabricator.kde.org/D21532 AFFECTED

D21538: [balooctl] Clarify and extend status output

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21538 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,

D21533: Format photo exposure time and bias as rational

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:167 > This will give a wrong result (1/2) for 0.4 seconds. I changed the threshold to be lower than that as a workaround. My impression was that only 1 over something

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59028. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59009=59028 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFECTED

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/124/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 02 Jun 2019 16:31:43 + Build duration: 6 min 55 sec and counting JUnit Tests Name:

D21367: kioexec: change the scary debug messages for delayed deletion

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cb5a3ac8ff22: kioexec: change the scary debug messages for delayed deletion (authored by Lekensteyn). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20169: Add profile support interface for TerminalInterface

mschiller added a comment. Oh sry, I wasn't aware of that. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

hindenburg added a comment. In D20169#473105 , @mschiller wrote: > ping I was waiting until the next release of frameworks is out. 5.59 Sat June 1st, 2019 (expected) Sat June 8th, 2019 REPOSITORY R306 KParts REVISION

D21290: kio_ftp: improve error handling when copying to FTP fails

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2019_freebsd_fixed REVISION DETAIL https://phabricator.kde.org/D21290 To: dfaure, bruns, apol, kossebau Cc: kde-frameworks-devel, pino, michaelh, ngraham, bruns

D21540: [FileIndexScheduler] Postpone housekeeping tasks while on battery

bruns retitled this revision from "[FileIndexScheduler] Postpone housekeeping tasks on battery" to "[FileIndexScheduler] Postpone housekeeping tasks while on battery". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21540 To: bruns, #baloo, ngraham, astippich Cc:

D21539: [FileIndexScheduler] Avoid emitting state changes multiple times

bruns added reviewers: Baloo, ngraham, astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21539 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20169: Add profile support interface for TerminalInterface

mschiller added a comment. ping REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

D21540: [FileIndexScheduler] Postpone housekeeping tasks on battery

bruns added a dependent revision: D21541: [FileIndexScheduler] Add new state for Idle on battery. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21540 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,

D21541: [FileIndexScheduler] Add new state for Idle on battery

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When the system is running on battery, the content indexing is

D21539: [FileIndexScheduler] Avoid emitting state changes multiple times

bruns added a dependent revision: D21540: [FileIndexScheduler] Postpone housekeeping tasks on battery. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21539 To: bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D21540: [FileIndexScheduler] Postpone housekeeping tasks on battery

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The index cleaner tasks may cause considerable disk and cpu load,

D21539: [FileIndexScheduler] Avoid emitting state changes multiple times

bruns created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY FileContentIndexer::quit() will cause emission of the done() signal, triggering scheduleIndexing() later.

D21532: Format the aperture values as F numbers.

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:168 > +{ > +return i18nc("F Number for photographs", "F%1", > QLocale().toString(value.toDouble(), 'g', 2)); > +} "f/%1" - lower case, reciprocal. REPOSITORY R286 KFileMetaData REVISION DETAIL

D21533: Format photo exposure time and bias as rational

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D21533: Format photo exposure time and bias as rational

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:134 > +{ Property::PhotoExposureTime, true, 0.0015625, > QStringLiteral("1/640")}, > +{ Property::PhotoExposureBiasValue, true, 0.333, > QStringLiteral("1/3")}, >

D21538: [balooctl] Clarify and extend status output

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The current index file count does not really tell what the numbers

D21533: Format photo exposure time and bias as rational

astippich updated this revision to Diff 59009. astippich added a comment. - check for zero REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21533?vs=59004=59009 BRANCH photo_time REVISION DETAIL https://phabricator.kde.org/D21533 AFFECTED FILES

D21532: Format the aperture values as F numbers.

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21532 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

astippich added a comment. Ideally it would be possible to store rationals in KFM and Baloo, but this is probably a lot of work. The computation here is quite simple REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc:

D21533: Format photo exposure time and bias as rational

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY If value is below 0.5, format the output as rational which

D21532: Format the aperture values as F numbers.

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH photo_aperture REVISION DETAIL

D21519: Rename ImageMake and ImageModel properties

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfo.cpp:185 > Isn't `Manufacturer` sufficient for the label? Same for `Model`. Well, I wanted to make clear that it is all about the equipment used for recording, but if everyone agrees that it is sufficient without

D21519: Rename ImageMake and ImageModel properties

bruns added inline comments. INLINE COMMENTS > propertyinfo.cpp:185 > +d->name = QStringLiteral("equipmentManufacturer"); > +d->displayName = i18nc("@label EXIF", "Equipment Manufacturer"); > d->valueType = QVariant::String; Isn't `Manufacturer` sufficient