D21565: phabricator: Fix fallthrough in switch

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH phab-fix-fallthrough REVISION DETAIL https://phabricator.kde.org/D21565 To: aspotashev, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko added inline comments. INLINE COMMENTS > bruns wrote in unindexedfileiteratortest.cpp:100 > Make this plain members, not pointers. > Also, one temporary dir is enough, you can put the db and the test tree > side-by-side. I wanted both DB and directory tree to be recreated from scratch

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko updated this revision to Diff 59099. poboiko marked 5 inline comments as done. poboiko added a comment. Use single temp dir Fixed `mTime -> cTime` REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21509?vs=59071=59099 BRANCH unindexed-renamed

D17595: Upstream Dolphin's file rename dialog

ngraham added a comment. Would you be interested in doing that and taking over this patch? I'm afraid I don't think I have the time right now for the kind of deep dive that it requires. If not, that's okay. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To:

D17595: Upstream Dolphin's file rename dialog

meven added a comment. In dolphin repo relicensecheck.pl views/renamedialog.h The following emails do not appear in the accounts file: schwarz...@gmail.com Need permission for licensing: - gplv2+: schwarz...@gmail.com mfuchs romaninflianskas mitchell

D21533: Format photo exposure time and bias as rational

bruns added inline comments. INLINE COMMENTS > astippich wrote in formatstrings.cpp:167 > I changed the threshold to be lower than that as a workaround. > My impression was that only 1 over something rationals are used, this > computation will of course fail for all other cases... For a chart

D21459: Always save view settings when switching from one view mode to another

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a comment. In D21459#473674 , @ngraham wrote: > If you're going to rename the functions because these actions no longer really toggle anything, I think we need to keep a verb in there. Suggest something like `_k_slotShowDetailsView`

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

bruns added inline comments. INLINE COMMENTS > unindexedfileiteratortest.cpp:100 > +Database* m_db; > +QTemporaryDir* m_dbdir; > +QTemporaryDir* m_testDir; Make this plain members, not pointers. Also, one temporary dir is enough, you can put the db and the test tree side-by-side.

D10362: Change reveal password button logic

GB_2 added a comment. In D10362#202592 , @elvisangelaccio wrote: > Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). > > Would it be possible to implement this feature

D10362: Change reveal password button logic

GB_2 retitled this revision from "Swap reveal password button logic" to "Change reveal password button logic". REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2,

D10362: Swap reveal password button logic

GB_2 edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello,

D10362: Swap reveal password button logic

GB_2 added a comment. Changed `onClicked` to `onPressedChanged` REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc:

D10362: Swap reveal password button logic

GB_2 updated this revision to Diff 59081. GB_2 added a comment. Change reveal password button logic REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=26701=59081 BRANCH change-reveal-password-button-logic (branched from master)

D10362: Swap reveal password button logic

GB_2 commandeered this revision. GB_2 added a reviewer: broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel,

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/122/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 03 Jun 2019 16:07:11 + Build duration: 54 min and counting JUnit Tests Name:

D21565: phabricator: Fix fallthrough in switch

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R495 Purpose Library BRANCH phab-fix-fallthrough REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/119/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Jun 2019 16:07:11 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/112/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 03 Jun 2019 16:07:11 + Build duration: 7 min 0 sec and counting BUILD ARTIFACTS

D21502: [PlasmaComponents3] Vertically center button text as well

This revision was automatically updated to reflect the committed changes. Closed by commit R242:adb999898842: [PlasmaComponents3] Vertically center button text as well (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D21502: [PlasmaComponents3] Vertically center button text as well

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH vertically-center-button-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D21502 To: ngraham, #plasma, broulik Cc: broulik, apol,

D21563: Fix empty pages in print preview and lines printed twice

ngraham added a comment. Fixes https://bugs.kde.org/show_bug.cgi?id=376270? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21563 To: hoffmannrobert Cc: ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D21563: Fix empty pages in print preview and lines printed twice

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY There were errors if a page's last line is too long and needs to be wrapped into two

D21533: Format photo exposure time and bias as rational

astippich planned changes to this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21533 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko updated this revision to Diff 59071. poboiko added a comment. Fixed comment with directory structure REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21509?vs=59070=59071 BRANCH unindexed-renamed REVISION DETAIL https://phabricator.kde.org/D21509

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko added inline comments. INLINE COMMENTS > bruns wrote in unindexedfileiterator.cpp:126 > This whole block belongs into a separate block, executed `if > (m_cTimeChanged)`. Did you mean `m_mTimeChanged`? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21509 To:

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko updated this revision to Diff 59070. poboiko marked 3 inline comments as done. poboiko added a comment. Moved `m_nameChanged` check inside separate block REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21509?vs=59068=59070 BRANCH unindexed-renamed

D21555: [KFilePlacesModel] Explicitly query for PTP cameras

broulik added a comment. The Solid predicate actually uses `Camera.supportedDrivers == 'gphoto'` and while this patch worked perfectly fine this morning somehow not nothing works :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21555 To: broulik, #frameworks, bruns

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko updated this revision to Diff 59068. poboiko added a comment. Split test to three separate test functions, which cover different test cases. Renamed folders to something more meaningful; put all the names as static consts in the very beginning, for further reuse inside test

D21459: Always save view settings when switching from one view mode to another

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. If you're going to rename the functions because these actions no longer really toggle anything, I think we need to keep a verb in there. Suggest something like `_k_slotShowDetailsView`

D21526: Add help-donate-[currency] icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e759724fab78: Add help-donate-[currency] icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21526?vs=58990=59060 REVISION DETAIL

D21459: Always save view settings when switching from one view mode to another

meven added a comment. In D21459#473429 , @ngraham wrote: > Could you rebase this on current master? It doesn't apply for me right now. Thanks, I forgot to do it ;) Should be fixed now. REPOSITORY R241 KIO REVISION DETAIL

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 59058. meven added a comment. Rebasing on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58854=59058 BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 AFFECTED FILES

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/85/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 03 Jun 2019 06:46:07 + Build duration: 2 hr 49 min and counting JUnit Tests Name:

D21526: Add help-donate-[currency] icons

sitter accepted this revision. REPOSITORY R266 Breeze Icons BRANCH donate-currency (branched from master) REVISION DETAIL https://phabricator.kde.org/D21526 To: ndavis, #vdg, sitter, broulik, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21379: [UDev Backend] Narrow device queried for

broulik updated this revision to Diff 59052. broulik edited the test plan for this revision. broulik added a comment. - Use `*` wildcard REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=58850=59052 REVISION DETAIL https://phabricator.kde.org/D21379

D21555: [KFilePlacesModel] Explicitly query for PTP cameras

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY From what I can tell Solid UDev backend returns all kinds of devices that

D21440: Delay running UnindexedFileIndexer and IndexCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a24624c88d79: Delay running UnindexedFileIndexer and IndexCleaner (authored by broulik). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21440?vs=58853=59047