D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59379. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated wrt review. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59377=59379 BRANCH win32 (branched from master)

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 5 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > sredman wrote in CMakeLists.txt:43 > Do you know whether this requires MSVC, or can SnoreToast.exe be built with > MSVC and KNotifications be built with an unspecified compiler? AFAIU it *should work

D21661: add snoretoast backend for KNotifications on Windows

sredman added inline comments. INLINE COMMENTS > CMakeLists.txt:43 > +if (WIN32) > + if (MSVC) > + find_package(LibSnoreToast REQUIRED) Do you know whether this requires MSVC, or can SnoreToast.exe be built with MSVC and KNotifications be built with an unspecified compiler? >

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop added a comment. It does work without any other code, because of the converter addon from R114 Plasma Addons . The screenshots seen in the report were generated after building KUnitConversion with this patch on KDE neon dev with

D21659: add .vscode to .gitignore

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e4461e0ba978: add .vscode to .gitignore (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21659?vs=59375=59378 REVISION DETAIL

D21660: simplify conditions and remove audio dependency for win32

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:42 > +else () > +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) > endif() We don't need DBus on Windows, do we? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To:

D21659: add .vscode to .gitignore

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH vscode (branched from master) REVISION DETAIL https://phabricator.kde.org/D21659 To: brute4s99, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n, michaelh,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 edited the summary of this revision. brute4s99 added reviewers: broulik, sredman, vonreth, albertvaka. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: kde-frameworks-devel, LeGast00n,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a dependency: D21602: Add NSIS Script for KDE Connect. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99 Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: simplify conditions and remove audio dependency for win32

brute4s99 added a dependency: D21657: remove phonon from deps if building for win32. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661

D21660: simplify conditions and remove audio dependency for win32

brute4s99 retitled this revision from "simplify conditions" to "simplify conditions and remove audio dependency for win32". brute4s99 edited the summary of this revision. brute4s99 added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660

D21660: simplify conditions

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D21660

D21659: add .vscode to .gitignore

brute4s99 created this revision. brute4s99 added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH vscode (branched from master) REVISION DETAIL

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

aacid added a comment. A little of both? First i ideally wouldn't want translators to have to translate this again when they're already doing it for KFormat, so using KFormat here if possible would be nice. Second, what's the expected use case of this? I don't see anyone needed a

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop added a comment. @aacid Are you asking me to use the KFormat functions for the KUnitConversion category I've created, or do you not think this should be supported by KUnitConversion at all? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To:

D21656: Create a breeze icon for kfourinline

ognarb updated this revision to Diff 59372. ognarb added a comment. Crop shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59371=59372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

aacid added a comment. @ngraham what is being requested is using existing code that does this instead of reinveinting the wheel. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid,

D21584: Add LE Advertising and GATT APIs

drosca added a comment. In D21584#475914 , @ngraham wrote: > What is the net effect of this patch? What does it improve? It adds initial support for Bluetooth Low Energy, it's not used anywhere in Plasma. REPOSITORY R269 BluezQt

D21584: Add LE Advertising and GATT APIs

ngraham added a comment. What is the net effect of this patch? What does it improve? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D21584 To: mweichselbaumer, drosca Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21584: Add LE Advertising and GATT APIs

mweichselbaumer closed this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D21584 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59349. mweichselbaumer added a comment. Fixed according to comments REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59346=59349 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584

D21584: Add LE Advertising and GATT APIs

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > gattapplication.h:85 > + */ > +virtual QDBusObjectPath objectPath() const; > + This should be protected > gattapplication.h:96 > + */ > +

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59346. mweichselbaumer added a comment. Fixed according to comments REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59277=59346 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584

D21519: Rename ImageMake and ImageModel properties

bruns added a comment. In D21519#475821 , @ngraham wrote: > "Camera Manufacturer"? Well, no ... also "Scanner, Phone, video digitizer, ..." Digikam just uses "Manufacturer" and "Model", as does Canons DPP REPOSITORY R286

D21519: Rename ImageMake and ImageModel properties

ngraham added a comment. "Camera Manufacturer"? REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich,

D21519: Rename ImageMake and ImageModel properties

bruns added a comment. In D21519#475781 , @ngraham wrote: > In D21519#474885 , @astippich wrote: > > > @ngraham what's your take regarding "Manufacturer" vs. "Equipment Manufacturer"? > > >

D21519: Rename ImageMake and ImageModel properties

ngraham added a comment. In D21519#474885 , @astippich wrote: > @ngraham what's your take regarding "Manufacturer" vs. "Equipment Manufacturer"? "Manufacturer" is shorter, but since the metadata is attached to a photo, the longer

D21584: Add LE Advertising and GATT APIs

mweichselbaumer marked an inline comment as done. mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in objectmanager.h:47 > I don't really like this class at all. This is implementation detail, and is > of no use for the users of the library, so it shouldn't be exported. On

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 59319. chinmoyr added a comment. use seteuid to make the logic for rename work REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14467?vs=59290=59319 BRANCH arcpatch-D14467 REVISION DETAIL

D21584: Add LE Advertising and GATT APIs

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. After this, it should be good to go. INLINE COMMENTS > drosca wrote in gattapplication.h:47 > Maybe it would be best to add constructor that uses default object path. Also >